From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30780 invoked by alias); 16 Jul 2010 19:30:52 -0000 Received: (qmail 30771 invoked by uid 22791); 16 Jul 2010 19:30:51 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM X-Spam-Check-By: sourceware.org Received: from mail-ey0-f169.google.com (HELO mail-ey0-f169.google.com) (209.85.215.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Jul 2010 19:30:42 +0000 Received: by eydd26 with SMTP id d26so735587eyd.0 for ; Fri, 16 Jul 2010 12:30:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.213.13.20 with SMTP id z20mr4692350ebz.35.1279308639719; Fri, 16 Jul 2010 12:30:39 -0700 (PDT) Received: by 10.213.11.1 with HTTP; Fri, 16 Jul 2010 12:30:39 -0700 (PDT) In-Reply-To: <19520.44698.410878.650267@fleche.redhat.com> References: <19520.44698.410878.650267@fleche.redhat.com> Date: Fri, 16 Jul 2010 19:30:00 -0000 Message-ID: Subject: Re: [PATCH] fix build failure for win64, revise some format strings From: Ozkan Sezer To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0015174c1706075317048b86414f Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00250.txt.bz2 --0015174c1706075317048b86414f Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1094 On Fri, Jul 16, 2010 at 10:10 PM, Tom Tromey wrote: > Ozkan> Actually I do: placed_address is CORE_ADDR which is > Ozkan> bfd_vma, ie. uintptr_t and not a pointer. > > Aha. =A0I didn't look that deeply. > There are different functions in utils.c for printing a CORE_ADDR. > > Tom > That would be core_addr_to_string() I guess (I'm learning), modified patch attached. OK to apply? (Should I use core_addr_to_string_nz to trim the leading zeroes instead?) * target.c (debug_to_insert_breakpoint): Instead of casting to unsigned long and %ld, use core_addr_to_string and %s to print CORE_ADDR vars and host_address_to_string() and %s for pointers. (debug_to_remove_breakpoint): Likewise. (debug_to_region_ok_for_hw_watchpoint): Likewise. (debug_to_can_accel_watchpoint_condition): Likewise. (debug_to_stopped_data_address): Likewise. (debug_to_watchpoint_addr_within_range): Likewise. (debug_to_insert_hw_breakpoint): Likewise. (debug_to_remove_hw_breakpoint): Likewise. (debug_to_insert_watchpoint): Likewise. (debug_to_remove_watchpoint): Likewise. -- Ozkan --0015174c1706075317048b86414f Content-Type: application/octet-stream; name="g1a.diff" Content-Disposition: attachment; filename="g1a.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gbpfftqp0 Content-length: 9272 MjAxMC0wNy0xNiAgT3prYW4gU2V6ZXIgIDxzZXplcm96QGdtYWlsLmNvbT4K CgkqIHRhcmdldC5jIChkZWJ1Z190b19pbnNlcnRfYnJlYWtwb2ludCk6IElu c3RlYWQgb2YgY2FzdGluZyB0byB1bnNpZ25lZAoJbG9uZyBhbmQgJWxkLCB1 c2UgY29yZV9hZGRyX3RvX3N0cmluZyBhbmQgJXMgdG8gcHJpbnQgQ09SRV9B RERSIHZhcnMgYW5kCglob3N0X2FkZHJlc3NfdG9fc3RyaW5nKCkgYW5kICVz IGZvciBwb2ludGVycy4KCShkZWJ1Z190b19yZW1vdmVfYnJlYWtwb2ludCk6 IExpa2V3aXNlLgoJKGRlYnVnX3RvX3JlZ2lvbl9va19mb3JfaHdfd2F0Y2hw b2ludCk6IExpa2V3aXNlLgoJKGRlYnVnX3RvX2Nhbl9hY2NlbF93YXRjaHBv aW50X2NvbmRpdGlvbik6IExpa2V3aXNlLgoJKGRlYnVnX3RvX3N0b3BwZWRf ZGF0YV9hZGRyZXNzKTogTGlrZXdpc2UuCgkoZGVidWdfdG9fd2F0Y2hwb2lu dF9hZGRyX3dpdGhpbl9yYW5nZSk6IExpa2V3aXNlLgoJKGRlYnVnX3RvX2lu c2VydF9od19icmVha3BvaW50KTogTGlrZXdpc2UuCgkoZGVidWdfdG9fcmVt b3ZlX2h3X2JyZWFrcG9pbnQpOiBMaWtld2lzZS4KCShkZWJ1Z190b19pbnNl cnRfd2F0Y2hwb2ludCk6IExpa2V3aXNlLgoJKGRlYnVnX3RvX3JlbW92ZV93 YXRjaHBvaW50KTogTGlrZXdpc2UuCgpJbmRleDogZ2RiL3RhcmdldC5jCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9n ZGIvdGFyZ2V0LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjU5CmRpZmYg LVU4IC1wIC1yMS4yNTkgdGFyZ2V0LmMKLS0tIGdkYi90YXJnZXQuYwk3IEp1 bCAyMDEwIDE2OjE1OjE3IC0wMDAwCTEuMjU5CisrKyBnZGIvdGFyZ2V0LmMJ MTYgSnVsIDIwMTAgMTk6MTY6NTcgLTAwMDAKQEAgLTMyNjUsMzMgKzMyNjUs MzMgQEAgc3RhdGljIGludAogZGVidWdfdG9faW5zZXJ0X2JyZWFrcG9pbnQg KHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLAogCQkJICAgIHN0cnVjdCBicF90 YXJnZXRfaW5mbyAqYnBfdGd0KQogewogICBpbnQgcmV0dmFsOwogCiAgIHJl dHZhbCA9IGRlYnVnX3RhcmdldC50b19pbnNlcnRfYnJlYWtwb2ludCAoZ2Ri YXJjaCwgYnBfdGd0KTsKIAogICBmcHJpbnRmX3VuZmlsdGVyZWQgKGdkYl9z dGRsb2csCi0JCSAgICAgICJ0YXJnZXRfaW5zZXJ0X2JyZWFrcG9pbnQgKDB4 JWx4LCB4eHgpID0gJWxkXG4iLAotCQkgICAgICAodW5zaWduZWQgbG9uZykg YnBfdGd0LT5wbGFjZWRfYWRkcmVzcywKKwkJICAgICAgInRhcmdldF9pbnNl cnRfYnJlYWtwb2ludCAoJXMsIHh4eCkgPSAlbGRcbiIsCisJCSAgICAgIGNv cmVfYWRkcl90b19zdHJpbmcgKGJwX3RndC0+cGxhY2VkX2FkZHJlc3MpLAog CQkgICAgICAodW5zaWduZWQgbG9uZykgcmV0dmFsKTsKICAgcmV0dXJuIHJl dHZhbDsKIH0KIAogc3RhdGljIGludAogZGVidWdfdG9fcmVtb3ZlX2JyZWFr cG9pbnQgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNoLAogCQkJICAgIHN0cnVj dCBicF90YXJnZXRfaW5mbyAqYnBfdGd0KQogewogICBpbnQgcmV0dmFsOwog CiAgIHJldHZhbCA9IGRlYnVnX3RhcmdldC50b19yZW1vdmVfYnJlYWtwb2lu dCAoZ2RiYXJjaCwgYnBfdGd0KTsKIAogICBmcHJpbnRmX3VuZmlsdGVyZWQg KGdkYl9zdGRsb2csCi0JCSAgICAgICJ0YXJnZXRfcmVtb3ZlX2JyZWFrcG9p bnQgKDB4JWx4LCB4eHgpID0gJWxkXG4iLAotCQkgICAgICAodW5zaWduZWQg bG9uZykgYnBfdGd0LT5wbGFjZWRfYWRkcmVzcywKKwkJICAgICAgInRhcmdl dF9yZW1vdmVfYnJlYWtwb2ludCAoJXMsIHh4eCkgPSAlbGRcbiIsCisJCSAg ICAgIGNvcmVfYWRkcl90b19zdHJpbmcgKGJwX3RndC0+cGxhY2VkX2FkZHJl c3MpLAogCQkgICAgICAodW5zaWduZWQgbG9uZykgcmV0dmFsKTsKICAgcmV0 dXJuIHJldHZhbDsKIH0KIAogc3RhdGljIGludAogZGVidWdfdG9fY2FuX3Vz ZV9od19icmVha3BvaW50IChpbnQgdHlwZSwgaW50IGNudCwgaW50IGZyb21f dHR5KQogewogICBpbnQgcmV0dmFsOwpAQCAtMzMxMCwzNSArMzMxMCwzNCBA QCBkZWJ1Z190b19jYW5fdXNlX2h3X2JyZWFrcG9pbnQgKGludCB0eXBlCiBz dGF0aWMgaW50CiBkZWJ1Z190b19yZWdpb25fb2tfZm9yX2h3X3dhdGNocG9p bnQgKENPUkVfQUREUiBhZGRyLCBpbnQgbGVuKQogewogICBDT1JFX0FERFIg cmV0dmFsOwogCiAgIHJldHZhbCA9IGRlYnVnX3RhcmdldC50b19yZWdpb25f b2tfZm9yX2h3X3dhdGNocG9pbnQgKGFkZHIsIGxlbik7CiAKICAgZnByaW50 Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLAotCQkgICAgICAidGFyZ2V0X3Jl Z2lvbl9va19mb3JfaHdfd2F0Y2hwb2ludCAoJWxkLCAlbGQpID0gMHglbHhc biIsCi0JCSAgICAgICh1bnNpZ25lZCBsb25nKSBhZGRyLAotCQkgICAgICAo dW5zaWduZWQgbG9uZykgbGVuLAotCQkgICAgICAodW5zaWduZWQgbG9uZykg cmV0dmFsKTsKKwkJICAgICAgInRhcmdldF9yZWdpb25fb2tfZm9yX2h3X3dh dGNocG9pbnQgKCVzLCAlbGQpID0gJXNcbiIsCisJCSAgICAgIGNvcmVfYWRk cl90b19zdHJpbmcgKGFkZHIpLCAodW5zaWduZWQgbG9uZykgbGVuLAorCQkg ICAgICBjb3JlX2FkZHJfdG9fc3RyaW5nIChyZXR2YWwpKTsKICAgcmV0dXJu IHJldHZhbDsKIH0KIAogc3RhdGljIGludAogZGVidWdfdG9fY2FuX2FjY2Vs X3dhdGNocG9pbnRfY29uZGl0aW9uIChDT1JFX0FERFIgYWRkciwgaW50IGxl biwgaW50IHJ3LAogCQkJCQkgc3RydWN0IGV4cHJlc3Npb24gKmNvbmQpCiB7 CiAgIGludCByZXR2YWw7CiAKICAgcmV0dmFsID0gZGVidWdfdGFyZ2V0LnRv X2Nhbl9hY2NlbF93YXRjaHBvaW50X2NvbmRpdGlvbiAoYWRkciwgbGVuLCBy dywgY29uZCk7CiAKICAgZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9n LAotCQkgICAgICAidGFyZ2V0X2Nhbl9hY2NlbF93YXRjaHBvaW50X2NvbmRp dGlvbiAoMHglbHgsICVkLCAlZCwgMHglbHgpID0gJWxkXG4iLAotCQkgICAg ICAodW5zaWduZWQgbG9uZykgYWRkciwgbGVuLCBydywgKHVuc2lnbmVkIGxv bmcpIGNvbmQsCi0JCSAgICAgICh1bnNpZ25lZCBsb25nKSByZXR2YWwpOwor CQkgICAgICAidGFyZ2V0X2Nhbl9hY2NlbF93YXRjaHBvaW50X2NvbmRpdGlv biAoJXMsICVkLCAlZCwgJXMpID0gJWxkXG4iLAorCQkgICAgICBjb3JlX2Fk ZHJfdG9fc3RyaW5nIChhZGRyKSwgbGVuLCBydywKKwkJICAgICAgaG9zdF9h ZGRyZXNzX3RvX3N0cmluZyAoY29uZCksICh1bnNpZ25lZCBsb25nKSByZXR2 YWwpOwogICByZXR1cm4gcmV0dmFsOwogfQogCiBzdGF0aWMgaW50CiBkZWJ1 Z190b19zdG9wcGVkX2J5X3dhdGNocG9pbnQgKHZvaWQpCiB7CiAgIGludCBy ZXR2YWw7CiAKQEAgLTMzNTMsOTYgKzMzNTIsOTYgQEAgZGVidWdfdG9fc3Rv cHBlZF9ieV93YXRjaHBvaW50ICh2b2lkKQogc3RhdGljIGludAogZGVidWdf dG9fc3RvcHBlZF9kYXRhX2FkZHJlc3MgKHN0cnVjdCB0YXJnZXRfb3BzICp0 YXJnZXQsIENPUkVfQUREUiAqYWRkcikKIHsKICAgaW50IHJldHZhbDsKIAog ICByZXR2YWwgPSBkZWJ1Z190YXJnZXQudG9fc3RvcHBlZF9kYXRhX2FkZHJl c3MgKHRhcmdldCwgYWRkcik7CiAKICAgZnByaW50Zl91bmZpbHRlcmVkIChn ZGJfc3RkbG9nLAotCQkgICAgICAidGFyZ2V0X3N0b3BwZWRfZGF0YV9hZGRy ZXNzIChbMHglbHhdKSA9ICVsZFxuIiwKLQkJICAgICAgKHVuc2lnbmVkIGxv bmcpKmFkZHIsCisJCSAgICAgICJ0YXJnZXRfc3RvcHBlZF9kYXRhX2FkZHJl c3MgKFslc10pID0gJWxkXG4iLAorCQkgICAgICBjb3JlX2FkZHJfdG9fc3Ry aW5nICgqYWRkciksCiAJCSAgICAgICh1bnNpZ25lZCBsb25nKXJldHZhbCk7 CiAgIHJldHVybiByZXR2YWw7CiB9CiAKIHN0YXRpYyBpbnQKIGRlYnVnX3Rv X3dhdGNocG9pbnRfYWRkcl93aXRoaW5fcmFuZ2UgKHN0cnVjdCB0YXJnZXRf b3BzICp0YXJnZXQsCiAJCQkJICAgICAgIENPUkVfQUREUiBhZGRyLAogCQkJ CSAgICAgICBDT1JFX0FERFIgc3RhcnQsIGludCBsZW5ndGgpCiB7CiAgIGlu dCByZXR2YWw7CiAKICAgcmV0dmFsID0gZGVidWdfdGFyZ2V0LnRvX3dhdGNo cG9pbnRfYWRkcl93aXRoaW5fcmFuZ2UgKHRhcmdldCwgYWRkciwKIAkJCQkJ CQkgc3RhcnQsIGxlbmd0aCk7CiAKICAgZnByaW50Zl9maWx0ZXJlZCAoZ2Ri X3N0ZGxvZywKLQkJICAgICJ0YXJnZXRfd2F0Y2hwb2ludF9hZGRyX3dpdGhp bl9yYW5nZSAoMHglbHgsIDB4JWx4LCAlZCkgPSAlZFxuIiwKLQkJICAgICh1 bnNpZ25lZCBsb25nKSBhZGRyLCAodW5zaWduZWQgbG9uZykgc3RhcnQsIGxl bmd0aCwKLQkJICAgIHJldHZhbCk7CisJCSAgICAidGFyZ2V0X3dhdGNocG9p bnRfYWRkcl93aXRoaW5fcmFuZ2UgKCVzLCAlcywgJWQpID0gJWRcbiIsCisJ CSAgICBjb3JlX2FkZHJfdG9fc3RyaW5nIChhZGRyKSwgY29yZV9hZGRyX3Rv X3N0cmluZyAoc3RhcnQpLAorCQkgICAgbGVuZ3RoLCByZXR2YWwpOwogICBy ZXR1cm4gcmV0dmFsOwogfQogCiBzdGF0aWMgaW50CiBkZWJ1Z190b19pbnNl cnRfaHdfYnJlYWtwb2ludCAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsCiAJ CQkgICAgICAgc3RydWN0IGJwX3RhcmdldF9pbmZvICpicF90Z3QpCiB7CiAg IGludCByZXR2YWw7CiAKICAgcmV0dmFsID0gZGVidWdfdGFyZ2V0LnRvX2lu c2VydF9od19icmVha3BvaW50IChnZGJhcmNoLCBicF90Z3QpOwogCiAgIGZw cmludGZfdW5maWx0ZXJlZCAoZ2RiX3N0ZGxvZywKLQkJICAgICAgInRhcmdl dF9pbnNlcnRfaHdfYnJlYWtwb2ludCAoMHglbHgsIHh4eCkgPSAlbGRcbiIs Ci0JCSAgICAgICh1bnNpZ25lZCBsb25nKSBicF90Z3QtPnBsYWNlZF9hZGRy ZXNzLAorCQkgICAgICAidGFyZ2V0X2luc2VydF9od19icmVha3BvaW50ICgl cywgeHh4KSA9ICVsZFxuIiwKKwkJICAgICAgY29yZV9hZGRyX3RvX3N0cmlu ZyAoYnBfdGd0LT5wbGFjZWRfYWRkcmVzcyksCiAJCSAgICAgICh1bnNpZ25l ZCBsb25nKSByZXR2YWwpOwogICByZXR1cm4gcmV0dmFsOwogfQogCiBzdGF0 aWMgaW50CiBkZWJ1Z190b19yZW1vdmVfaHdfYnJlYWtwb2ludCAoc3RydWN0 IGdkYmFyY2ggKmdkYmFyY2gsCiAJCQkgICAgICAgc3RydWN0IGJwX3Rhcmdl dF9pbmZvICpicF90Z3QpCiB7CiAgIGludCByZXR2YWw7CiAKICAgcmV0dmFs ID0gZGVidWdfdGFyZ2V0LnRvX3JlbW92ZV9od19icmVha3BvaW50IChnZGJh cmNoLCBicF90Z3QpOwogCiAgIGZwcmludGZfdW5maWx0ZXJlZCAoZ2RiX3N0 ZGxvZywKLQkJICAgICAgInRhcmdldF9yZW1vdmVfaHdfYnJlYWtwb2ludCAo MHglbHgsIHh4eCkgPSAlbGRcbiIsCi0JCSAgICAgICh1bnNpZ25lZCBsb25n KSBicF90Z3QtPnBsYWNlZF9hZGRyZXNzLAorCQkgICAgICAidGFyZ2V0X3Jl bW92ZV9od19icmVha3BvaW50ICglcywgeHh4KSA9ICVsZFxuIiwKKwkJICAg ICAgY29yZV9hZGRyX3RvX3N0cmluZyAoYnBfdGd0LT5wbGFjZWRfYWRkcmVz cyksCiAJCSAgICAgICh1bnNpZ25lZCBsb25nKSByZXR2YWwpOwogICByZXR1 cm4gcmV0dmFsOwogfQogCiBzdGF0aWMgaW50CiBkZWJ1Z190b19pbnNlcnRf d2F0Y2hwb2ludCAoQ09SRV9BRERSIGFkZHIsIGludCBsZW4sIGludCB0eXBl LAogCQkJICAgIHN0cnVjdCBleHByZXNzaW9uICpjb25kKQogewogICBpbnQg cmV0dmFsOwogCiAgIHJldHZhbCA9IGRlYnVnX3RhcmdldC50b19pbnNlcnRf d2F0Y2hwb2ludCAoYWRkciwgbGVuLCB0eXBlLCBjb25kKTsKIAogICBmcHJp bnRmX3VuZmlsdGVyZWQgKGdkYl9zdGRsb2csCi0JCSAgICAgICJ0YXJnZXRf aW5zZXJ0X3dhdGNocG9pbnQgKDB4JWx4LCAlZCwgJWQsIDB4JWxkKSA9ICVs ZFxuIiwKLQkJICAgICAgKHVuc2lnbmVkIGxvbmcpIGFkZHIsIGxlbiwgdHlw ZSwgKHVuc2lnbmVkIGxvbmcpIGNvbmQsCi0JCSAgICAgICh1bnNpZ25lZCBs b25nKSByZXR2YWwpOworCQkgICAgICAidGFyZ2V0X2luc2VydF93YXRjaHBv aW50ICglcywgJWQsICVkLCAlcykgPSAlbGRcbiIsCisJCSAgICAgIGNvcmVf YWRkcl90b19zdHJpbmcgKGFkZHIpLCBsZW4sIHR5cGUsCisJCSAgICAgIGhv c3RfYWRkcmVzc190b19zdHJpbmcgKGNvbmQpLCAodW5zaWduZWQgbG9uZykg cmV0dmFsKTsKICAgcmV0dXJuIHJldHZhbDsKIH0KIAogc3RhdGljIGludAog ZGVidWdfdG9fcmVtb3ZlX3dhdGNocG9pbnQgKENPUkVfQUREUiBhZGRyLCBp bnQgbGVuLCBpbnQgdHlwZSwKIAkJCSAgICBzdHJ1Y3QgZXhwcmVzc2lvbiAq Y29uZCkKIHsKICAgaW50IHJldHZhbDsKIAogICByZXR2YWwgPSBkZWJ1Z190 YXJnZXQudG9fcmVtb3ZlX3dhdGNocG9pbnQgKGFkZHIsIGxlbiwgdHlwZSwg Y29uZCk7CiAKICAgZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLAot CQkgICAgICAidGFyZ2V0X3JlbW92ZV93YXRjaHBvaW50ICgweCVseCwgJWQs ICVkLCAweCVsZCkgPSAlbGRcbiIsCi0JCSAgICAgICh1bnNpZ25lZCBsb25n KSBhZGRyLCBsZW4sIHR5cGUsICh1bnNpZ25lZCBsb25nKSBjb25kLAotCQkg ICAgICAodW5zaWduZWQgbG9uZykgcmV0dmFsKTsKKwkJICAgICAgInRhcmdl dF9yZW1vdmVfd2F0Y2hwb2ludCAoJXMsICVkLCAlZCwgJXMpID0gJWxkXG4i LAorCQkgICAgICBjb3JlX2FkZHJfdG9fc3RyaW5nIChhZGRyKSwgbGVuLCB0 eXBlLAorCQkgICAgICBob3N0X2FkZHJlc3NfdG9fc3RyaW5nIChjb25kKSwg KHVuc2lnbmVkIGxvbmcpIHJldHZhbCk7CiAgIHJldHVybiByZXR2YWw7CiB9 CiAKIHN0YXRpYyB2b2lkCiBkZWJ1Z190b190ZXJtaW5hbF9pbml0ICh2b2lk KQogewogICBkZWJ1Z190YXJnZXQudG9fdGVybWluYWxfaW5pdCAoKTsKIAo= --0015174c1706075317048b86414f--