From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26675 invoked by alias); 24 May 2010 23:07:46 -0000 Received: (qmail 26660 invoked by uid 22791); 24 May 2010 23:07:45 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 May 2010 23:07:40 +0000 Received: from hpaq7.eem.corp.google.com (hpaq7.eem.corp.google.com [172.25.149.7]) by smtp-out.google.com with ESMTP id o4ON7bHv003486 for ; Mon, 24 May 2010 16:07:38 -0700 Received: from pwj2 (pwj2.prod.google.com [10.241.219.66]) by hpaq7.eem.corp.google.com with ESMTP id o4ON7Zjl022924 for ; Mon, 24 May 2010 16:07:36 -0700 Received: by pwj2 with SMTP id 2so2289769pwj.26 for ; Mon, 24 May 2010 16:07:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.55.4 with SMTP id d4mr4559543rva.243.1274742455309; Mon, 24 May 2010 16:07:35 -0700 (PDT) Received: by 10.140.255.14 with HTTP; Mon, 24 May 2010 16:07:35 -0700 (PDT) In-Reply-To: References: <20100522165438.5D5A48439A@ruffy.mtv.corp.google.com> Date: Tue, 25 May 2010 03:05:00 -0000 Message-ID: Subject: Re: [RFA] new python features: gdb.GdbError, gdb.string_to_argv From: Doug Evans To: tromey@redhat.com Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00561.txt.bz2 On Mon, May 24, 2010 at 3:39 PM, Tom Tromey wrote: >>>>>> "Doug" =3D=3D Doug Evans writes: > > Doug> OTOOH there's commands that use parse_to_comma. =A0If gdb needs to > Doug> provide that (if only implemented as a wrapper around some > Doug> python-provided module, users should only ever have to import a > Doug> function and invoke it), then I think it should provide both > Doug> parse_to_comma and libiberty's buildargv. > > Ok, that sounds reasonable to me. > > Why doesn't your implementation actually use gdb_buildargv? Dunno. I'll check in the patch revised to use gdb_buildargv.