From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15258 invoked by alias); 5 Jan 2011 21:53:53 -0000 Received: (qmail 15242 invoked by uid 22791); 5 Jan 2011 21:53:52 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_BJ,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Jan 2011 21:53:46 +0000 Received: from wpaz13.hot.corp.google.com (wpaz13.hot.corp.google.com [172.24.198.77]) by smtp-out.google.com with ESMTP id p05Lrhn4022569 for ; Wed, 5 Jan 2011 13:53:43 -0800 Received: from qyk36 (qyk36.prod.google.com [10.241.83.164]) by wpaz13.hot.corp.google.com with ESMTP id p05LpNQs017285 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Wed, 5 Jan 2011 13:53:42 -0800 Received: by qyk36 with SMTP id 36so15359676qyk.13 for ; Wed, 05 Jan 2011 13:53:41 -0800 (PST) Received: by 10.229.228.79 with SMTP id jd15mr20246910qcb.130.1294264421763; Wed, 05 Jan 2011 13:53:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.7.132 with HTTP; Wed, 5 Jan 2011 13:53:11 -0800 (PST) In-Reply-To: <83mxnfm5ld.fsf@gnu.org> References: <20110105193621.A8CBF190B3A@elbrus2.mtv.corp.google.com> <83mxnfm5ld.fsf@gnu.org> From: Paul Pluzhnikov Date: Wed, 05 Jan 2011 21:53:00 -0000 Message-ID: Subject: Re: [patch] Add "debug jit" for easier tracing of JIT support internals To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016362844e61ac9270499206bbf X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00092.txt.bz2 --0016362844e61ac9270499206bbf Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 870 On Wed, Jan 5, 2011 at 12:01 PM, Doug Evans wrote: > I'd suggest removing "Higher numbers are more verbose." Done. > and while I haven't tried it, I wonder if show_jit_debug is necessary It's not. On Wed, Jan 5, 2011 at 12:57 PM, Eli Zaretskii wrote: >> =A0 =A0 =A0 (_initialize_jit): Register "debug jit" command. > > Since this is user-level setting, it should be in the manual. Done. One question: is '%zu' appropriate format for printing size_t ? Thanks, --=20 Paul Pluzhnikov ChangeLog: 2010-01-05 Paul Pluzhnikov * jit.c (jit_debug): New variable. (jit_register_code, jit_inferior_init): Add debug output. (_initialize_jit): Register "debug jit" command. doc/ChangeLog: 2010-01-05 Paul Pluzhnikov * gdb.texi (Debugging Output): Document "set debug jit" --0016362844e61ac9270499206bbf Content-Type: text/plain; charset=US-ASCII; name="gdb-jit-debug-20110105-2.txt" Content-Disposition: attachment; filename="gdb-jit-debug-20110105-2.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gikrkfbk0 Content-length: 5275 SW5kZXg6IGppdC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvc3JjL3NyYy9nZGIvaml0LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuOApkaWZmIC11IC1wIC1yMS44IGppdC5jCi0tLSBqaXQuYwkxIEphbiAy MDExIDE1OjMzOjA5IC0wMDAwCTEuOAorKysgaml0LmMJNSBKYW4gMjAxMSAy MTo0NjoxMCAtMDAwMApAQCAtMjEsNiArMjEsOCBAQAogCiAjaW5jbHVkZSAi aml0LmgiCiAjaW5jbHVkZSAiYnJlYWtwb2ludC5oIgorI2luY2x1ZGUgImNv bW1hbmQuaCIKKyNpbmNsdWRlICJnZGJjbWQuaCIKICNpbmNsdWRlICJnZGJj b3JlLmgiCiAjaW5jbHVkZSAib2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJvYmpm aWxlcy5oIgpAQCAtNDgsNiArNTAsMTAgQEAgc3RhdGljIENPUkVfQUREUiBq aXRfZGVzY3JpcHRvcl9hZGRyID0gMAogCiBzdGF0aWMgaW50IHJlZ2lzdGVy aW5nX2NvZGUgPSAwOwogCisvKiBOb24temVybyBpZiB3ZSB3YW50IHRvIHNl ZSB0cmFjZSBvZiBqaXQgbGV2ZWwgc3R1ZmYuICAqLworCitzdGF0aWMgaW50 IGppdF9kZWJ1ZyA9IDA7CisKIC8qIEhlbHBlciBjbGVhbnVwIGZ1bmN0aW9u IHRvIGNsZWFyIGFuIGludGVnZXIgZmxhZyBsaWtlIHRoZSBvbmUgYWJvdmUu ICAqLwogCiBzdGF0aWMgdm9pZApAQCAtMjE5LDYgKzIyNSwxMyBAQCBqaXRf cmVnaXN0ZXJfY29kZSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyCiAgIGNvbnN0 IHN0cnVjdCBiZmRfYXJjaF9pbmZvICpiOwogICBDT1JFX0FERFIgKmVudHJ5 X2FkZHJfcHRyOwogCisgIGlmIChqaXRfZGVidWcpCisgICAgZnByaW50Zl91 bmZpbHRlcmVkIChnZGJfc3RkbG9nLAorCQkJImppdF9yZWdpc3Rlcl9jb2Rl LCBzeW1maWxlX2FkZHIgPSAlcywgIgorCQkJInN5bWZpbGVfc2l6ZSA9ICV6 dVxuIiwKKwkJCXBhZGRyZXNzIChnZGJhcmNoLCBjb2RlX2VudHJ5LT5zeW1m aWxlX2FkZHIpLAorCQkJY29kZV9lbnRyeS0+c3ltZmlsZV9zaXplKTsKKwog ICBuYmZkID0gYmZkX29wZW5fZnJvbV90YXJnZXRfbWVtb3J5IChjb2RlX2Vu dHJ5LT5zeW1maWxlX2FkZHIsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvZGVfZW50cnktPnN5bWZpbGVfc2l6ZSwgZ251dGFy Z2V0KTsKICAgb2xkX2NsZWFudXBzID0gbWFrZV9jbGVhbnVwX2JmZF9jbG9z ZSAobmJmZCk7CkBAIC0zMTQsNiArMzI3LDExIEBAIGppdF9pbmZlcmlvcl9p bml0IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXIKICAgc3RydWN0IGppdF9jb2Rl X2VudHJ5IGN1cl9lbnRyeTsKICAgQ09SRV9BRERSIGN1cl9lbnRyeV9hZGRy OwogCisgIGlmIChqaXRfZGVidWcpCisgICAgZnByaW50Zl91bmZpbHRlcmVk IChnZGJfc3RkbG9nLAorCQkJImppdF9pbmZlcmlvcl9pbml0LCByZWdpc3Rl cmluZ19jb2RlID0gJWRcbiIsCisJCQlyZWdpc3RlcmluZ19jb2RlKTsKKwog ICAvKiBXaGVuIHdlIHJlZ2lzdGVyIGNvZGUsIEdEQiByZXNldHMgaXRzIGJy ZWFrcG9pbnRzIGluIGNhc2Ugc3ltYm9scyBoYXZlCiAgICAgIGNoYW5nZWQu ICBUaGF0IGluIHR1cm4gY2FsbHMgdGhpcyBoYW5kbGVyLCB3aGljaCBtYWtl cyB1cyBsb29rIGZvciBuZXcKICAgICAgY29kZSBhZ2Fpbi4gIFRvIGF2b2lk IGJlaW5nIHJlLWVudGVyZWQsIHdlIGNoZWNrIHRoaXMgZmxhZy4gICovCkBA IC0zMjksNiArMzQ3LDEwIEBAIGppdF9pbmZlcmlvcl9pbml0IChzdHJ1Y3Qg Z2RiYXJjaCAqZ2RiYXIKICAgaWYgKHJlZ19hZGRyID09IDApCiAgICAgcmV0 dXJuOwogCisgIGlmIChqaXRfZGVidWcpCisgICAgZnByaW50Zl91bmZpbHRl cmVkIChnZGJfc3RkbG9nLCAiaml0X2luZmVyaW9yX2luaXQsIHJlZ19hZGRy ID0gJXNcbiIsCisJCQlwYWRkcmVzcyAoZ2RiYXJjaCwgcmVnX2FkZHIpKTsK KwogICAvKiBMb29rdXAgdGhlIGRlc2NyaXB0b3Igc3ltYm9sIGFuZCBjYWNo ZSB0aGUgYWRkci4gIElmIGl0IGlzIG1pc3NpbmcsIHdlCiAgICAgIGFzc3Vt ZSB3ZSBhcmUgbm90IGF0dGFjaGVkIHRvIGEgSklUIGFuZCByZXR1cm4gZWFy bHkuICAqLwogICBkZXNjX3N5bWJvbCA9IGxvb2t1cF9taW5pbWFsX3N5bWJv bCAoaml0X2Rlc2NyaXB0b3JfbmFtZSwgTlVMTCwgTlVMTCk7CkBAIC0zMzgs NiArMzYwLDExIEBAIGppdF9pbmZlcmlvcl9pbml0IChzdHJ1Y3QgZ2RiYXJj aCAqZ2RiYXIKICAgaWYgKGppdF9kZXNjcmlwdG9yX2FkZHIgPT0gMCkKICAg ICByZXR1cm47CiAKKyAgaWYgKGppdF9kZWJ1ZykKKyAgICBmcHJpbnRmX3Vu ZmlsdGVyZWQgKGdkYl9zdGRsb2csCisJCQkiaml0X2luZmVyaW9yX2luaXQs IGppdF9kZXNjcmlwdG9yX2FkZHIgPSAlc1xuIiwKKwkJCXBhZGRyZXNzIChn ZGJhcmNoLCBqaXRfZGVzY3JpcHRvcl9hZGRyKSk7CisKICAgLyogUmVhZCB0 aGUgZGVzY3JpcHRvciBzbyB3ZSBjYW4gY2hlY2sgdGhlIHZlcnNpb24gbnVt YmVyIGFuZCBsb2FkIGFueSBhbHJlYWR5CiAgICAgIEpJVGVkIGZ1bmN0aW9u cy4gICovCiAgIGppdF9yZWFkX2Rlc2NyaXB0b3IgKGdkYmFyY2gsICZkZXNj cmlwdG9yKTsKQEAgLTQ1Myw2ICs0ODAsMTMgQEAgZXh0ZXJuIHZvaWQgX2lu aXRpYWxpemVfaml0ICh2b2lkKTsKIHZvaWQKIF9pbml0aWFsaXplX2ppdCAo dm9pZCkKIHsKKyAgYWRkX3NldHNob3dfemludGVnZXJfY21kICgiaml0Iiwg Y2xhc3NfbWFpbnRlbmFuY2UsICZqaXRfZGVidWcsIF8oIlwKK1NldCBKSVQg ZGVidWdnaW5nLiIpLCBfKCJcCitTaG93IEpJVCBkZWJ1Z2dpbmcuIiksIF8o IlwKK1doZW4gbm9uLXplcm8sIEpJVCBkZWJ1Z2dpbmcgaXMgZW5hYmxlZC4i KSwKKwkJCSAgICBOVUxMLCBOVUxMLAorCQkJICAgICZzZXRkZWJ1Z2xpc3Qs ICZzaG93ZGVidWdsaXN0KTsKKwogICBvYnNlcnZlcl9hdHRhY2hfaW5mZXJp b3JfY3JlYXRlZCAoaml0X2luZmVyaW9yX2NyZWF0ZWRfb2JzZXJ2ZXIpOwog ICBvYnNlcnZlcl9hdHRhY2hfaW5mZXJpb3JfZXhpdCAoaml0X2luZmVyaW9y X2V4aXRfaG9vayk7CiAgIGppdF9vYmpmaWxlX2RhdGEgPSByZWdpc3Rlcl9v YmpmaWxlX2RhdGEgKCk7CkluZGV4OiBkb2MvZ2RiLnRleGluZm8KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9k b2MvZ2RiLnRleGluZm8sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNzgzCmRp ZmYgLXUgLXAgLXIxLjc4MyBnZGIudGV4aW5mbwotLS0gZG9jL2dkYi50ZXhp bmZvCTUgSmFuIDIwMTEgMDU6MDk6NTIgLTAwMDAJMS43ODMKKysrIGRvYy9n ZGIudGV4aW5mbwk1IEphbiAyMDExIDIxOjQ2OjExIC0wMDAwCkBAIC0xOTk1 NSw2ICsxOTk1NSwxMSBAQCBUaGUgZGVmYXVsdCBpcyBvZmYuICBAZmlsZXtp bmZydW4uY30gY29uCiBmb3IgaW1wbGVtZW50aW5nIG9wZXJhdGlvbnMgc3Vj aCBhcyBzaW5nbGUtc3RlcHBpbmcgdGhlIGluZmVyaW9yLgogQGl0ZW0gc2hv dyBkZWJ1ZyBpbmZydW4KIERpc3BsYXlzIHRoZSBjdXJyZW50IHN0YXRlIG9m IEB2YWx1ZXtHREJOfSBpbmZlcmlvciBkZWJ1Z2dpbmcuCitAaXRlbSBzZXQg ZGVidWcgaml0CitAY2luZGV4IGp1c3QtaW4tdGltZSBjb21waWxhdGlvbgor VHVybnMgb24gb3Igb2ZmIGRlYnVnZ2luZyBtZXNzYWdlcyBmcm9tIEpJVCBk ZWJ1ZyBzdXBwb3J0LgorQGl0ZW0gc2hvdyBkZWJ1ZyBqaXQKK0Rpc3BsYXlz IHRoZSBjdXJyZW50IHN0YXRlIG9mIEB2YWx1ZXtHREJOfSBKSVQgZGVidWdn aW5nLgogQGl0ZW0gc2V0IGRlYnVnIGxpbi1sd3AKIEBjaW5kZXggQHNje2du dX0vTGludXggTFdQIGRlYnVnIG1lc3NhZ2VzCiBAY2luZGV4IExpbnV4IGxp Z2h0d2VpZ2h0IHByb2Nlc3Nlcwo= --0016362844e61ac9270499206bbf--