From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6546 invoked by alias); 18 Mar 2011 17:02:32 -0000 Received: (qmail 6535 invoked by uid 22791); 18 Mar 2011 17:02:29 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Mar 2011 17:02:24 +0000 Received: from hpaq11.eem.corp.google.com (hpaq11.eem.corp.google.com [172.25.149.11]) by smtp-out.google.com with ESMTP id p2IH2MQb028459 for ; Fri, 18 Mar 2011 10:02:22 -0700 Received: from vws7 (vws7.prod.google.com [10.241.21.135]) by hpaq11.eem.corp.google.com with ESMTP id p2IH0DsN026324 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 18 Mar 2011 10:02:20 -0700 Received: by vws7 with SMTP id 7so4521710vws.21 for ; Fri, 18 Mar 2011 10:02:20 -0700 (PDT) Received: by 10.52.18.5 with SMTP id s5mr822382vdd.156.1300467740176; Fri, 18 Mar 2011 10:02:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.60.9 with HTTP; Fri, 18 Mar 2011 10:01:50 -0700 (PDT) In-Reply-To: References: <20110316235418.34BA7190B17@elbrus2.mtv.corp.google.com> From: Paul Pluzhnikov Date: Fri, 18 Mar 2011 18:28:00 -0000 Message-ID: Subject: Re: [patch] Fix for PR gdb/12573 To: Tom Tromey Cc: gdb-patches@sourceware.org, Jan Kratochvil Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00925.txt.bz2 On Fri, Mar 18, 2011 at 9:29 AM, Tom Tromey wrote: >>>>>> "Paul" == Paul Pluzhnikov writes: > > Paul> Attached patch fixes http://sourceware.org/bugzilla/show_bug.cgi?id=12573 > Paul> by removing (I believe incorrect) assertion. > > See also: > > https://bugzilla.redhat.com/show_bug.cgi?id=612253 > > And Jan's patch: > > http://sourceware.org/ml/gdb-patches/2010-07/msg00533.html > > I can't say I fully understand Jan's. The patch looks good to me (and I *think* I understand it). > It includes yours, though, and comes with a test case. I was going to include a test case when pinging my patch in a week ;-) Jan, Could you reference PR gdb/12573 in your patch, and maybe commit it? + /* Place breakpoint only to the first PC in a function, even if some of + them are in a lexical sub-block. Put it too all the function + instances incl. the inlined ones. */ Suggest: Put it on all function instances as well, including inlined ones. Thanks, -- Paul Pluzhnikov