From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20697 invoked by alias); 21 May 2010 16:52:53 -0000 Received: (qmail 20667 invoked by uid 22791); 21 May 2010 16:52:48 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 May 2010 16:52:41 +0000 Received: from kpbe11.cbf.corp.google.com (kpbe11.cbf.corp.google.com [172.25.105.75]) by smtp-out.google.com with ESMTP id o4LGqcEA007801 for ; Fri, 21 May 2010 09:52:38 -0700 Received: from pxi10 (pxi10.prod.google.com [10.243.27.10]) by kpbe11.cbf.corp.google.com with ESMTP id o4LGqa1R012884 for ; Fri, 21 May 2010 09:52:37 -0700 Received: by pxi10 with SMTP id 10so564468pxi.21 for ; Fri, 21 May 2010 09:52:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.141.13.5 with SMTP id q5mr1346268rvi.280.1274460756332; Fri, 21 May 2010 09:52:36 -0700 (PDT) Received: by 10.140.255.14 with HTTP; Fri, 21 May 2010 09:52:36 -0700 (PDT) In-Reply-To: <4BF6A36A.4040308@oarcorp.com> References: <4BD1BBE3020000520000FC62@pluto.sron.nl> <4BE08E95.5040500@oarcorp.com> <20100517015752.GA24402@adacore.com> <20100520231045.GL3019@adacore.com> <4BF67A0D.3020607@oarcorp.com> <20100521150529.GR3019@adacore.com> <4BF6A36A.4040308@oarcorp.com> Date: Fri, 21 May 2010 17:13:00 -0000 Message-ID: Subject: Re: [patch] sim/erc32/ max simulation time extended by using 64bit ints From: Doug Evans To: Joel Sherrill Cc: Joel Brobecker , Tiemen Schut , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-05/txt/msg00501.txt.bz2 On Fri, May 21, 2010 at 8:14 AM, Joel Sherrill wrote: > On 05/21/2010 10:05 AM, Joel Brobecker wrote: >>>>> >>>>> =A0 =A0 =A0 =A0 * sis.h: Remove #include. >>>>> =A0 =A0 =A0 =A0 (uint64, int64): Redefine without using stdint.h. >>>>> =A0 =A0 =A0 =A0 (UINT64_MAX): Define. >>>>> >>>> >>>> FYI: I just checked that one in. >>>> >>>> >>> >>> Doug do you still want that VAL -> =A0strtol/ll change? >>> >> >> Can you provide more info, which change is that? >> > > Doug seemed to want to get rid of the "VAL" macros > in the sim/erc32 source code. =A0I handled one file in > this patch because it was only used once in the file > and it seemed silly to even have the macro. =A0The other > two files had more uses so I wanted to wait until > the maximum time to 64 bits was committed. > > Here is his comment > > =A0 1) > > =A0 -#define =A0 =A0 VAL(x) =A0strtol(x,(char **)NULL,0) > =A0 +#define =A0 =A0 VAL(x) =A0strtoull(x,(char **)NULL,0) > > > =A0 I realize VAL is only used once in interf.c but it's also defined in > =A0 other files as well. > =A0 While one could consolidate them, having the macro at all is probably > =A0 less preferable to just calling strtoul{,l} directly. > =A0 I would just remove it from interf.c and call strtoull directly. > > I have fixed this in interf.c. =A0But didn't touch the other files. > Is this OK? I only mentioned it because the original patch changed its definition and instead of doing that it seemed better to just get rid of it. But it's not critical or anything, just "IWBN".