Re: [patch] Correct origin calculation of command line window in TUI mode

[Balazs Kezes <rlblaster@gmail.com>]

> These three patches now put you at borderline of
> what we can accept without copyright assignment to the FSF.  Do
> you have that taken care of?  If not, let us know, and we'll start
> you on the process.

I'm not sure what you are talking about. I don't think I'll be doing a lot
more work on this so it might be superfluous if this means what I think.


On 7/28/10, Pedro Alves <pedro@codesourcery.com> wrote:
> On Tuesday 27 July 2010 23:38:02, Balazs Kezes wrote:
>> > Hmmm, I've tried all three patches together, and I still get a messed
>> > up cmd window after a couple of resizes (e.g., start
>> > maxized/unmaximize/maximize).
>>
>> Yeah, these 3 patches are not enough. There are two remaining
>> modifications
>> which need to be done:
>
> Ah.
>
>> 1) HAVE_RESIZE_TERM - to make sure ncurses knows about the terminal size.
>>    Somehow this needs to be added to the configuration. I'm not sure how
>> to do
>>    this. Maybe I'll look into this sometime.
>
> I'll do this.  These three patches now put you at borderline of
> what we can accept without copyright assignment to the FSF.  Do
> you have that taken care of?  If not, let us know, and we'll start
> you on the process.
>
>> 2) The readline modification in order to have correct sizes. I've already
>>    contacted the readline guys and they told me that this bug will be
>> fixed in
>>    readline 6.2.
>
> That's good news.  In that case, I don't think there's a problem in
> backporting the fix to our local copy.  Distros can do the same to
> their system readline's if they care too.
>
>> Even after this there is a little annoyance that you need to press a
>> key to actually resize and redraw everything, but this could be fixed
>> by ungetc or with a similar hack.
>>
>> Here are the changelogs:
>
> Thanks.  I'll take another look at this soon.
>
> --
> Pedro Alves
>