From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13588 invoked by alias); 11 Jan 2011 15:07:56 -0000 Received: (qmail 13575 invoked by uid 22791); 11 Jan 2011 15:07:55 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_FRT_PROFILE2,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Jan 2011 15:07:49 +0000 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id p0BF7jt5005678 for ; Tue, 11 Jan 2011 07:07:46 -0800 Received: from qwk4 (qwk4.prod.google.com [10.241.195.132]) by kpbe16.cbf.corp.google.com with ESMTP id p0BF6tfe013486 for ; Tue, 11 Jan 2011 07:07:44 -0800 Received: by qwk4 with SMTP id 4so22530915qwk.32 for ; Tue, 11 Jan 2011 07:07:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.63.195 with SMTP id c3mr28008734qai.364.1294758463927; Tue, 11 Jan 2011 07:07:43 -0800 (PST) Received: by 10.220.118.80 with HTTP; Tue, 11 Jan 2011 07:07:43 -0800 (PST) In-Reply-To: <201101082239.10670.vapier@gentoo.org> References: <1293426471-5571-1-git-send-email-vapier@gentoo.org> <201012280238.03847.vapier@gentoo.org> <20101228120120.GE2436@adacore.com> <201101082239.10670.vapier@gentoo.org> Date: Tue, 11 Jan 2011 15:07:00 -0000 Message-ID: Subject: Re: [PATCH] sim: allow memory maps to default to mapped files From: Doug Evans To: Mike Frysinger Cc: Joel Brobecker , gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00217.txt.bz2 On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger wrote: > On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote: >> OK. =A0The patch looks good to me, except for the little formatting nits >> that I already pointed out. But can you give it a few more days for >> others to comment? =A0In particular, Doug Evans is more proficient with >> the simulator than I am, I believe (which is not hard, considering >> that I have barely ever touched that code). > > i'll commit in a day or two if no one has any more feedback ... Hi. The only comment I have is that it would be nice to keep "struct stat s;" in its original location, but it's not necessary.