Re: [PATCH] Add -lpwl to ppllibs.

Richard Guenther
2011-03-02T12:20:55Z

On Wed, Mar 2, 2011 at 4:49 AM, Sebastian Pop <sebpop@gmail.com> wrote:
> Hi,
>
> On Sun, Feb 27, 2011 at 03:38, Ralf Wildenhues <ralf.wildenhues@gmx.de> wrote:
>> * Sebastian Pop wrote on Sun, Feb 27, 2011 at 08:23:15AM CET:
>>> On Sun, Feb 27, 2011 at 00:35, Ralf Wildenhues wrote:
>>> > * Sebastian Pop wrote on Wed, Feb 23, 2011 at 09:47:07PM CET:
>>> >> here is the updated patch with your remarks and the remarks from
>>> >> Rainer.  We still have the libs in the same order: -lppl_c -lppl
>>> >> $pwllib, and I will change the order following what Roberto says.
>>> >
>>> > Well, has Roberto replied yet?  The contents of the patch depend
>>> > on the answer, and I'd rather review that version of the patch
>>> > that is supposed to go in.
>>> >
>>> > The patch looks OK for the case that pwl doesn't depend on any
>>> > of the other PPL libs.
>>>
>>> I have not yet received an answer for the question of whether PWL is
>>> independent of PPL.
>>
>> He answered now.  So the patch is OK.
>>
>>> > Please remember that toplevel patches need to be synced to src.
>>>
>>> Am I supposed to commit the configure changes to a different place
>>> than gcc trunk?
>>
>> Yes, to the src CVS repository, and Cc:ing binutils and gdb-patches
>> at sourceware.org.  See
>> http://gcc.gnu.org/codingconventions.html#upstream for details.
>
> Here are the two patches that I committed to
> svn+ssh://spop@gcc.gnu.org/svn/gcc
> and synced to :ext:spop@sourceware.org:/cvs/src

This broke bootstrap for me.

gcc -g -fkeep-inline-functions -DIN_GCC -W -Wall -Wwrite-strings
-Wcast-qual -Wstrict-prototypes -Wmissing-prototypes
-Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Wold-style-definition
-Wc++-compat -fno-common -DHAVE_CONFIG_H -o cc1 c-lang.o
c-family/stub-objc.o attribs.o c-errors.o c-decl.o c-typeck.o
c-convert.o c-aux-info.o c-objc-common.o c-parser.o tree-mudflap.o
c-family/c-common.o c-family/c-cppbuiltin.o c-family/c-dump.o
c-family/c-format.o c-family/c-gimplify.o c-family/c-lex.o
c-family/c-omp.o c-family/c-opts.o c-family/c-pch.o
c-family/c-ppoutput.o c-family/c-pragma.o c-family/c-pretty-print.o
c-family/c-semantics.o c-family/c-ada-spec.o i386-c.o \
cc1-checksum.o main.o tree-browser.o libbackend.a
../libcpp/libcpp.a ../libdecnumber/libdecnumber.a ../libcpp/libcpp.a
../libiberty/libiberty.a ../libdecnumber/libdecnumber.a -lcloog
-lmpc -lmpfr -lgmp -rdynamic -ldl -L../zlib -lz
libbackend.a(graphite-ppl.o): In function `ppl_powerset_is_empty':
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:552: undefined
reference to `ppl_new_PIP_Problem_from_constraints'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:553: undefined
reference to `ppl_PIP_Problem_is_satisfiable'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:555: undefined
reference to `ppl_delete_PIP_Problem'
collect2: ld returned 1 exit status
make[3]: *** [cc1] Error 1
make[3]: *** Waiting for unfinished jobs....
libbackend.a(graphite-ppl.o): In function `ppl_powerset_is_empty':
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:552: undefined
reference to `ppl_new_PIP_Problem_from_constraints'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:553: undefined
reference to `ppl_PIP_Problem_is_satisfiable'
/space/rguenther/src/svn/trunk/gcc/graphite-ppl.c:555: undefined
reference to `ppl_delete_PIP_Problem'
collect2: ld returned 1 exit status
make[3]: *** [lto1] Error 1
rm gcov.pod cpp.pod gfdl.pod fsf-funding.pod gcc.pod
make[3]: Leaving directory `/home/abuild/rguenther/obj/gcc'
make[2]: *** [all-stage1-gcc] Error 2
make[2]: Leaving directory `/home/abuild/rguenther/obj'
make[1]: *** [stage1-bubble] Error 2
make[1]: Leaving directory `/home/abuild/rguenther/obj'
make: *** [all] Error 2

so it seems it broke some configure tests. I have ppl-0.11 and cloog 0.15.10.

As you can see from the link line it doesn't link ppl at all. ppllibs is empty
for me.

Please revert or fix ASAP.

Richard.

> Sebastian
>