From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79712-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4107 invoked by alias); 15 Mar 2011 21:45:43 -0000
Received: (qmail 4058 invoked by uid 22791); 15 Mar 2011 21:45:41 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 21:45:35 +0000
Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65])	by smtp-out.google.com with ESMTP id p2FLjXn1011394	for <gdb-patches@sourceware.org>; Tue, 15 Mar 2011 14:45:33 -0700
Received: from gxk23 (gxk23.prod.google.com [10.202.11.23])	by wpaz1.hot.corp.google.com with ESMTP id p2FLjWoq022134	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT)	for <gdb-patches@sourceware.org>; Tue, 15 Mar 2011 14:45:32 -0700
Received: by gxk23 with SMTP id 23so458009gxk.28        for <gdb-patches@sourceware.org>; Tue, 15 Mar 2011 14:45:32 -0700 (PDT)
Received: by 10.91.90.20 with SMTP id s20mr563487agl.98.1300225532141; Tue, 15 Mar 2011 14:45:32 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.91.172.7 with HTTP; Tue, 15 Mar 2011 14:45:02 -0700 (PDT)
In-Reply-To: <20110315212428.GA21487@host1.jankratochvil.net>
References: <AANLkTim5vFBo4=mP7-83dqKbmuMAP3ThS6ZW_VN3rjg4@mail.gmail.com> <m3wrk560mf.fsf@fleche.redhat.com> <AANLkTin=U9bE2NoO4abS-qibKMsOCEj+-=G7k=OjXYXf@mail.gmail.com> <20110315004140.GA28560@host1.jankratochvil.net> <AANLkTimka58XAPbM45uv-DFKezKS5J-RTM-8mvBeaQMS@mail.gmail.com> <20110315183650.GA29330@host1.jankratochvil.net> <AANLkTin7qeNsg5nGLQ44ybKpx492DW1UgjzH-Arqfqu-@mail.gmail.com> <20110315190304.GA784@host1.jankratochvil.net> <AANLkTinjSzyJvNQkeyvQaxOWvFeMnfKjAJ5w=G+VMc6R@mail.gmail.com> <20110315212428.GA21487@host1.jankratochvil.net>
From: Paul Pluzhnikov <ppluzhnikov@google.com>
Date: Wed, 16 Mar 2011 00:13:00 -0000
Message-ID: <AANLkTik7JYPdOTgyGnQ4aLT_0BZf+1hCBVZnKc+tweZC@mail.gmail.com>
Subject: Re: [patch] Re: Advice on fixing gdb/12528
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>,        Doug Evans <dje@google.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00825.txt.bz2

On Tue, Mar 15, 2011 at 2:24 PM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Tue, 15 Mar 2011 20:27:56 +0100, Paul Pluzhnikov wrote:
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* This line table is for a functi=
on which has been
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0GCd by the linker. =A0Ignor=
e it. =A0PR gdb/12528 */
>> +
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 complaint (&symfile_complaints,
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0_(".debug_l=
ine section at address 0"));
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0complaint (&symfile_complaints,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _(".debug=
_line offset 0x%lx uses address 0 "
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "[in =
module %s]"),
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (long) (l=
ine_ptr
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 - dwarf2_per_objfile->line.buffer),
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 cu->objfi=
le->name);
>
> (the offset is not right but better than nothing)

Maybe like this:

		  if (address =3D=3D 0 && !dwarf2_per_objfile->has_section_at_zero)
		    {
		      /* This line table is for a function which has been
			 GCd by the linker.  Ignore it.  PR gdb/12528 */

		      long line_offset
			=3D line_ptr - bytes_read - dwarf2_per_objfile->line.buffer;

		      complaint (&symfile_complaints,
				 _(".debug_line offset 0x%lx uses address 0 "
				   "[in module %s]"),
				 line_offset, cu->objfile->name);
		      p_record_line =3D noop_record_line;
		    }


Thanks,
--=20
Paul Pluzhnikov