From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2015 invoked by alias); 10 Jan 2011 18:00:45 -0000 Received: (qmail 1853 invoked by uid 22791); 10 Jan 2011 18:00:43 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Jan 2011 18:00:38 +0000 Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id p0AI0a5K028614 for ; Mon, 10 Jan 2011 10:00:36 -0800 Received: from qyk32 (qyk32.prod.google.com [10.241.83.160]) by kpbe16.cbf.corp.google.com with ESMTP id p0AI07eS029697 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Mon, 10 Jan 2011 10:00:35 -0800 Received: by qyk32 with SMTP id 32so1820455qyk.2 for ; Mon, 10 Jan 2011 10:00:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.211.206 with SMTP id gp14mr5664414qcb.289.1294682434685; Mon, 10 Jan 2011 10:00:34 -0800 (PST) Received: by 10.220.118.80 with HTTP; Mon, 10 Jan 2011 10:00:34 -0800 (PST) In-Reply-To: <1294539266-12692-1-git-send-email-vapier@gentoo.org> References: <1294539266-12692-1-git-send-email-vapier@gentoo.org> Date: Mon, 10 Jan 2011 18:00:00 -0000 Message-ID: Subject: Re: [PATCH] sim: add noreturn markings to more hw abort/halt funcs From: Doug Evans To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00195.txt.bz2 On Sat, Jan 8, 2011 at 6:14 PM, Mike Frysinger wrote: > These functions either call abort() themselves, or call functions which > are already marked noreturn. =A0Either way, they don't return, so mark th= em > as such so calling code can assume this. =A0This fixes some uninitialized > warnings due to code paths that end in an abort function. > > Signed-off-by: Mike Frysinger > > 2010-01-08 =A0Mike Frysinger =A0 > > =A0 =A0 =A0 =A0* hw-device.h (hw_abort, hw_vabort, hw_halt): Add noreturn= attribute. > =A0 =A0 =A0 =A0* sim-hw.h (sim_hw_abort): Likewise. This is ok.