From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28516 invoked by alias); 16 Nov 2010 22:44:42 -0000 Received: (qmail 28504 invoked by uid 22791); 16 Nov 2010 22:44:41 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Nov 2010 22:44:36 +0000 Received: from kpbe15.cbf.corp.google.com (kpbe15.cbf.corp.google.com [172.25.105.79]) by smtp-out.google.com with ESMTP id oAGMiYxQ023050 for ; Tue, 16 Nov 2010 14:44:35 -0800 Received: from qwh6 (qwh6.prod.google.com [10.241.194.198]) by kpbe15.cbf.corp.google.com with ESMTP id oAGMiXiW019406 for ; Tue, 16 Nov 2010 14:44:33 -0800 Received: by qwh6 with SMTP id 6so1094887qwh.33 for ; Tue, 16 Nov 2010 14:44:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.28.204 with SMTP id n12mr126517qac.148.1289947473375; Tue, 16 Nov 2010 14:44:33 -0800 (PST) Received: by 10.220.185.203 with HTTP; Tue, 16 Nov 2010 14:44:33 -0800 (PST) In-Reply-To: <20101116223618.GB2703@host0.dyn.jankratochvil.net> References: <20101116211114.EAB2A2460AB@ruffy.mtv.corp.google.com> <20101116223618.GB2703@host0.dyn.jankratochvil.net> Date: Tue, 16 Nov 2010 22:44:00 -0000 Message-ID: Subject: Re: [patch] Handle absent "/usr/sbin/" in prelink error output. From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00219.txt.bz2 On Tue, Nov 16, 2010 at 2:36 PM, Jan Kratochvil wrote: > On Tue, 16 Nov 2010 22:23:35 +0100, Doug Evans wrote: >> On Tue, Nov 16, 2010 at 1:11 PM, Doug Evans wrote: >> > --- lib/prelink-support.exp =A0 =A0 12 Oct 2010 18:12:49 -0000 =A0 =A0= =A01.3 >> > +++ lib/prelink-support.exp =A0 =A0 16 Nov 2010 21:06:58 -0000 >> > @@ -221,7 +221,7 @@ proc prelink_no {arg {name {}}} { >> > =A0 =A0 } >> > =A0 =A0 # Last line does miss the trailing \n. =A0There can be multipl= e such messages >> > =A0 =A0 # as ARG may list multiple files. >> > - =A0 =A0if {$result =3D=3D 1 && [regexp {^(/usr/sbin/prelink[^\r\n]*:= [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { >> > + =A0 =A0if {$result =3D=3D 1 && [regexp {^((/usr/sbin/)?prelink[^\r\n= ]*: [^ ]* does not have .gnu.prelink_undo section\n?)*$} $output]} { >> > =A0 =A0 =A0 =A0pass $test >> > =A0 =A0 =A0 =A0return 1 >> > =A0 =A0 } else { >> > >> >> Well, this shouldn't have caused a regression, but break-interp.exp >> breaks badly with it. >> So there's a deeper bug here. =A0Blech. > > I do not have any of the problems reproducible on Fedora 14 x86_64 (which= is > understandable as the testcases were written on this platform). =A0I do n= ot see > why your proposed patch should break anything. > > But speaking specifically about gdb.base/attach-pie-misread.exp I am free= to > drop it whole. =A0The problem is very difficult to reliably reproduce, va= rious > memory alignments must match to make the former problem reproducible. Thanks for the offer to delete attach-pie-misread.exp. I wouldn't delete it just yet, as I also have four failures in break-interp.exp to fix too. They're fixed with the above patch, but then many more failures are introduced. I'm wondering if at least part of the problem is in prelink_{no,yes}. Is it possible for them to return zero (i.e. "fail") but not trigger a test failure? e.g. is there a conflation of "feature is present but not working" with "feature is not present"? Dunno, just a wild guess at this point.