From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80077-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25366 invoked by alias); 30 Mar 2011 00:06:41 -0000
Received: (qmail 25357 invoked by uid 22791); 30 Mar 2011 00:06:40 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Mar 2011 00:06:35 +0000
Received: by wyf19 with SMTP id 19so761624wyf.0        for <gdb-patches@sourceware.org>; Tue, 29 Mar 2011 17:06:34 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.195.139 with SMTP id p11mr453787wen.67.1301443594368; Tue, 29 Mar 2011 17:06:34 -0700 (PDT)
Received: by 10.216.38.6 with HTTP; Tue, 29 Mar 2011 17:06:34 -0700 (PDT)
In-Reply-To: <83y63xr3b0.fsf@gnu.org>
References: <004701cbede4$0ee18c20$2ca4a460$%muller@ics-cnrs.unistra.fr>	<E1Q4Y9z-0004UD-1Y@fencepost.gnu.org>	<003001cbee11$49bb0880$dd311980$%muller@ics-cnrs.unistra.fr>	<201103291523.46954.pedro@codesourcery.com>	<831v1psnl9.fsf@gnu.org>	<AANLkTimdp28yv_Q+tsDWOqFsNWaifZfRUB7K629tUuha@mail.gmail.com>	<83y63xr3b0.fsf@gnu.org>
Date: Wed, 30 Mar 2011 06:25:00 -0000
Message-ID: <AANLkTi=jaLR5zhRq+pQkx2KwtyWEJqQXuWQTu_Jwur1b@mail.gmail.com>
Subject: Re: [RFC] Missing sleep function for mingw hosts
From: Matt Rice <ratmice@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, 	pierre.muller@ics-cnrs.unistra.fr
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg01190.txt.bz2

On Tue, Mar 29, 2011 at 3:04 PM, Eli Zaretskii <eliz@gnu.org> wrote:

>
> Aha, and all that for a function whose definition, including empty
> lines and comments, is 14 lines (10 lines without that slack).
> Typical.
>

except it allows one to remove those 14 lines from gdb proper,
and call the sleep with impunity.

we & others benefit from the portability problems which we & they encounter.
like if it works with values of 49 or 29 days on various platforms.

you forgot that gdb_usleep depends on gdb_select which has 2 implementations
of either 134 or 3 lines which gnulib also has a module for.

so thats 147 lines of c code that could potentially be removed,
allowing gdb to focus on being a debugger
rather than a debugger with an ad-hoc portability layer.