From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76156-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7807 invoked by alias); 20 Oct 2010 20:13:28 -0000
Received: (qmail 7798 invoked by uid 22791); 20 Oct 2010 20:13:27 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Oct 2010 20:13:18 +0000
Received: from kpbe13.cbf.corp.google.com (kpbe13.cbf.corp.google.com [172.25.105.77])	by smtp-out.google.com with ESMTP id o9KKDFiG027119	for <gdb-patches@sourceware.org>; Wed, 20 Oct 2010 13:13:15 -0700
Received: from vws12 (vws12.prod.google.com [10.241.21.140])	by kpbe13.cbf.corp.google.com with ESMTP id o9KKCXGq015166	for <gdb-patches@sourceware.org>; Wed, 20 Oct 2010 13:13:14 -0700
Received: by vws12 with SMTP id 12so2528636vws.17        for <gdb-patches@sourceware.org>; Wed, 20 Oct 2010 13:13:13 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.198.136 with SMTP id eo8mr928462vcb.104.1287605592854; Wed, 20 Oct 2010 13:13:12 -0700 (PDT)
Received: by 10.220.118.2 with HTTP; Wed, 20 Oct 2010 13:13:12 -0700 (PDT)
In-Reply-To: <4CBEDBF5.9060504@codesourcery.com>
References: <4CBEDBF5.9060504@codesourcery.com>
Date: Wed, 20 Oct 2010 20:13:00 -0000
Message-ID: <AANLkTi=ZusdpB4=kcF_0tAPEQkPEuNwdXhrhQDTfw_fs@mail.gmail.com>
Subject: Re: Fix Makefile.in in data-directory
From: Doug Evans <dje@google.com>
To: Jie Zhang <jie@codesourcery.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-10/txt/msg00321.txt.bz2

On Wed, Oct 20, 2010 at 5:09 AM, Jie Zhang <jie@codesourcery.com> wrote:
>
> The current install rule in the Makefile.in of data-directory uses recurs=
ive make but does not pass FLAGS_TO_PASS. This causes an issue when people =
try to override prefix with command line option "make install", i.e. data-d=
irectory will still be installed under the configure time prefix. This patc=
h fixes it. =A0OK?

[Apologies for the resend.]

Thanks for the bug report.  Forgot about that.

This patch is not ok though.  A parallel make (e.g. -jN) might try to
build all and install-only simultaneously.

maybe:
$(MAKE) install-only $(FLAGS_TO_PASS)


For reference sake, there are other instances of "install: all install-only=
".
They need to be fixed too.