Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kai Tietz <ktietz70@googlemail.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	gdb-patches@sourceware.org, 	Binutils <binutils@sourceware.org>
Cc: Dave Korn <dave.korn.cygwin@gmail.com>
Subject: RFC: Issue about assumption of DOSish file-system for cygwin
Date: Tue, 22 Mar 2011 13:22:00 -0000	[thread overview]
Message-ID: <AANLkTi=Yuahw9-OE8=ACayWDd2GvSnXsSxXAVqCuOUzy@mail.gmail.com> (raw)

Hello,

I noticed this issue while working on those directory-separator thing
for DOSish file-systems, and somehow this looks odd to me. For some
reason the filenames.h header assumes for cygwin DOSish file-system,
but in fact cygwin uses POSIXish file-system. I assume this definition
was caused by the times cygwin compiler had -mno-cygwin option, but
well I think we should correct this by following patch.
Dave, might it be that I am overlooking here something obvious, why
cygwin should assume DOSish filesystem?

Regards,
Kai

Index: filenames.h
===================================================================
--- filenames.h (revision 171281)
+++ filenames.h (working copy)
@@ -30,7 +30,8 @@
 extern "C" {
 #endif

-#if defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__) ||
defined (__CYGWIN__)
+#if (defined(__MSDOS__) || defined(_WIN32) || defined(__OS2__)) \
+    && !defined (__CYGWIN__)
 #  ifndef HAVE_DOS_BASED_FILE_SYSTEM
 #    define HAVE_DOS_BASED_FILE_SYSTEM 1
 #  endif


             reply	other threads:[~2011-03-22 11:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 13:22 Kai Tietz [this message]
2011-03-22 18:11 ` Dave Korn
2011-03-22 18:24   ` Kai Tietz
2011-03-22 18:57     ` Pedro Alves
2011-03-22 19:51       ` Kai Tietz
2011-03-22 19:53         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=Yuahw9-OE8=ACayWDd2GvSnXsSxXAVqCuOUzy@mail.gmail.com' \
    --to=ktietz70@googlemail.com \
    --cc=binutils@sourceware.org \
    --cc=dave.korn.cygwin@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox