From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29488 invoked by alias); 5 Jan 2011 23:16:13 -0000 Received: (qmail 29478 invoked by uid 22791); 5 Jan 2011 23:16:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_BJ,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Jan 2011 23:16:07 +0000 Received: from hpaq13.eem.corp.google.com (hpaq13.eem.corp.google.com [172.25.149.13]) by smtp-out.google.com with ESMTP id p05NG4De001768 for ; Wed, 5 Jan 2011 15:16:04 -0800 Received: from qyk12 (qyk12.prod.google.com [10.241.83.140]) by hpaq13.eem.corp.google.com with ESMTP id p05NFTni005319 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Wed, 5 Jan 2011 15:16:03 -0800 Received: by qyk12 with SMTP id 12so17942237qyk.19 for ; Wed, 05 Jan 2011 15:16:02 -0800 (PST) Received: by 10.224.28.212 with SMTP id n20mr22422931qac.181.1294269362617; Wed, 05 Jan 2011 15:16:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.7.132 with HTTP; Wed, 5 Jan 2011 15:15:31 -0800 (PST) In-Reply-To: <201101052257.30806.pedro@codesourcery.com> References: <20110105193621.A8CBF190B3A@elbrus2.mtv.corp.google.com> <201101052257.30806.pedro@codesourcery.com> From: Paul Pluzhnikov Date: Wed, 05 Jan 2011 23:16:00 -0000 Message-ID: Subject: Re: [patch] Add "debug jit" for easier tracing of JIT support internals To: Pedro Alves Cc: gdb-patches@sourceware.org, Doug Evans Content-Type: multipart/mixed; boundary=0015175ce00e9a3d430499219156 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00098.txt.bz2 --0015175ce00e9a3d430499219156 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1457 On Wed, Jan 5, 2011 at 2:51 PM, Pedro Alves wrote: > On Wednesday 05 January 2011 21:53:11, Paul Pluzhnikov wrote: >> One question: is '%zu' appropriate format for printing size_t ? > > Nope, %z is C99. =A0GDB is currently written in C90. > > AFAICS, the size_t you're talking about holds the size of an > object on the target, Right. It's actually specified as uint64_t in jit.h, not size_t ... > while 'size_t' is about sizes of objects > on the host. =A0E.g., on a 32-bit GDB (cross) debugging a 64-bit > inferior, size_t will usually be a 32-bit type. =A0I think it'd be > better to make that a ULONGEST throughout (and then use phex > or pulongest) Since this interface is frozen, and ULONGEST isn't available to clients, I'll just cast symfile_size to ULONGEST and print it with pulongest. On Wed, Jan 5, 2011 at 2:57 PM, Pedro Alves wrote: > Until and if we find a better way, an implemented show callback > should be a requirement for all new commands. Restored to the original ... Thanks, --=20 Paul Pluzhnikov ChangeLog: 2010-01-05 Paul Pluzhnikov * jit.c (jit_debug): New variable. (show_jit_debug): New function. (jit_register_code, jit_inferior_init): Add debug output. (_initialize_jit): Register "debug jit" command. doc/ChangeLog: 2010-01-05 Paul Pluzhnikov * gdb.texi (Debugging Output): Document "set debug jit" --0015175ce00e9a3d430499219156 Content-Type: text/plain; charset=US-ASCII; name="gdb-jit-debug-20110105-3.txt" Content-Disposition: attachment; filename="gdb-jit-debug-20110105-3.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gikuh0b20 Content-length: 5584 SW5kZXg6IGppdC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvc3JjL3NyYy9nZGIvaml0LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuOApkaWZmIC11IC1wIC1yMS44IGppdC5jCi0tLSBqaXQuYwkxIEphbiAy MDExIDE1OjMzOjA5IC0wMDAwCTEuOAorKysgaml0LmMJNSBKYW4gMjAxMSAy MzowOTo0NSAtMDAwMApAQCAtMjEsNiArMjEsOCBAQAogCiAjaW5jbHVkZSAi aml0LmgiCiAjaW5jbHVkZSAiYnJlYWtwb2ludC5oIgorI2luY2x1ZGUgImNv bW1hbmQuaCIKKyNpbmNsdWRlICJnZGJjbWQuaCIKICNpbmNsdWRlICJnZGJj b3JlLmgiCiAjaW5jbHVkZSAib2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJvYmpm aWxlcy5oIgpAQCAtNDgsNiArNTAsMTcgQEAgc3RhdGljIENPUkVfQUREUiBq aXRfZGVzY3JpcHRvcl9hZGRyID0gMAogCiBzdGF0aWMgaW50IHJlZ2lzdGVy aW5nX2NvZGUgPSAwOwogCisvKiBOb24temVybyBpZiB3ZSB3YW50IHRvIHNl ZSB0cmFjZSBvZiBqaXQgbGV2ZWwgc3R1ZmYuICAqLworCitzdGF0aWMgaW50 IGppdF9kZWJ1ZyA9IDA7CisKK3N0YXRpYyB2b2lkCitzaG93X2ppdF9kZWJ1 ZyAoc3RydWN0IHVpX2ZpbGUgKmZpbGUsIGludCBmcm9tX3R0eSwKKwkJc3Ry dWN0IGNtZF9saXN0X2VsZW1lbnQgKmMsIGNvbnN0IGNoYXIgKnZhbHVlKQor eworICBmcHJpbnRmX2ZpbHRlcmVkIChmaWxlLCBfKCJKSVQgZGVidWdnaW5n IGlzICVzLlxuIiksIHZhbHVlKTsKK30KKwogLyogSGVscGVyIGNsZWFudXAg ZnVuY3Rpb24gdG8gY2xlYXIgYW4gaW50ZWdlciBmbGFnIGxpa2UgdGhlIG9u ZSBhYm92ZS4gICovCiAKIHN0YXRpYyB2b2lkCkBAIC0yMTksNiArMjMyLDEz IEBAIGppdF9yZWdpc3Rlcl9jb2RlIChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXIK ICAgY29uc3Qgc3RydWN0IGJmZF9hcmNoX2luZm8gKmI7CiAgIENPUkVfQURE UiAqZW50cnlfYWRkcl9wdHI7CiAKKyAgaWYgKGppdF9kZWJ1ZykKKyAgICBm cHJpbnRmX3VuZmlsdGVyZWQgKGdkYl9zdGRsb2csCisJCQkiaml0X3JlZ2lz dGVyX2NvZGUsIHN5bWZpbGVfYWRkciA9ICVzLCAiCisJCQkic3ltZmlsZV9z aXplID0gJXNcbiIsCisJCQlwYWRkcmVzcyAoZ2RiYXJjaCwgY29kZV9lbnRy eS0+c3ltZmlsZV9hZGRyKSwKKwkJCXB1bG9uZ2VzdCAoKFVMT05HRVNUKSBj b2RlX2VudHJ5LT5zeW1maWxlX3NpemUpKTsKKwogICBuYmZkID0gYmZkX29w ZW5fZnJvbV90YXJnZXRfbWVtb3J5IChjb2RlX2VudHJ5LT5zeW1maWxlX2Fk ZHIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv ZGVfZW50cnktPnN5bWZpbGVfc2l6ZSwgZ251dGFyZ2V0KTsKICAgb2xkX2Ns ZWFudXBzID0gbWFrZV9jbGVhbnVwX2JmZF9jbG9zZSAobmJmZCk7CkBAIC0z MTQsNiArMzM0LDExIEBAIGppdF9pbmZlcmlvcl9pbml0IChzdHJ1Y3QgZ2Ri YXJjaCAqZ2RiYXIKICAgc3RydWN0IGppdF9jb2RlX2VudHJ5IGN1cl9lbnRy eTsKICAgQ09SRV9BRERSIGN1cl9lbnRyeV9hZGRyOwogCisgIGlmIChqaXRf ZGVidWcpCisgICAgZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9nLAor CQkJImppdF9pbmZlcmlvcl9pbml0LCByZWdpc3RlcmluZ19jb2RlID0gJWRc biIsCisJCQlyZWdpc3RlcmluZ19jb2RlKTsKKwogICAvKiBXaGVuIHdlIHJl Z2lzdGVyIGNvZGUsIEdEQiByZXNldHMgaXRzIGJyZWFrcG9pbnRzIGluIGNh c2Ugc3ltYm9scyBoYXZlCiAgICAgIGNoYW5nZWQuICBUaGF0IGluIHR1cm4g Y2FsbHMgdGhpcyBoYW5kbGVyLCB3aGljaCBtYWtlcyB1cyBsb29rIGZvciBu ZXcKICAgICAgY29kZSBhZ2Fpbi4gIFRvIGF2b2lkIGJlaW5nIHJlLWVudGVy ZWQsIHdlIGNoZWNrIHRoaXMgZmxhZy4gICovCkBAIC0zMjksNiArMzU0LDEw IEBAIGppdF9pbmZlcmlvcl9pbml0IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXIK ICAgaWYgKHJlZ19hZGRyID09IDApCiAgICAgcmV0dXJuOwogCisgIGlmIChq aXRfZGVidWcpCisgICAgZnByaW50Zl91bmZpbHRlcmVkIChnZGJfc3RkbG9n LCAiaml0X2luZmVyaW9yX2luaXQsIHJlZ19hZGRyID0gJXNcbiIsCisJCQlw YWRkcmVzcyAoZ2RiYXJjaCwgcmVnX2FkZHIpKTsKKwogICAvKiBMb29rdXAg dGhlIGRlc2NyaXB0b3Igc3ltYm9sIGFuZCBjYWNoZSB0aGUgYWRkci4gIElm IGl0IGlzIG1pc3NpbmcsIHdlCiAgICAgIGFzc3VtZSB3ZSBhcmUgbm90IGF0 dGFjaGVkIHRvIGEgSklUIGFuZCByZXR1cm4gZWFybHkuICAqLwogICBkZXNj X3N5bWJvbCA9IGxvb2t1cF9taW5pbWFsX3N5bWJvbCAoaml0X2Rlc2NyaXB0 b3JfbmFtZSwgTlVMTCwgTlVMTCk7CkBAIC0zMzgsNiArMzY3LDExIEBAIGpp dF9pbmZlcmlvcl9pbml0IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXIKICAgaWYg KGppdF9kZXNjcmlwdG9yX2FkZHIgPT0gMCkKICAgICByZXR1cm47CiAKKyAg aWYgKGppdF9kZWJ1ZykKKyAgICBmcHJpbnRmX3VuZmlsdGVyZWQgKGdkYl9z dGRsb2csCisJCQkiaml0X2luZmVyaW9yX2luaXQsIGppdF9kZXNjcmlwdG9y X2FkZHIgPSAlc1xuIiwKKwkJCXBhZGRyZXNzIChnZGJhcmNoLCBqaXRfZGVz Y3JpcHRvcl9hZGRyKSk7CisKICAgLyogUmVhZCB0aGUgZGVzY3JpcHRvciBz byB3ZSBjYW4gY2hlY2sgdGhlIHZlcnNpb24gbnVtYmVyIGFuZCBsb2FkIGFu eSBhbHJlYWR5CiAgICAgIEpJVGVkIGZ1bmN0aW9ucy4gICovCiAgIGppdF9y ZWFkX2Rlc2NyaXB0b3IgKGdkYmFyY2gsICZkZXNjcmlwdG9yKTsKQEAgLTQ1 Myw2ICs0ODcsMTQgQEAgZXh0ZXJuIHZvaWQgX2luaXRpYWxpemVfaml0ICh2 b2lkKTsKIHZvaWQKIF9pbml0aWFsaXplX2ppdCAodm9pZCkKIHsKKyAgYWRk X3NldHNob3dfemludGVnZXJfY21kICgiaml0IiwgY2xhc3NfbWFpbnRlbmFu Y2UsICZqaXRfZGVidWcsIF8oIlwKK1NldCBKSVQgZGVidWdnaW5nLiIpLCBf KCJcCitTaG93IEpJVCBkZWJ1Z2dpbmcuIiksIF8oIlwKK1doZW4gbm9uLXpl cm8sIEpJVCBkZWJ1Z2dpbmcgaXMgZW5hYmxlZC4iKSwKKwkJCSAgICBOVUxM LAorCQkJICAgIHNob3dfaml0X2RlYnVnLAorCQkJICAgICZzZXRkZWJ1Z2xp c3QsICZzaG93ZGVidWdsaXN0KTsKKwogICBvYnNlcnZlcl9hdHRhY2hfaW5m ZXJpb3JfY3JlYXRlZCAoaml0X2luZmVyaW9yX2NyZWF0ZWRfb2JzZXJ2ZXIp OwogICBvYnNlcnZlcl9hdHRhY2hfaW5mZXJpb3JfZXhpdCAoaml0X2luZmVy aW9yX2V4aXRfaG9vayk7CiAgIGppdF9vYmpmaWxlX2RhdGEgPSByZWdpc3Rl cl9vYmpmaWxlX2RhdGEgKCk7CkluZGV4OiBkb2MvZ2RiLnRleGluZm8KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dk Yi9kb2MvZ2RiLnRleGluZm8sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNzgz CmRpZmYgLXUgLXAgLXIxLjc4MyBnZGIudGV4aW5mbwotLS0gZG9jL2dkYi50 ZXhpbmZvCTUgSmFuIDIwMTEgMDU6MDk6NTIgLTAwMDAJMS43ODMKKysrIGRv Yy9nZGIudGV4aW5mbwk1IEphbiAyMDExIDIzOjA5OjQ2IC0wMDAwCkBAIC0x OTk1NSw2ICsxOTk1NSwxMSBAQCBUaGUgZGVmYXVsdCBpcyBvZmYuICBAZmls ZXtpbmZydW4uY30gY29uCiBmb3IgaW1wbGVtZW50aW5nIG9wZXJhdGlvbnMg c3VjaCBhcyBzaW5nbGUtc3RlcHBpbmcgdGhlIGluZmVyaW9yLgogQGl0ZW0g c2hvdyBkZWJ1ZyBpbmZydW4KIERpc3BsYXlzIHRoZSBjdXJyZW50IHN0YXRl IG9mIEB2YWx1ZXtHREJOfSBpbmZlcmlvciBkZWJ1Z2dpbmcuCitAaXRlbSBz ZXQgZGVidWcgaml0CitAY2luZGV4IGp1c3QtaW4tdGltZSBjb21waWxhdGlv bgorVHVybnMgb24gb3Igb2ZmIGRlYnVnZ2luZyBtZXNzYWdlcyBmcm9tIEpJ VCBkZWJ1ZyBzdXBwb3J0LgorQGl0ZW0gc2hvdyBkZWJ1ZyBqaXQKK0Rpc3Bs YXlzIHRoZSBjdXJyZW50IHN0YXRlIG9mIEB2YWx1ZXtHREJOfSBKSVQgZGVi dWdnaW5nLgogQGl0ZW0gc2V0IGRlYnVnIGxpbi1sd3AKIEBjaW5kZXggQHNj e2dudX0vTGludXggTFdQIGRlYnVnIG1lc3NhZ2VzCiBAY2luZGV4IExpbnV4 IGxpZ2h0d2VpZ2h0IHByb2Nlc3Nlcwo= --0015175ce00e9a3d430499219156--