From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10272 invoked by alias); 17 Feb 2011 08:16:59 -0000 Received: (qmail 10264 invoked by uid 22791); 17 Feb 2011 08:16:58 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,TW_RG X-Spam-Check-By: sourceware.org Received: from mail-gx0-f169.google.com (HELO mail-gx0-f169.google.com) (209.85.161.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 08:16:53 +0000 Received: by gxk5 with SMTP id 5so970086gxk.0 for ; Thu, 17 Feb 2011 00:16:51 -0800 (PST) Received: by 10.150.211.5 with SMTP id j5mr1952106ybg.378.1297930611611; Thu, 17 Feb 2011 00:16:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.147.114.12 with HTTP; Thu, 17 Feb 2011 00:16:31 -0800 (PST) In-Reply-To: References: From: Hui Zhu Date: Thu, 17 Feb 2011 09:54:00 -0000 Message-ID: Subject: Re: [PATCH] tracepoint: add new trace command "printf"[1] gdbserver To: Tom Tromey Cc: gdb-patches Content-Type: multipart/mixed; boundary=000e0cd480340c57df049c76050f X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00415.txt.bz2 --000e0cd480340c57df049c76050f Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 936 On Sat, Feb 12, 2011 at 05:31, Tom Tromey wrote: >>>>>> ">" =3D=3D Hui Zhu writes: > >>> To make the gdbserver support %s. > > Oops, I missed this when reviewing your earlier patch. > Sorry about that. > >>> +int >>> +tp_printf(const char *format, ...) > > Space before open paren. > >>> + =A0va_end(ap); > > Likewise. > >>> + =A0 =A0 =A0 =A0argv =3D (void *)(unsigned long)top; > > Spacing. > > There are several more spacing bugs, please fix them all. > > I didn't go read the other patch to try to deduce the format of the > printf opcode to see if it all makes sense. =A0Documentation would help. > > Tom > Hi Tom, I make a new patch according to your comments. Thanks, Hui 2011-02-17 Hui Zhu * tracepoint.c (gdb_agent_op): Add gdb_agent_op_printf. (gdb_agent_op_names): Add "printf". (tp_printf): New function. (eval_agent_expr): Handle gdb_agent_op_printf. --000e0cd480340c57df049c76050f Content-Type: text/plain; charset=US-ASCII; name="tp_print_server.txt" Content-Disposition: attachment; filename="tp_print_server.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gk9ecqsz0 Content-length: 2554 LS0tCiBnZGJzZXJ2ZXIvdHJhY2Vwb2ludC5jIHwgICA0NiArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUg Y2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKQoKLS0tIGEvZ2Ric2VydmVyL3Ry YWNlcG9pbnQuYworKysgYi9nZGJzZXJ2ZXIvdHJhY2Vwb2ludC5jCkBAIC01 MTcsNiArNTE3LDcgQEAgZW51bSBnZGJfYWdlbnRfb3AKICAgICBnZGJfYWdl bnRfb3Bfc2V0diA9IDB4MmQsCiAgICAgZ2RiX2FnZW50X29wX3RyYWNldiA9 IDB4MmUsCiAgICAgZ2RiX2FnZW50X29wX3RyYWNlMTYgPSAweDMwLAorICAg IGdkYl9hZ2VudF9vcF9wcmludGYgPSAweDMxLAogICAgIGdkYl9hZ2VudF9v cF9sYXN0CiAgIH07CiAKQEAgLTU3MSw2ICs1NzIsNyBAQCBzdGF0aWMgY29u c3QgY2hhciAqZ2RiX2FnZW50X29wX25hbWVzIFtnCiAgICAgInRyYWNldiIs CiAgICAgIj91bmRlZj8iLAogICAgICJ0cmFjZTE2IiwKKyAgICAicHJpbnRm IiwKICAgfTsKIAogc3RydWN0IGFnZW50X2V4cHIKQEAgLTQyOTIsNiArNDI5 NCwxNiBAQCB1bnBhcnNlX2FnZW50X2V4cHIgKHN0cnVjdCBhZ2VudF9leHBy ICphCiAKICNlbmRpZgogCitpbnQKK3RwX3ByaW50ZiAoY29uc3QgY2hhciAq Zm9ybWF0LCAuLi4pCit7CisgIHZhX2xpc3QgYXA7CisgIHZhX3N0YXJ0IChh cCwgZm9ybWF0KTsKKyAgdnByaW50ZiAoZm9ybWF0LCBhcCk7CisgIHZhX2Vu ZCAoYXApOworICByZXR1cm4gMDsKK30KKwogLyogVGhlIGFnZW50IGV4cHJl c3Npb24gZXZhbHVhdG9yLCBhcyBzcGVjaWZpZWQgYnkgdGhlIEdEQiBkb2Nz LiBJdAogICAgcmV0dXJucyAwIGlmIGV2ZXJ5dGhpbmcgd2VudCBPSywgYW5k IGEgbm9uemVybyBlcnJvciBjb2RlCiAgICBvdGhlcndpc2UuICAqLwpAQCAt NDYzNCw2ICs0NjQ2LDQwIEBAIGV2YWxfYWdlbnRfZXhwciAoc3RydWN0IHRy YWNlcG9pbnRfaGl0X2MKIAkgIGFnZW50X3Rzdl9yZWFkICh0ZnJhbWUsIGFy Zyk7CiAJICBicmVhazsKIAorCWNhc2UgZ2RiX2FnZW50X29wX3ByaW50ZjoK KwkgIHsKKwkgICAgdm9pZCAqYXJndjsKKwkgICAgYXJnID0gYWV4cHItPmJ5 dGVzW3BjKytdOworCSAgICBhcmd2ID0gKHZvaWQgKikgKHVuc2lnbmVkIGxv bmcpIHRvcDsKKwkgICAgaWYgKC0tc3AgPj0gMCkKKwkgICAgICB0b3AgPSBz dGFja1tzcF07CisKKwkgICAgaWYgKGFyZykKKwkgICAgICB7CisJCWlmIChz dHJzdHIgKChjaGFyICopIChhZXhwci0+Ynl0ZXMgKyBwYyksICIlcyIpKQor CQkgIHsKKwkJICAgIGludAkJCWk7CisJCSAgICB1bnNpZ25lZCBjaGFyCWJ1 ZlsxMDBdOworCisJCSAgICBmb3IgKGkgPSAwOyBpIDwgMTAwOyBpKyspCisJ CSAgICAgIHsKKwkJCWFnZW50X21lbV9yZWFkICh0ZnJhbWUsIGJ1ZiArIGks CisJCQkJCShDT1JFX0FERFIpICgodW5zaWduZWQgbG9uZylhcmd2ICsgaSks CisJCQkJCTEpOworCQkJaWYgKCFidWZbaV0pCisJCQkgIGJyZWFrOworCQkg ICAgICB9CisJCSAgICB0cF9wcmludGYgKChjaGFyICopIChhZXhwci0+Ynl0 ZXMgKyBwYyksIGJ1Zik7CisJCSAgfQorCQllbHNlCisJICAgICAgICAgIHRw X3ByaW50ZiAoKGNoYXIgKikgKGFleHByLT5ieXRlcyArIHBjKSwgYXJndik7 CisJICAgICAgfQorCSAgICBlbHNlCisJICAgICAgdHBfcHJpbnRmICgoY2hh ciAqKSAoYWV4cHItPmJ5dGVzICsgcGMpKTsKKwkgICAgcGMgKz0gc3RybGVu ICgoY2hhciAqKSBhZXhwci0+Ynl0ZXMgKyBwYykgKyAxOworCSAgfQorCSAg YnJlYWs7CisKIAkgIC8qIEdEQiBuZXZlciAoY3VycmVudGx5KSBnZW5lcmF0 ZXMgYW55IG9mIHRoZXNlIG9wcy4gICovCiAJY2FzZSBnZGJfYWdlbnRfb3Bf ZmxvYXQ6CiAJY2FzZSBnZGJfYWdlbnRfb3BfcmVmX2Zsb2F0Ogo= --000e0cd480340c57df049c76050f--