Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ozkan Sezer <sezeroz@gmail.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: gdbserver with -Werror, win64 socket type
Date: Fri, 27 Aug 2010 16:12:00 -0000	[thread overview]
Message-ID: <AANLkTi=Rsz7vuUthHyrc2geB1vRDkRGFFA=u-+1s1hFA@mail.gmail.com> (raw)
In-Reply-To: <201008271706.35298.pedro@codesourcery.com>

On Fri, Aug 27, 2010 at 7:06 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Friday 27 August 2010 16:46:02, Ozkan Sezer wrote:
>> On Fri, Aug 27, 2010 at 6:34 PM, Pedro Alves <pedro@codesourcery.com> wrote:
>> > Note the "s/gdb/gdbserver".
>>
>> Speaking only for gdbserver, OK.
>
> Yeah, that's usual sed-like-speak for,
> "if you substitute gdb for gdbserver in your statement above, ...".
> Sorry for not being clear.
>
>>
>> In file included from version.c:1:
>> ../../../gdb-cvs/gdb/gdbserver/server.h:338: error: expected '=', ',',
>> ';', 'asm' or '__attribute__' before 'gdb_fildes_t'
>> ../../../gdb-cvs/gdb/gdbserver/server.h:348: error: expected ')' before 'fd'
>> ../../../gdb-cvs/gdb/gdbserver/server.h:349: error: expected ')' before 'fd'
>> ../../../gdb-cvs/gdb/gdbserver/server.h:482: error: expected ')' before 'fd'
>>
>> This can be fixed by inserting an #include <winsock2.h> before the
>> gdb_fildes_t typedefinition in server.h.  After doing this, the build reaches
>> completion without errors.
>
> Thanks, I guess we can live with that.  I've done that change, and applied
> the patch, as below.
>

Thank you very much.

>> Of you want, I can send my full build logs,
>
> No need.  Let me know if something is still not right.
>

Things seem OK for now.  Someday, gdb itself will need proper
adjustments for SOCKET type, but that's for another time.  Thanks again.

> --
> Pedro Alves
>

--
Ozkan


      reply	other threads:[~2010-08-27 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-27 13:56 Ozkan Sezer
2010-08-27 14:45 ` Pedro Alves
2010-08-27 15:09   ` Ozkan Sezer
2010-08-27 15:34     ` Pedro Alves
2010-08-27 15:46       ` Ozkan Sezer
2010-08-27 16:06         ` Pedro Alves
2010-08-27 16:12           ` Ozkan Sezer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=Rsz7vuUthHyrc2geB1vRDkRGFFA=u-+1s1hFA@mail.gmail.com' \
    --to=sezeroz@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox