Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] New python module gdb.types
Date: Fri, 08 Oct 2010 22:19:00 -0000	[thread overview]
Message-ID: <AANLkTi=P7-+0grj3jhjDVaeHDQwey6JpkS+GZDQwP9w-@mail.gmail.com> (raw)
In-Reply-To: <83vd5fnicu.fsf@gnu.org>

On Wed, Oct 6, 2010 at 2:04 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> +@item get_basic_type (@var{type})
>> +Return @var{type} with const and volatile qualifiers, typedefs,
>> +and references stripped away.
>
> This is quite cryptic.  I can understand what it means to remove
> const, volatile, etc. qualifiers (what about `static', btw?), but what
> does it mean to "strip" a typedef or a reference?  At the very least
> please give a few examples, if this cannot be explained easily.

static isn't an attribute of a type.

What if it said the following instead?

Return @var{type} with const and volatile qualifiers stripped,
and with typedefs and references converted to the underlying type.

>> +@item make_enum_dict (@var{enum_type})
>> +Return a dictionary made from @var{enum_type}.
>
> Same here: at the very least we should say what is a "dictionary" in
> this context.

The context is python and in the python context "dictionary" is quite
specific, it's a builtin type.

What if it said the following instead?

Return a python dictionary made from @var{enum_type}.


  reply	other threads:[~2010-10-08 22:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-06 20:49 Doug Evans
2010-10-06 21:04 ` Eli Zaretskii
2010-10-08 22:19   ` Doug Evans [this message]
2010-10-08 22:21     ` Doug Evans
2010-10-09  9:14     ` Eli Zaretskii
2010-10-13 18:42       ` Doug Evans
2010-10-13 18:49         ` Eli Zaretskii
2010-10-06 21:12 ` Joel Brobecker
2010-10-06 22:12 ` Tom Tromey
2010-10-06 23:44   ` Doug Evans
2010-10-08 23:08 ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=P7-+0grj3jhjDVaeHDQwey6JpkS+GZDQwP9w-@mail.gmail.com' \
    --to=dje@google.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox