From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25294 invoked by alias); 18 Feb 2011 11:34:49 -0000 Received: (qmail 25074 invoked by uid 22791); 18 Feb 2011 11:34:48 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 11:34:43 +0000 Received: by qwd7 with SMTP id 7so264733qwd.0 for ; Fri, 18 Feb 2011 03:34:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.229.83 with SMTP id jh19mr426510qcb.234.1298028882078; Fri, 18 Feb 2011 03:34:42 -0800 (PST) Received: by 10.229.31.198 with HTTP; Fri, 18 Feb 2011 03:34:41 -0800 (PST) In-Reply-To: <83vd0hvdls.fsf@gnu.org> References: <83vd0hvdls.fsf@gnu.org> Date: Fri, 18 Feb 2011 11:48:00 -0000 Message-ID: Subject: Re: [patch] delete a range of display numbers From: Guillaume Leconte To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=00163630fa2b6caad7049c8ce659 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00453.txt.bz2 --00163630fa2b6caad7049c8ce659 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 935 Thank you for this suggestion. I added the modification you asked for in the attached file. Guillaume. On Fri, Feb 18, 2011 at 11:30 AM, Eli Zaretskii wrote: >> Date: Fri, 18 Feb 2011 10:36:18 +0100 >> From: Guillaume Leconte >> >> Notice that I've change the prototype of delete_display() in order >> to have a silent return in case of unknown number. =A0If you have set >> the display numbers 1, 2, 3 and 5, you can remove 2-5 without any >> error messages (number 4 is missing in the list). =A0As a consequence, >> you can also remove out of bound numbers, as in 'delete display 5-42' >> without having gdb complaining. > > I think it's a convenient feature, but doing this silently may not be > a good idea. =A0How about displaying a note about this? =A0Something like > > =A0(Ignored some display numbers.) > > WDYT? > --=20 "A fellow of infinite jest, of most excellent fancy." --00163630fa2b6caad7049c8ce659 Content-Type: text/x-patch; charset=US-ASCII; name="delete-display-range.patch" Content-Disposition: attachment; filename="delete-display-range.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gkb0u5uc1 Content-length: 4718 ZGlmZiAtLWdpdCBhL2dkYi9wcmludGNtZC5jIGIvZ2RiL3ByaW50Y21kLmMK aW5kZXggMjlmZmJmNS4uOGFiMWE1NCAxMDA2NDQKLS0tIGEvZ2RiL3ByaW50 Y21kLmMKKysrIGIvZ2RiL3ByaW50Y21kLmMKQEAgLTE1NTcsMTMgKzE1NTcs MTggQEAgY2xlYXJfZGlzcGxheXMgKHZvaWQpCiAKIC8qIERlbGV0ZSB0aGUg YXV0by1kaXNwbGF5IG51bWJlciBOVU0uICAqLwogCi1zdGF0aWMgdm9pZAot ZGVsZXRlX2Rpc3BsYXkgKGludCBudW0pCitzdGF0aWMgaW50CitkZWxldGVf ZGlzcGxheSAoaW50IG51bSwgaW50IGlnbm9yZSkKIHsKICAgc3RydWN0IGRp c3BsYXkgKmQxLCAqZDsKIAogICBpZiAoIWRpc3BsYXlfY2hhaW4pCi0gICAg ZXJyb3IgKF8oIk5vIGRpc3BsYXkgbnVtYmVyICVkLiIpLCBudW0pOworICAg IHsKKyAgICAgIGlmIChpZ25vcmUpCisgICAgICAgIHJldHVybiAxOworICAg ICAgcHJpbnRmX2ZpbHRlcmVkIChfKCJObyBkaXNwbGF5IG51bWJlciAlZC5c biIpLCBudW0pOworICAgICAgcmV0dXJuIC0xOworICAgIH0KIAogICBpZiAo ZGlzcGxheV9jaGFpbi0+bnVtYmVyID09IG51bSkKICAgICB7CkBAIC0xNTc1 LDcgKzE1ODAsMTIgQEAgZGVsZXRlX2Rpc3BsYXkgKGludCBudW0pCiAgICAg Zm9yIChkID0gZGlzcGxheV9jaGFpbjs7IGQgPSBkLT5uZXh0KQogICAgICAg ewogCWlmIChkLT5uZXh0ID09IDApCi0JICBlcnJvciAoXygiTm8gZGlzcGxh eSBudW1iZXIgJWQuIiksIG51bSk7CisgICAgICAgICAgeworICAgICAgICAg ICAgaWYgKGlnbm9yZSkKKyAgICAgICAgICAgICAgICByZXR1cm4gMTsKKyAg ICAgICAgICAgIHByaW50Zl9maWx0ZXJlZCAoXygiTm8gZGlzcGxheSBudW1i ZXIgJWQuXG4iKSwgbnVtKTsKKyAgICAgICAgICAgIHJldHVybiAtMTsKKyAg ICAgICAgICB9CiAJaWYgKGQtPm5leHQtPm51bWJlciA9PSBudW0pCiAJICB7 CiAJICAgIGQxID0gZC0+bmV4dDsKQEAgLTE1ODQsNiArMTU5NCw0MiBAQCBk ZWxldGVfZGlzcGxheSAoaW50IG51bSkKIAkgICAgYnJlYWs7CiAJICB9CiAg ICAgICB9CisKKyAgcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQKK3NldF9p bnRfZnJvbV9zdHIoY2hhciAqc3RyLCBpbnQgKnJlc3VsdCwgY2hhciAqZW5k X2RlbGltKQoreworICBjaGFyICpwOworICBpbnQgcmV0OworICBjaGFyICpv Y2N1cnJlbmNlOworCisgIHAgPSBzdHI7CisgIHJldCA9IC0xOworCisgIGlm ICghIHN0cikKKyAgICBnb3RvIGVycjsKKworICB3aGlsZSAocCAmJiAqcCAm JiAoJyAnID09ICpwIHx8ICdcdCcgPT0gKnApKQorICAgIHArKzsKKworICB3 aGlsZSAocCAmJiAqcCAmJiAqcCA+PSAnMCcgJiYgKnAgPD0gJzknKQorICAg IHArKzsKKworICBpZiAocCAmJiAqcCkKKyAgICB7CisgICAgICBvY2N1cnJl bmNlID0gc3RycGJyayhwLCBlbmRfZGVsaW0pOworICAgICAgaWYgKCEgb2Nj dXJyZW5jZSB8fCBvY2N1cnJlbmNlICE9IHApCisgICAgICAgIGdvdG8gZXJy OworICAgIH0KKworICBpZiAocmVzdWx0KQorICAgICpyZXN1bHQgPSBhdG9p KHN0cik7CisKKyAgcmV0ID0gMDsKKyBlcnI6CisgIHJldHVybiByZXQ7CiB9 CiAKIC8qIERlbGV0ZSBzb21lIHZhbHVlcyBmcm9tIHRoZSBhdXRvLWRpc3Bs YXkgY2hhaW4uCkBAIC0xNTk1LDYgKzE2NDEsOSBAQCB1bmRpc3BsYXlfY29t bWFuZCAoY2hhciAqYXJncywgaW50IGZyb21fdHR5KQogICBjaGFyICpwID0g YXJnczsKICAgY2hhciAqcDE7CiAgIGludCBudW07CisgIGludCBsb3dlciwg dXBwZXIsIGk7CisgIGNoYXIgKmRhc2g7CisgIGludCBlcnI7CiAKICAgaWYg KGFyZ3MgPT0gMCkKICAgICB7CkBAIC0xNjA0LDIzICsxNjUzLDUyIEBAIHVu ZGlzcGxheV9jb21tYW5kIChjaGFyICphcmdzLCBpbnQgZnJvbV90dHkpCiAg ICAgICByZXR1cm47CiAgICAgfQogCi0gIHdoaWxlICgqcCkKKyAgZGFzaCA9 IHN0cmNocihwLCAnLScpOworICBpZiAoZGFzaCkgLyogcmVtb3ZlIGFsbCB0 aGUgZGlzcGxheSBJRHMgd2l0aGluIGEgcmFuZ2UgKi8KKyAgICB7CisgICAg ICBlcnIgPSAwOworCisgICAgICBpZiAoLTEgPT0gc2V0X2ludF9mcm9tX3N0 cihwLCAmbG93ZXIsICItIFx0IikpCisgICAgICAgIGVycm9yIChfKCJBcmd1 bWVudHMgbXVzdCBiZSBkaXNwbGF5IG51bWJlcnMuIikpOworCisgICAgICBw ID0gZGFzaCsxOworICAgICAgd2hpbGUgKHAgJiYgKnAgJiYgKCcgJyA9PSAq cCB8fCAnXHQnID09ICpwKSkKKyAgICAgICAgcCsrOworCisgICAgICBpZiAo LTEgPT0gc2V0X2ludF9mcm9tX3N0cihwLCAmdXBwZXIsICIgXHQiKSkKKyAg ICAgICAgZXJyb3IgKF8oIkFyZ3VtZW50cyBtdXN0IGJlIGRpc3BsYXkgbnVt YmVycy4iKSk7CisKKyAgICAgIGZvciAoaSA9IGxvd2VyOyBpIDw9IHVwcGVy OyBpKyspCisgICAgICAgIGVyciArPSBkZWxldGVfZGlzcGxheSAoaSwgMSk7 CisKKyAgICAgIC8qIHNpbmNlIHdlIGNhbGxlZCBkZWxldGVfZGlzcGxheSB3 aXRoIDEgYXMgdGhlIHNlY29uZCBhcmd1bWVudCwKKyAgICAgICAgIHdlIGtu b3cgdGhhdCBlcnIgaXMgMCBvciA+IDAuICBJdCBjYW4gbm90IGJlIG5lZ2F0 aXZlLiAqLworICAgICAgaWYgKGVycikKKyAgICAgICAgcHJpbnRmX2ZpbHRl cmVkIChfKCIoSWdub3JlZCBzb21lIGRpc3BsYXkgbnVtYmVycylcbiIpKTsK KworICAgICAgZG9udF9yZXBlYXQgKCk7CisgICAgfQorICBlbHNlCiAgICAg ewotICAgICAgcDEgPSBwOwotICAgICAgd2hpbGUgKCpwMSA+PSAnMCcgJiYg KnAxIDw9ICc5JykKLQlwMSsrOwotICAgICAgaWYgKCpwMSAmJiAqcDEgIT0g JyAnICYmICpwMSAhPSAnXHQnKQotCWVycm9yIChfKCJBcmd1bWVudHMgbXVz dCBiZSBkaXNwbGF5IG51bWJlcnMuIikpOworICAgICAgd2hpbGUgKCpwKQor ICAgICAgICB7CisgICAgICAgICAgcDEgPSBwOworICAgICAgICAgIHdoaWxl ICgqcDEgPj0gJzAnICYmICpwMSA8PSAnOScpCisgICAgICAgICAgICBwMSsr OworICAgICAgICAgIGlmICgqcDEgJiYgKnAxICE9ICcgJyAmJiAqcDEgIT0g J1x0JykKKyAgICAgICAgICAgIGVycm9yIChfKCJBcmd1bWVudHMgbXVzdCBi ZSBkaXNwbGF5IG51bWJlcnMuIikpOwogCi0gICAgICBudW0gPSBhdG9pIChw KTsKKyAgICAgICAgICBudW0gPSBhdG9pIChwKTsKIAotICAgICAgZGVsZXRl X2Rpc3BsYXkgKG51bSk7CisgICAgICAgICAgaWYgKC0xID09IGRlbGV0ZV9k aXNwbGF5IChudW0sIDApKQorICAgICAgICAgICAgcmV0dXJuOwogCi0gICAg ICBwID0gcDE7Ci0gICAgICB3aGlsZSAoKnAgPT0gJyAnIHx8ICpwID09ICdc dCcpCi0JcCsrOworICAgICAgICAgIHAgPSBwMTsKKyAgICAgICAgICB3aGls ZSAoKnAgPT0gJyAnIHx8ICpwID09ICdcdCcpCisgICAgICAgICAgICBwKys7 CisgICAgICAgIH0KKyAgICAgIGRvbnRfcmVwZWF0ICgpOwogICAgIH0KLSAg ZG9udF9yZXBlYXQgKCk7CiB9CiAKIC8qIERpc3BsYXkgYSBzaW5nbGUgYXV0 by1kaXNwbGF5LiAgCg== --00163630fa2b6caad7049c8ce659--