Re: [PATCH] tracepoint: add new trace command "printf"[0] gdb

Hui Zhu
2011-02-11T03:49:49Z

Hi all,

I sent the first version patch has been more than a month. And I have
done with the support in the KGTP for the support.

But I am still not get a code review or something. Are you reviewing
or have plan to review this patch?

Thanks,
Hui

On Fri, Feb 4, 2011 at 23:59, Hui Zhu <teawater@gmail.com> wrote:
> The prev version cannot support %s.  So make a new version to support it.
>
> And I think current way to handle printf is too much hack way.  Maybe
> I need find out a more better way to handle the printf.
>
> Thanks,
> Hui
>
> 2011-02-04  Hui Zhu  <teawater@gmail.com>
>
>        * ax-gdb.c (gen_printf_expr_callback): New function.
>        * ax-general.c (ax_memcpy): New function.
>        (aop_map): Add new entry for "printf".
>        (ax_print): Handle "printf".
>        (ax_reqs): Ditto.
>        * ax.h (agent_op): Add aop_printf.
>        (ax_memcpy): Forward declare.
>        * printcmd.c (printf_callback): New typedef.
>        (string_printf): New function from ui_printf.
>        (ui_printf): Call string_printf.
>        (printf_command): Remove static.
>        * tracepoint.c (printf_command, gen_printf_expr_callback,
>        printf_callback, string_printf): Forward declares.
>        (validate_actionline, encode_actions_1): handle printf_command.
>