From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 530 invoked by alias); 3 Mar 2011 13:48:16 -0000 Received: (qmail 508 invoked by uid 22791); 3 Mar 2011 13:48:15 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qy0-f169.google.com (HELO mail-qy0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 13:48:09 +0000 Received: by qyk2 with SMTP id 2so5392613qyk.0 for ; Thu, 03 Mar 2011 05:48:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.140.193 with SMTP id j1mr941534qcu.82.1299160087462; Thu, 03 Mar 2011 05:48:07 -0800 (PST) Received: by 10.229.89.197 with HTTP; Thu, 3 Mar 2011 05:48:07 -0800 (PST) In-Reply-To: References: Date: Thu, 03 Mar 2011 13:48:00 -0000 Message-ID: Subject: Re: [patch gdb]: Fix some DOS-path related issues in gdb From: Kai Tietz To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00170.txt.bz2 2011/3/3 Eli Zaretskii : >> Date: Thu, 3 Mar 2011 13:10:13 +0100 >> From: Kai Tietz >> >> Sorry, first post were sent to wrong list. This patch fixes some >> issues related to DOS file-system filenames and paths. I am not sure, >> if I hit all places, nevertheless I am sure I hit most. >> This patch uses the libiberty functions & macros about >> directory-separator checks, absolute-path checks, and the >> filename-comparision functions. > > The patch looks okay to me, but please do NOT install the changes for > the following files, which cannot possibly meet with this issue: > bsd-kvm.c, elfread.c, mdebugread.c, nto-procfs.c, rs6000-nat.c, > xcoffread.c, fbsd-nat.c, linux-fork.c linux-nat.c, linux-thread-db, > nto-tdep.c. > > Thanks for working on this. > Ok, the obvious native-parts - not using DOS-style file/paths - I removed. The files elfread.c, mdebugread.c are also used for a x64 windows target, so I think those parts of patch should be kept. They don't seem to be host-specific to me. Regards, Kai