"the" it is then. -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From tom@tromey.com Tue Aug 4 18:25:28 2020 Return-Path: X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.149.101]) by sourceware.org (Postfix) with ESMTPS id 08D6E3857009 for ; Tue, 4 Aug 2020 18:25:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 08D6E3857009 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spfúil smtp.mailfrom=tom@tromey.com Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway34.websitewelcome.com (Postfix) with ESMTP id A5BFF83BA07 for ; Tue, 4 Aug 2020 13:24:40 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 31c8ksw0CdbRz31c8kw1yi; Tue, 04 Aug 2020 13:24:40 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; sÞfault; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JD/ZP0FW5EuY9TAS59M+EjW7yaA70aV9JwbX+p+pW1k=; b=QZpp5gYxTV7GcaojaNlVblkHhN 08GhcaNO0fBewS3psftssOnwETXiQNT24W9/LapsbwZGZCvgVEpY50v1gJQfjufmYHfcBwUJxuo1e 8OFTXD2By7Bd7Y9MFUkPUybHe; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:60092 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1k31c8-000E5a-85; Tue, 04 Aug 2020 12:24:40 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 1/2] gdb: change frame_info::prev_func::p type to cached_copy_status References: <20200803191510.16781-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 04 Aug 2020 12:24:38 -0600 In-Reply-To: <20200803191510.16781-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Mon, 3 Aug 2020 15:15:09 -0400") Message-ID: <87d046tgk9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1k31c8-000E5a-85 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:60092 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20X-Local-Domain: yes X-Spam-Status: No, score=-3027.3 required=5.0 testsºYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2020 18:25:28 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> * frame.c (frame_info)

: Rename to status, change Simon> type to cached_copy_status. Simon> (fprintf_frame): Adjust. Simon> (get_frame_func_if_available): Adjust. Simon> (frame_cleanup_after_sniffer): Adjust. Thanks. This and patch #2 both seem fine to me. Tom