From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106750 invoked by alias); 28 Sep 2018 07:07:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106739 invoked by uid 89); 28 Sep 2018 07:07:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*tom, Tel, tel, office X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Sep 2018 07:07:18 +0000 Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2018 00:07:16 -0700 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga007.fm.intel.com with ESMTP; 28 Sep 2018 00:06:24 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.213]) by IRSMSX103.ger.corp.intel.com ([169.254.3.248]) with mapi id 14.03.0319.002; Fri, 28 Sep 2018 08:06:23 +0100 From: "Metzger, Markus T" To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH] testsuite: fix is_amd64_regs_target Date: Fri, 28 Sep 2018 07:07:00 -0000 Message-ID: References: <1538034149-12136-1-git-send-email-markus.t.metzger@intel.com> <1538034149-12136-2-git-send-email-markus.t.metzger@intel.com> <8736tuodf9.fsf@tromey.com> In-Reply-To: <8736tuodf9.fsf@tromey.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00888.txt.bz2 Hello Tom, Thanks for your review. > Markus> - set list {} > Markus> - foreach reg \ > Markus> - {rax rbx rcx rdx rsi rdi rbp rsp r8 r9 r10 r11 r12 r13 r14 r15}= { > Markus> - lappend list "\tincq %$reg" > Markus> - } > Markus> + return [gdb_can_simple_compile is_amd64_regs_target { > Markus> + int main (void) { > Markus> + asm ("incq %rax"); > Markus> + asm ("incq %r15"); >=20 > I suppose reducing the number of registers tested doesn't materially affe= ct the > test. That's my assumption, as well. We already checked the architecture so we k= now it is some x86 flavor. A single 64-bit register should suffice. The gdb.btrace suite passes on 32-bit and 64-bit including m32. I have not= run the full suite since the problem was already seen on the gdb.btrace suite. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928