From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90248 invoked by alias); 9 Apr 2018 16:24:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90167 invoked by uid 89); 9 Apr 2018 16:24:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 16:24:35 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 09:24:26 -0700 X-ExtLoop1: 1 Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga004.jf.intel.com with ESMTP; 09 Apr 2018 09:24:25 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.61]) by IRSMSX108.ger.corp.intel.com ([169.254.11.155]) with mapi id 14.03.0319.002; Mon, 9 Apr 2018 17:24:24 +0100 From: "Metzger, Markus T" To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [PATCH] infrun: step through indirect branch thunks Date: Mon, 09 Apr 2018 16:24:00 -0000 Message-ID: References: <1519017382-24335-1-git-send-email-markus.t.metzger@intel.com> <4dfab882-016f-01b5-bb28-67cd6637acea@redhat.com> In-Reply-To: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTJmODc2MzQtNjUwNS00YmRjLWI3OWQtMTUwYTI5YmMxN2Y3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJQam1vSEM1d0YwODM1XC8yWHl1WW9UM0tcL01jVmNXNmpIcFNOTGt0SXMxT1RcL1lVUW1qSlQ0MEVMMDY2TUNQS3U3In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00151.txt.bz2 SGVsbG8gUGVkcm8sDQoNCj4gPiAtLS0gYS9nZGIvZ2RiYXJjaC5zaA0KPiA+ ICsrKyBiL2dkYi9nZGJhcmNoLnNoDQo+ID4gQEAgLTY2MCw2ICs2NjAsOSBA QCBtO0NPUkVfQUREUjtza2lwX3NvbGliX3Jlc29sdmVyO0NPUkVfQUREUg0K PiA+IHBjO3BjOztnZW5lcmljX3NraXBfc29saWJfcmVzb2x2ZXI7OzANCj4g PiAgIyBTb21lIHN5c3RlbXMgYWxzbyBoYXZlIHRyYW1wb2xpbmUgY29kZSBm b3IgcmV0dXJuaW5nIGZyb20gc2hhcmVkIGxpYnMuDQo+ID4gIG07aW50O2lu X3NvbGliX3JldHVybl90cmFtcG9saW5lO0NPUkVfQUREUiBwYywgY29uc3Qg Y2hhciAqbmFtZTtwYywNCj4gPiBuYW1lOztnZW5lcmljX2luX3NvbGliX3Jl dHVybl90cmFtcG9saW5lOzswDQo+ID4NCj4gPiArIyBSZXR1cm4gdHJ1ZSBp ZiBQQyBsaWVzIGluc2lkZSBhbiBpbmRpcmVjdCBicmFuY2ggdGh1bmsuDQo+ ID4gK207Ym9vbDtpbl9pbmRpcmVjdF9icmFuY2hfdGh1bms7Q09SRV9BRERS DQo+ID4gK3BjO3BjOztkZWZhdWx0X2luX2luZGlyZWN0X2JyYW5jaF90aHVu azs7MA0KPiANCj4gSWYgdGhhdCBsYXN0IDAgaXMgdGhlIGRlZmF1bHQgKEkg bmV2ZXIgcmVtZW1iZXIgb2ZmIGhhbmQpLCB0aGVuIHBsZWFzZSB3cml0ZSAi ZmFsc2UiDQo+IGluc3RlYWQuICBBc3N1bWluZyB0aGF0IHdvcmtzLg0KDQpJ dCBpcyBub3QgdGhlIGRlZmF1bHQuICBJIGhhZCB0byBhZGQgYSBuZXcgZnVu Y3Rpb24gdG8gcmV0dXJuIHRoZSBkZWZhdWx0LiAgSUlVQyB0aGlzDQppcyBk aXNhYmxpbmcgSU5WQUxJRF9QIGNoZWNrcyB0byBhbGxvdyBkZWZhdWx0X2lu X2luZGlyZWN0X2JyYW5jaF90aHVuayB0byBiZQ0KdXNlZCBhcyBkZWZhdWx0 Lg0KDQoNCj4gPiArICAgIGdkYl90ZXN0X211bHRpcGxlICJzdGVwaSIgIiR0 ZXN0OiBzdGVwaSIgew0KPiA+ICsgICAgICAgIC1yZSAiJGN1cnJlbnQuKiRn ZGJfcHJvbXB0ICQiIHsNCj4gPiArICAgICAgICAgICAgc2VuZF9nZGIgInN0 ZXBpXG4iDQo+ID4gKyAgICAgICAgICAgIGV4cF9jb250aW51ZQ0KPiANCj4g VGhpcyBzaG91bGQgcHJvYmFibHkgaGF2ZSBzb21lIHVwcGVyIGJvdW5kLg0K DQpVbmxlc3Mgc29tZSBjb21waWxlciBidWcgZ2VuZXJhdGVkIGFuIGluZmlu aXRlIGxvb3Agb3IgR0RCJ3Mgc3RlcHBpbmcgaXMNCmNvbXBsZXRlbHkgYnJv a2VuLCB3ZSBzaG91bGQgZXZlbnR1YWxseSBzdGVwIG91dCBvZiAkY3VycmVu dC4NCg0KSSByZWFkIHlvdXIgY29tbWVudCBhYm91dCBhbiB1cHBlciBib3Vu ZCBpbiB5b3VyIGZpcnN0IHJlcGx5IGJ1dCB0aG91Z2h0DQp0aGF0IGl0IHdv dWxkbid0IGJlIG5lY2Vzc2FyeS4gIERvIHlvdSB0aGluayB3ZSBuZWVkIG9u ZT8NCg0KVGhhbmtzLA0KTWFya3VzLg0KDQpJbnRlbCBEZXV0c2NobGFuZCBH bWJIClJlZ2lzdGVyZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1 NzkgTmV1YmliZXJnLCBHZXJtYW55ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwg d3d3LmludGVsLmRlCk1hbmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlz ZW5zY2htaWQsIENocmlzdGlhbiBMYW1wcmVjaHRlcgpDaGFpcnBlcnNvbiBv ZiB0aGUgU3VwZXJ2aXNvcnkgQm9hcmQ6IE5pY29sZSBMYXUKUmVnaXN0ZXJl ZCBPZmZpY2U6IE11bmljaApDb21tZXJjaWFsIFJlZ2lzdGVyOiBBbXRzZ2Vy aWNodCBNdWVuY2hlbiBIUkIgMTg2OTI4Cg== >From gdb-patches-return-146460-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Apr 09 16:29:48 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 94777 invoked by alias); 9 Apr 2018 16:29:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 94754 invoked by uid 89); 9 Apr 2018 16:29:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 16:29:44 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06AFC406E96B; Mon, 9 Apr 2018 16:29:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73F0A2166BAE; Mon, 9 Apr 2018 16:29:42 +0000 (UTC) Subject: Re: [PATCH] infrun: step through indirect branch thunks To: "Metzger, Markus T" , "gdb-patches@sourceware.org" References: <1519017382-24335-1-git-send-email-markus.t.metzger@intel.com> <4dfab882-016f-01b5-bb28-67cd6637acea@redhat.com> From: Pedro Alves Message-ID: <0a6901c7-e26e-0c35-12d0-60f1da08a1aa@redhat.com> Date: Mon, 09 Apr 2018 16:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00152.txt.bz2 Content-length: 1044 On 04/09/2018 05:24 PM, Metzger, Markus T wrote: > It is not the default. I had to add a new function to return the default. IIUC this > is disabling INVALID_P checks to allow default_in_indirect_branch_thunk to be > used as default. Ah, yeah. > > >>> + gdb_test_multiple "stepi" "$test: stepi" { >>> + -re "$current.*$gdb_prompt $" { >>> + send_gdb "stepi\n" >>> + exp_continue >> >> This should probably have some upper bound. > > Unless some compiler bug generated an infinite loop or GDB's stepping is > completely broken, we should eventually step out of $current. If nothing would ever break, we wouldn't need regression tests. :-) Keep developers doing local changes and breaking things routinely in mind as well. > I read your comment about an upper bound in your first reply but thought > that it wouldn't be necessary. Do you think we need one? I do, because if for some reason the end up in the infinite loop, the testcase will never timeout, hanging the test run. Thanks, Pedro Alves