RE: [PATCH 1/3] btrace: Remove btrace disable cleanup

Metzger, Markus T
2018-03-05T12:39:21Z

Hello Simon,

> This patch removes a cleanup that disables btrace on threads in case of
> failure, so we don't leave it enabled for some the threads and disabled
> for the rest.
>
> gdb/ChangeLog:
>
> * record-btrace.c (record_btrace_disable_callback): Remove.
> (struct scoped_btrace_disable): New.
> (record_btrace_open): Use scoped_btrace_disable.

Looks good to me.

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928