From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33061 invoked by alias); 5 Mar 2018 12:39:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32957 invoked by uid 89); 5 Mar 2018 12:39:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Tel, tel, commercial, office X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Mar 2018 12:39:21 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2018 04:39:20 -0800 X-ExtLoop1: 1 Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga008.fm.intel.com with ESMTP; 05 Mar 2018 04:39:19 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by irsmsx110.ger.corp.intel.com ([169.254.15.15]) with mapi id 14.03.0319.002; Mon, 5 Mar 2018 12:39:18 +0000 From: "Metzger, Markus T" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH 2/3] btrace: Remove VEC cleanups Date: Mon, 05 Mar 2018 12:39:00 -0000 Message-ID: References: <20180304205605.13037-1-simon.marchi@polymtl.ca> <20180304205605.13037-2-simon.marchi@polymtl.ca> In-Reply-To: <20180304205605.13037-2-simon.marchi@polymtl.ca> x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTE5MThmNWMtNjllOC00OTYzLTlkZTYtYjY5OGM5ODE0YmYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIxbFFwMWFOR1lUTFJ0cmxBcmpMKzNzcU5jbWx0ZFZzaUZYMHNyQlhEUWQzS2J3dkJcLzc1ZmxOVVp6MlNOMVZpNCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00114.txt.bz2 Hello Simon, > This patch replaces two VEC(tp_t) with std::vector, which > allows to remove two cleanups. To make it easier to map the old code to > the new code, I added the ordered_remove and unordered_remove functions, > which operate on std::vector and do the same as VEC's > ordered_remove/unordered_remove. Looks good to me. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928