From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/3] btrace: Remove btrace disable cleanup
Date: Mon, 05 Mar 2018 12:39:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B236964FA0A@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20180304205605.13037-1-simon.marchi@polymtl.ca>
Hello Simon,
> This patch removes a cleanup that disables btrace on threads in case of
> failure, so we don't leave it enabled for some the threads and disabled
> for the rest.
>
> gdb/ChangeLog:
>
> * record-btrace.c (record_btrace_disable_callback): Remove.
> (struct scoped_btrace_disable): New.
> (record_btrace_open): Use scoped_btrace_disable.
Looks good to me.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2018-03-05 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 20:56 Simon Marchi
2018-03-04 20:56 ` [PATCH 3/3] btrace: Remove ui_out cleanups Simon Marchi
2018-03-05 12:39 ` Metzger, Markus T
2018-03-05 22:16 ` Simon Marchi
2018-03-06 7:30 ` Metzger, Markus T
2018-03-06 14:40 ` Simon Marchi
2018-03-04 20:56 ` [PATCH 2/3] btrace: Remove VEC cleanups Simon Marchi
2018-03-05 12:39 ` Metzger, Markus T
2018-03-05 12:39 ` Metzger, Markus T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B236964FA0A@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox