From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 45807 invoked by alias); 1 Mar 2018 14:30:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45710 invoked by uid 89); 1 Mar 2018 14:30:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Tel, tel, commercial, office X-HELO: mga06.intel.com Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 14:30:30 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2018 06:30:27 -0800 X-ExtLoop1: 1 Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga006.jf.intel.com with ESMTP; 01 Mar 2018 06:30:27 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX151.ger.corp.intel.com ([169.254.4.16]) with mapi id 14.03.0319.002; Thu, 1 Mar 2018 14:30:26 +0000 From: "Metzger, Markus T" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Propagate record_print_flags Date: Thu, 01 Mar 2018 14:30:00 -0000 Message-ID: References: <1519912053-26118-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1519912053-26118-1-git-send-email-simon.marchi@ericsson.com> x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjhiMTA4OGYtMDZjYy00ZTIxLTg1OWItNmIwODJhNGIwOTE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiIxa0NJSmNIK3VUc3ladGJzYk8wMzFkbHRVaGNITTJiN2xVYUFBUDAzMENXa21rN1ZOUU1jaVdCTU83Ulo4RXdhIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00023.txt.bz2 Hello Simon, > These flags are returned as an int by get_call_history_modifiers, and > get cast back to record_print_flags in the btrace code. Instead, we can > make the arguments of that type from start to end. >=20 > gdb/ChangeLog: >=20 > * record.c (get_call_history_modifiers): Return a > record_print_flags. > (cmd_record_call_history): Adjust. > * record-btrace.c (record_btrace_call_history): Adjust. > (record_btrace_call_history_range): Adjust. > (record_btrace_call_history_from): Adjust. > * target-debug.h (target_debug_print_record_print_flags): New. > * target-delegates.c: Re-generate. > * target.c (target_call_history): Change flags type. > (target_call_history_from): Likewise. > (target_call_history_range): Likewise. > * target.h (struct target_ops) : Likewise. > (target_call_history_from): Likewise. > (target_call_history_range): Likewise. Looks good to me. > @@ -172,6 +172,8 @@ > target_debug_do_print (host_address_to_string (X.data ())) > #define target_debug_print_inferior_p(inf) \ > target_debug_do_print (host_address_to_string (inf)) > +#define target_debug_print_record_print_flags(X) \ > + target_debug_do_print (plongest (X)) Should we print them as hex? Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928