From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118367 invoked by alias); 28 Feb 2018 12:53:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118357 invoked by uid 89); 28 Feb 2018 12:53:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=UD:el X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Feb 2018 12:53:23 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2018 04:53:18 -0800 X-ExtLoop1: 1 Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga008.jf.intel.com with ESMTP; 28 Feb 2018 04:53:17 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX107.ger.corp.intel.com ([169.254.10.46]) with mapi id 14.03.0319.002; Wed, 28 Feb 2018 12:53:16 +0000 From: "Metzger, Markus T" To: "Maciej W. Rozycki" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method Date: Wed, 28 Feb 2018 12:53:00 -0000 Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-6-git-send-email-markus.t.metzger@intel.com> In-Reply-To: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTNjZmM2ZTctNGZiYi00NTI0LTg2YzYtMzBmNWNlMjM5YTA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJVc1FnamlPWWZtZ0JlWEp3Z0lpczRtNkJcL3FPaDBGcW5kS2h2TXBWVFZvaWJCbDc4UFMweVlRNENPOVdxM0RoTCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00457.txt.bz2 Hello Maciej, I wondered why my fill-column auto-mode settings didn't seem to be effectiv= e and found that they were overwritten by gdb/.dir-locals.el. If you want to enforce the 74 columns limit, you may want to submit the bel= ow patch. I will leave the fill-column 74 for the commit-message but fall back to 80 = columns for the rest. IIUC you were mostly concerned about the additional 4-columns indentation b= y 'git log'. Are you OK with that? Regards, Markus. --- diff --git a/gdb/.dir-locals.el b/gdb/.dir-locals.el index 7e2b0cc..abfd167 100644 --- a/gdb/.dir-locals.el +++ b/gdb/.dir-locals.el @@ -21,6 +21,7 @@ (nil . ((bug-reference-url-format . "http://sourceware.org/bugzilla/show_= bug.cgi?id=3D%s"))) (c-mode . ((c-file-style . "GNU") (mode . c++) + (fill-column . 74) (indent-tabs-mode . t) (tab-width . 8) (c-basic-offset . 2) > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Metzger, Markus T > Sent: 28 February 2018 12:24 > To: Maciej W. Rozycki > Cc: gdb-patches@sourceware.org > Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btr= ace > target method >=20 > Hello Maciej, >=20 > I added >=20 > (setq fill-column 74) >=20 > for COMMIT_EDITMSG and for *.[hc] files. This excludes .exp and .texinfo= (and > others), which are still at 80 columns. >=20 > Also for command help-text strings I believe it makes sense to stay at 80= columns. >=20 > Are you OK with that? >=20 > Regards, > Markus. >=20 > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairpers= on of > the Supervisory Board: Nicole Lau Registered Office: Munich Commercial > Register: Amtsgericht Muenchen HRB 186928 Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928