From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21762 invoked by alias); 27 Feb 2018 18:14:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21743 invoked by uid 89); 27 Feb 2018 18:14:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*r:169.254.10 X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Feb 2018 18:14:14 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2018 10:14:13 -0800 X-ExtLoop1: 1 Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga007.fm.intel.com with ESMTP; 27 Feb 2018 10:14:12 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX107.ger.corp.intel.com ([169.254.10.46]) with mapi id 14.03.0319.002; Tue, 27 Feb 2018 18:14:11 +0000 From: "Metzger, Markus T" To: "Maciej W. Rozycki" CC: Andreas Arnez , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method Date: Tue, 27 Feb 2018 18:14:00 -0000 Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-6-git-send-email-markus.t.metzger@intel.com> In-Reply-To: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzQ0OWUyY2ItMGQ0Yy00MmEwLWE4ZDQtNDYxZDg1YmFjZDQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJHN0lGMDZWOE84dlNaVVwvV3phQW1Qb1BiYjlDdlFGUVVNMFJcLzNOcUdNa2hhRmJkRHZRXC9BXC92Q1dwTW43RzZHMCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00429.txt.bz2 Hello Maciej, > With the change description you have also overrun our 74-column limit: > Standards#Column_limits>. > NB due to how `git log' etc. indents descriptions I prefer to stay within > 72 columns with my own changes for a better visual effect, though you are= of > course free to use your own judgement here as long as you're within 74 co= lumns. Actually, the hard limit is 80 columns. I've been using that, so far, and = from looking at other files in gdb/ it looks like others were using the 80 colum= ns limit, as well. > Same with ChangeLog entries. Also as per the the GNU Coding Standard: > > long function lists, etc. use `)' as the closing character, so: >=20 > * target.h (target_enable_btrace, target_disable_btrace) > (target_read_btrace, target_read_btrace_conf): Turn macro into > inline function. Throw error if target method not defined. >=20 > You need to mark new error messages for translation, so: >=20 > + error (_("Target does not support branch tracing.")); Thanks for pointing those out. I fixed them locally. =20=20 > > > Also did you verify that old-GDB/new-gdbserver and > > > new-GDB/old-gdbserver combinations work correctly? > > > > That was discussed here: > > https://sourceware.org/ml/gdb-patches/2018-02/msg00117.html >=20 > Thanks for confirming. Is there going to be any difference here for > non-x86 targets that needs to be verified? They're supposed to work the same way. I.e. older gdbservers won't advertise the packets and newer GDB's hence won't use them. And newer gdbservers would advertise the packets and, with this patch, fail on every request with "E.Target does not support branch tracing". Let me check that once for both directions just to be sure. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928