From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119977 invoked by alias); 14 Feb 2018 17:26:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119943 invoked by uid 89); 14 Feb 2018 17:26:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mga18.intel.com Received: from mga18.intel.com (HELO mga18.intel.com) (134.134.136.126) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Feb 2018 17:26:02 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2018 09:25:59 -0800 X-ExtLoop1: 1 Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga004.fm.intel.com with ESMTP; 14 Feb 2018 09:25:58 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by IRSMSX108.ger.corp.intel.com ([169.254.11.9]) with mapi id 14.03.0319.002; Wed, 14 Feb 2018 17:25:58 +0000 From: "Metzger, Markus T" To: Yao Qi CC: GDB Patches Subject: RE: [PATCH v2 1/7] common: add scoped_fd Date: Wed, 14 Feb 2018 17:26:00 -0000 Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDJkNDVkODQtZTFmNS00OWNmLWIzNDEtMjQ2NjUxYWZkMzg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJBV1FDYzkxblwvVE1MQ1RtdjVVNXZ5NVN6OGdGK2hkVVR3VTUxSFpLU3BJblJ5QU5vRmhVVnhnNnBlUlRWUzdtdyJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00205.txt.bz2 SGVsbG8gWWFvLA0KDQo+ID4gQ291bGQgeW91IHRyeSBzZXR0aW5nLCBzYXks IF9QT1NJWF9DX1NPVVJDRSBvciB0cnkgdXNpbmcgbWtvc3RlbXAoKSBpbnN0 ZWFkDQo+IG9mIG1rc3RlbXAoKT8NCj4gPg0KPiANCj4gTm9uZSBvZiB0aGVt IHdvcmtzIHdpdGggbXkgaTY4Ni13NjQtbWluZ3czMi1nKysgNC44LjIuICA6 KA0KDQpUaGFua3MgZm9yIHRyeWluZy4gIEkgd2lsbCBsb29rIGludG8gdGhp cy4NCg0KUmVnYXJkcywNCk1hcmt1cy4NCg0KPiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPiBGcm9tOiBZYW8gUWkgW21haWx0bzpxaXlhb2x0Y0Bn bWFpbC5jb21dDQo+IFNlbnQ6IDE0IEZlYnJ1YXJ5IDIwMTggMTY6MjMNCj4g VG86IE1ldHpnZXIsIE1hcmt1cyBUIDxtYXJrdXMudC5tZXR6Z2VyQGludGVs LmNvbT4NCj4gQ2M6IEdEQiBQYXRjaGVzIDxnZGItcGF0Y2hlc0Bzb3VyY2V3 YXJlLm9yZz4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2MiAxLzddIGNvbW1v bjogYWRkIHNjb3BlZF9mZA0KPiANCj4gT24gVHVlLCBGZWIgMTMsIDIwMTgg YXQgNToyOCBQTSwgTWV0emdlciwgTWFya3VzIFQNCj4gPG1hcmt1cy50Lm1l dHpnZXJAaW50ZWwuY29tPiB3cm90ZToNCj4gPg0KPiA+IFRoaXMgaXMgc3Vw cG9zZWQgdG8gYmUgYSBnbGliYyBmdW5jdGlvbi4gIEJ1dCBpdCBpcyBndWFy ZGVkIGJ5IHNvbWUgZmVhdHVyZQ0KPiBtYWNyb3MuDQo+ID4gUXVvdGUgZnJv bSBta3N0ZW1wKDMpOiAiDQo+ID4NCj4gPiAgICAgICAgbWtzdGVtcCgpOg0K PiA+ICAgICAgICAgICAgX0JTRF9TT1VSQ0UgfHwgX1NWSURfU09VUkNFIHx8 IF9YT1BFTl9TT1VSQ0UgPj0gNTAwIHx8DQo+IF9YT1BFTl9TT1VSQ0UgJiYg X1hPUEVOX1NPVVJDRV9FWFRFTkRFRA0KPiA+ICAgICAgICAgICAgfHwgLyog U2luY2UgZ2xpYmMgMi4xMjogKi8gX1BPU0lYX0NfU09VUkNFID49IDIwMDEx MkwNCj4gPg0KPiA+ICAgICAgICBta29zdGVtcCgpOiBfR05VX1NPVVJDRQ0K PiA+ICAgICAgICBta3N0ZW1wcygpOiBfQlNEX1NPVVJDRSB8fCBfU1ZJRF9T T1VSQ0UNCj4gPiAgICAgICAgbWtvc3RlbXBzKCk6IF9HTlVfU09VUkNFDQo+ ID4gIg0KPiA+DQo+ID4gTWF5YmUgdGhlIG5ld2VyIGNvbXBpbGVyIGlzIHNl dHRpbmcgc29tZSBtYWNyb3MgYXV0b21hdGljYWxseSB0aGF0IHRoZSBvbGRl cg0KPiBjb21waWxlciBkb2Vzbid0IHNldC4NCj4gPiBDb3VsZCB5b3UgdHJ5 IHNldHRpbmcsIHNheSwgX1BPU0lYX0NfU09VUkNFIG9yIHRyeSB1c2luZyBt a29zdGVtcCgpIGluc3RlYWQNCj4gb2YgbWtzdGVtcCgpPw0KPiA+DQo+IA0K PiBOb25lIG9mIHRoZW0gd29ya3Mgd2l0aCBteSBpNjg2LXc2NC1taW5ndzMy LWcrKyA0LjguMi4gIDooDQo+IA0KPiA+IElmIHRoYXQgZG9lc24ndCBoZWxw LCBJJ2xsIHRyeSB0byBmaW5kIGEgVWJ1bnR1IDE0LjA0IHRvIHJlcHJvZHVj ZSB0aGUgaXNzdWUuDQo+ID4NCj4gDQo+IC0tDQo+IFlhbyAo6b2Q5bCnKQ0K SW50ZWwgRGV1dHNjaGxhbmQgR21iSApSZWdpc3RlcmVkIEFkZHJlc3M6IEFt IENhbXBlb24gMTAtMTIsIDg1NTc5IE5ldWJpYmVyZywgR2VybWFueQpUZWw6 ICs0OSA4OSA5OSA4ODUzLTAsIHd3dy5pbnRlbC5kZQpNYW5hZ2luZyBEaXJl Y3RvcnM6IENocmlzdGluIEVpc2Vuc2NobWlkLCBDaHJpc3RpYW4gTGFtcHJl Y2h0ZXIKQ2hhaXJwZXJzb24gb2YgdGhlIFN1cGVydmlzb3J5IEJvYXJkOiBO aWNvbGUgTGF1ClJlZ2lzdGVyZWQgT2ZmaWNlOiBNdW5pY2gKQ29tbWVyY2lh bCBSZWdpc3RlcjogQW10c2dlcmljaHQgTXVlbmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-145403-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Feb 15 04:00:48 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 40807 invoked by alias); 15 Feb 2018 04:00:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40677 invoked by uid 89); 15 Feb 2018 04:00:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=unavailable version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Feb 2018 04:00:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B3FA05608A for ; Wed, 14 Feb 2018 23:00:15 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0Duefr-TOPsL for ; Wed, 14 Feb 2018 23:00:15 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id A5F6656085 for ; Wed, 14 Feb 2018 23:00:15 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4233) id A4D99517; Wed, 14 Feb 2018 23:00:15 -0500 (EST) From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [pushed/Ada] delete ada-lang.c::ada_to_fixed_value_create advance declaration Date: Thu, 15 Feb 2018 04:00:00 -0000 Message-Id: <1518667214-137460-1-git-send-email-brobecker@adacore.com> X-SW-Source: 2018-02/txt/msg00206.txt.bz2 Content-length: 1474 Hello, This advance declaration really isn't necesary, since the implementation of this function comes before the first reference to it. gdb/ChangeLog: * ada-lang.c (ada_to_fixed_value_create): Delete advance declaration. Tested by rebuilding GDB and pushed to master. Thank you, -- Joel --- gdb/ChangeLog | 5 +++++ gdb/ada-lang.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 947bed4..a36c44d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-02-15 Joel Brobecker + + * ada-lang.c (ada_to_fixed_value_create): Delete advance + declaration. + 2018-02-14 Pedro Alves * frame-unwind.c (frame_unwind_try_unwinder): Always call diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index d07da42..ff9dff5 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -225,9 +225,6 @@ static struct value *ada_value_primitive_field (struct value *, int, int, static int find_struct_field (const char *, struct type *, int, struct type **, int *, int *, int *, int *); -static struct value *ada_to_fixed_value_create (struct type *, CORE_ADDR, - struct value *); - static int ada_resolve_function (struct block_symbol *, int, struct value **, int, const char *, struct type *); -- 2.1.4