From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9941 invoked by alias); 13 Feb 2018 17:28:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9931 invoked by uid 89); 13 Feb 2018 17:28:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Chairperson, chairperson, 2.12 X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 17:28:30 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2018 09:28:29 -0800 X-ExtLoop1: 1 Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga004.jf.intel.com with ESMTP; 13 Feb 2018 09:28:28 -0800 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 13 Feb 2018 17:28:27 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.101]) by irsmsx155.ger.corp.intel.com ([169.254.14.21]) with mapi id 14.03.0319.002; Tue, 13 Feb 2018 17:28:27 +0000 From: "Metzger, Markus T" To: Yao Qi CC: GDB Patches Subject: RE: [PATCH v2 1/7] common: add scoped_fd Date: Tue, 13 Feb 2018 17:28:00 -0000 Message-ID: References: <1516976072-19282-1-git-send-email-markus.t.metzger@intel.com> <1516976072-19282-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTAzNzhkOWYtMDI0OS00ZGIyLTg3OWEtYzczNmMzZTA2ZTZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJpRG9iOGZ2QmN1bURRanZ3Z1ZNTmhFaXRza1N6RXUrRmN2Mlg0bUFpK1Vzb1VDbjdMcm9nK3dwdzFiOWVUbktYIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00189.txt.bz2 SGVsbG8gWWFvLA0KDQo+IFRoZXJlIGlzIG5vIHN1Y2ggZXJyb3Igd2l0aCBp Njg2LXc2NC1taW5ndzMyLWcrKyA1LjMuMS4gIENhbiB3ZSB1c2UgIm9wZW4i DQo+IGluc3RlYWQ/DQoNCkEgZml4ZWQgZmlsZW5hbWUgd29ya3MgbW9zdCBv ZiB0aGUgdGltZSBidXQgSSdkIHJhdGhlciB1c2UgYSB0ZW1wb3JhcnkgZmls ZSBpZiBwb3NzaWJsZS4NCg0KDQo+ID4gKy8qIFRlc3QgdGhhdCB0aGUgZmls ZSBkZXNjcmlwdG9yIGlzIGNsb3NlZC4gICovIHN0YXRpYyB2b2lkDQo+ID4g K3Rlc3RfZGVzdHJveSAoKSB7DQo+ID4gKyAgY2hhciBmaWxlbmFtZVtdID0g InNjb3BlZF9mZC1zZWxmdGVzdC1YWFhYWFgiOw0KPiA+ICsgIGludCBmZCA9 IG1rc3RlbXAgKGZpbGVuYW1lKTsNCj4gPiArICBTRUxGX0NIRUNLIChmZCA+ PSAwKTsNCj4gDQo+IEhpIE1hcmt1cywNCj4gSSBmYWlsZWQgdG8gYnVpbGQg dGhpcyBmaWxlIHdpdGggaTY4Ni13NjQtbWluZ3czMi1nKysgNC44LjIsIHNo aXBwZWQgaW4gVWJ1bnR1DQo+IDE0LjA0Lg0KPiANCj4gZ2RiL3VuaXR0ZXN0 cy9zY29wZWRfZmQtc2VsZnRlc3RzLmM6Mzc6Mjk6IGVycm9yOiDigJhta3N0 ZW1w4oCZIHdhcyBub3QgZGVjbGFyZWQgaW4NCj4gdGhpcyBzY29wZQ0KPiAg ICBpbnQgZmQgPSBta3N0ZW1wIChmaWxlbmFtZSk7DQo+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgXg0KDQpUaGlzIGlzIHN1cHBvc2VkIHRvIGJl IGEgZ2xpYmMgZnVuY3Rpb24uICBCdXQgaXQgaXMgZ3VhcmRlZCBieSBzb21l IGZlYXR1cmUgbWFjcm9zLg0KUXVvdGUgZnJvbSBta3N0ZW1wKDMpOiAiDQoN CiAgICAgICBta3N0ZW1wKCk6DQogICAgICAgICAgIF9CU0RfU09VUkNFIHx8 IF9TVklEX1NPVVJDRSB8fCBfWE9QRU5fU09VUkNFID49IDUwMCB8fCBfWE9Q RU5fU09VUkNFICYmIF9YT1BFTl9TT1VSQ0VfRVhURU5ERUQNCiAgICAgICAg ICAgfHwgLyogU2luY2UgZ2xpYmMgMi4xMjogKi8gX1BPU0lYX0NfU09VUkNF ID49IDIwMDExMkwNCg0KICAgICAgIG1rb3N0ZW1wKCk6IF9HTlVfU09VUkNF DQogICAgICAgbWtzdGVtcHMoKTogX0JTRF9TT1VSQ0UgfHwgX1NWSURfU09V UkNFDQogICAgICAgbWtvc3RlbXBzKCk6IF9HTlVfU09VUkNFDQoiDQoNCk1h eWJlIHRoZSBuZXdlciBjb21waWxlciBpcyBzZXR0aW5nIHNvbWUgbWFjcm9z IGF1dG9tYXRpY2FsbHkgdGhhdCB0aGUgb2xkZXIgY29tcGlsZXIgZG9lc24n dCBzZXQuDQpDb3VsZCB5b3UgdHJ5IHNldHRpbmcsIHNheSwgX1BPU0lYX0Nf U09VUkNFIG9yIHRyeSB1c2luZyBta29zdGVtcCgpIGluc3RlYWQgb2YgbWtz dGVtcCgpPw0KDQpJZiB0aGF0IGRvZXNuJ3QgaGVscCwgSSdsbCB0cnkgdG8g ZmluZCBhIFVidW50dSAxNC4wNCB0byByZXByb2R1Y2UgdGhlIGlzc3VlLg0K DQp0aGFua3MsDQpNYXJrdXMuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCj4gRnJvbTogWWFvIFFpIFttYWlsdG86cWl5YW9sdGNAZ21haWwu Y29tXQ0KPiBTZW50OiAxMyBGZWJydWFyeSAyMDE4IDE3OjQ4DQo+IFRvOiBN ZXR6Z2VyLCBNYXJrdXMgVCA8bWFya3VzLnQubWV0emdlckBpbnRlbC5jb20+ DQo+IENjOiBHREIgUGF0Y2hlcyA8Z2RiLXBhdGNoZXNAc291cmNld2FyZS5v cmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS83XSBjb21tb246IGFk ZCBzY29wZWRfZmQNCj4gDQo+IE9uIEZyaSwgSmFuIDI2LCAyMDE4IGF0IDI6 MTQgUE0sIE1hcmt1cyBNZXR6Z2VyIDxtYXJrdXMudC5tZXR6Z2VyQGludGVs LmNvbT4NCj4gd3JvdGU6DQo+ID4gKw0KPiA+ICsvKiBUZXN0IHRoYXQgdGhl IGZpbGUgZGVzY3JpcHRvciBpcyBjbG9zZWQuICAqLyBzdGF0aWMgdm9pZA0K PiA+ICt0ZXN0X2Rlc3Ryb3kgKCkgew0KPiA+ICsgIGNoYXIgZmlsZW5hbWVb XSA9ICJzY29wZWRfZmQtc2VsZnRlc3QtWFhYWFhYIjsNCj4gPiArICBpbnQg ZmQgPSBta3N0ZW1wIChmaWxlbmFtZSk7DQo+ID4gKyAgU0VMRl9DSEVDSyAo ZmQgPj0gMCk7DQo+IA0KPiBIaSBNYXJrdXMsDQo+IEkgZmFpbGVkIHRvIGJ1 aWxkIHRoaXMgZmlsZSB3aXRoIGk2ODYtdzY0LW1pbmd3MzItZysrIDQuOC4y LCBzaGlwcGVkIGluIFVidW50dQ0KPiAxNC4wNC4NCj4gDQo+IGdkYi91bml0 dGVzdHMvc2NvcGVkX2ZkLXNlbGZ0ZXN0cy5jOjM3OjI5OiBlcnJvcjog4oCY bWtzdGVtcOKAmSB3YXMgbm90IGRlY2xhcmVkIGluDQo+IHRoaXMgc2NvcGUN Cj4gICAgaW50IGZkID0gbWtzdGVtcCAoZmlsZW5hbWUpOw0KPiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIF4NCj4gZ2RiL3VuaXR0ZXN0cy9zY29w ZWRfZmQtc2VsZnRlc3RzLmM6IEluIGZ1bmN0aW9uIOKAmHZvaWQNCj4gc2Vs ZnRlc3RzOjpzY29wZWRfZmQ6OnRlc3RfcmVsZWFzZSgp4oCZOg0KPiBnZGIv dW5pdHRlc3RzL3Njb3BlZF9mZC1zZWxmdGVzdHMuYzo1NjoyOTogZXJyb3I6 IOKAmG1rc3RlbXDigJkgd2FzIG5vdCBkZWNsYXJlZCBpbg0KPiB0aGlzIHNj b3BlDQo+ICAgIGludCBmZCA9IG1rc3RlbXAgKGZpbGVuYW1lKTsNCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBeDQo+IA0KPiBUaGVyZSBpcyBu byBzdWNoIGVycm9yIHdpdGggaTY4Ni13NjQtbWluZ3czMi1nKysgNS4zLjEu ICBDYW4gd2UgdXNlICJvcGVuIg0KPiBpbnN0ZWFkPw0KPiANCj4gLS0NCj4g WWFvICjpvZDlsKcpDQpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVy ZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJn LCBHZXJtYW55ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVsLmRl Ck1hbmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2htaWQsIENo cmlzdGlhbiBMYW1wcmVjaHRlcgpDaGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2 aXNvcnkgQm9hcmQ6IE5pY29sZSBMYXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11 bmljaApDb21tZXJjaWFsIFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hl biBIUkIgMTg2OTI4Cg== >From gdb-patches-return-145387-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Feb 13 19:05:08 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 129978 invoked by alias); 13 Feb 2018 19:05:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 129965 invoked by uid 89); 13 Feb 2018 19:05:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Feb 2018 19:05:00 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E35F40FB646; Tue, 13 Feb 2018 19:04:59 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1593FB07A1; Tue, 13 Feb 2018 19:04:56 +0000 (UTC) From: Sergio Durigan Junior To: Simon Marchi Cc: GDB Patches , Jan Kratochvil Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent" References: <20180131210430.23787-1-sergiodj@redhat.com> Date: Tue, 13 Feb 2018 19:05:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 12 Feb 2018 23:58:41 -0500") Message-ID: <87d118hfs7.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00190.txt.bz2 Content-length: 1571 On Monday, February 12 2018, Simon Marchi wrote: > On 2018-01-31 04:04 PM, Sergio Durigan Junior wrote: >> Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB >> with ncursesw") modified our configure.ac and included the check for >> "ncursesw" when searching for "waddstr". However, there's one more >> place where we should check for "ncursesw" first: >> >> AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses]) >> >> This patch changes the order of the libraries to be searched when >> looking for "tgetent", and puts "ncursesw" before "curses ...". >> >> This is another patch we carry on Fedora GDB. > > I think it makes sense, but can you expand on why this is needed? The rationale for this patch was: https://bugzilla.redhat.com/show_bug.cgi?id=1270534 This is a bug that happened on Fedora GDB when linking against ncurses, but not ncursesw. The bug has been fixed upstream by commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181, but the AC_SEARCH_LIBS line for tgetent has not been modified, so, for the sake of completeness, I think it makes sense to leave configure.ac in a consistent state (i.e., requiring ncursesw over ncurses whenever applicable). I guess that's the gist of it. There's not much that can be said, the patch is really simple and its intention is to make things more uniform. I can include the link to the Red Hat bug in the commit message, if you want. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/