RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method

Maciej W. Rozycki
2018-02-28T15:55:55Z

Hi Markus,

> I wondered why my fill-column auto-mode settings didn't seem to be effective and found
> that they were overwritten by gdb/.dir-locals.el.
>
> If you want to enforce the 74 columns limit, you may want to submit the below patch.

I don't use Emacs so I can't comment on technical details of your change,
although at the high level it does look reasonable to me.

> I will leave the fill-column 74 for the commit-message but fall back to 80 columns for the rest.
> IIUC you were mostly concerned about the additional 4-columns indentation by 'git log'.
> Are you OK with that?

As I say we have the formatting rules set as documented in our wiki, so
please do follow them, or if you want to get them changed, then you need
to reach consensus about your proposal among GDB maintainers.

Maciej