RE: [PATCH v2 5/7] btrace, gdbserver: remove the to_supports_btrace target method

Metzger, Markus T
2018-02-27T18:14:17Z

Hello Maciej,

> With the change description you have also overrun our 74-column limit:
> <https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-
> Standards#Column_limits>.
> NB due to how `git log' etc. indents descriptions I prefer to stay within
> 72 columns with my own changes for a better visual effect, though you are of
> course free to use your own judgement here as long as you're within 74 columns.

Actually, the hard limit is 80 columns. I've been using that, so far, and from
looking at other files in gdb/ it looks like others were using the 80 columns limit,
as well.

> Same with ChangeLog entries. Also as per the the GNU Coding Standard:
> <https://www.gnu.org/prep/standards/standards.html#Style-of-Change-Logs>
> long function lists, etc. use `)' as the closing character, so:
>
> * target.h (target_enable_btrace, target_disable_btrace)
> (target_read_btrace, target_read_btrace_conf): Turn macro into
> inline function. Throw error if target method not defined.
>
> You need to mark new error messages for translation, so:
>
> + error (_("Target does not support branch tracing."));

Thanks for pointing those out. I fixed them locally.

> > > Also did you verify that old-GDB/new-gdbserver and
> > > new-GDB/old-gdbserver combinations work correctly?
> >
> > That was discussed here:
> > https://sourceware.org/ml/gdb-patches/2018-02/msg00117.html
>
> Thanks for confirming. Is there going to be any difference here for
> non-x86 targets that needs to be verified?

They're supposed to work the same way. I.e. older gdbservers won't
advertise the packets and newer GDB's hence won't use them. And
newer gdbservers would advertise the packets and, with this patch,
fail on every request with "E.Target does not support branch tracing".

Let me check that once for both directions just to be sure.

Regards,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928