From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62177 invoked by alias); 8 Dec 2017 08:04:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62166 invoked by uid 89); 8 Dec 2017 08:04:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Tel, tel X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 08:04:04 +0000 Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2017 00:04:02 -0800 X-ExtLoop1: 1 Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga005.fm.intel.com with ESMTP; 08 Dec 2017 00:04:00 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0319.002; Fri, 8 Dec 2017 08:03:59 +0000 From: "Metzger, Markus T" To: Simon Marchi , Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector Date: Fri, 08 Dec 2017 08:04:00 -0000 Message-ID: References: <20171202164937.13641-1-simon.marchi@polymtl.ca> <9142baa8-d50b-1b14-3809-20adbb0b5488@ericsson.com> In-Reply-To: <9142baa8-d50b-1b14-3809-20adbb0b5488@ericsson.com> x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY5Y2Y4NjUtNDUyNy00NTA4LWIwZjItOTk5MmQxNWM5MmIxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJhT3JueWxKK1c3T1VQanRTdTdVVjVVdkRZT2Z0alRIcVUydDFWUHVUQWZraWYzcmJpdVpkR2I1SlwvM0R4WWp2TCJ9 dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00155.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTaW1vbiBN YXJjaGkgW21haWx0bzpzaW1vbi5tYXJjaGlAZXJpY3Nzb24uY29tXQ0KPiBT ZW50OiAwNyBEZWNlbWJlciAyMDE3IDE5OjUwDQo+IFRvOiBNZXR6Z2VyLCBN YXJrdXMgVCA8bWFya3VzLnQubWV0emdlckBpbnRlbC5jb20+OyBTaW1vbiBN YXJjaGkNCj4gPHNpbW9uLm1hcmNoaUBwb2x5bXRsLmNhPjsgZ2RiLXBhdGNo ZXNAc291cmNld2FyZS5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gUmVw bGFjZSBWRUMoZ2RiX3htbF92YWx1ZV9zKSB3aXRoIHN0ZDo6dmVjdG9yDQoN CkhlbGxvIFNpbW9uLA0KDQo+IEluIHlvdXIgcXVvdGUsIHRoZXJlIGFwcGVh cnMgdG8gYmUgdHdvIGFkZGVkIGxpbmVzICh0d28gKyk6DQo+IA0KPiA+IC0g ICAgPSAoY29uc3QgY2hhciAqKSB4bWxfZmluZF9hdHRyaWJ1dGUgKGF0dHJp YnV0ZXMsICJ2ZXJzaW9uIiktPnZhbHVlOw0KPiA+ICsgICAgPSAoY29uc3Qg Y2hhciAqKSB4bWxfZmluZF9hdHRyaWJ1dGUgKGF0dHJpYnV0ZXMsDQo+ID4g KyAidmVyc2lvbiIpLT52YWx1ZS5nZXQgKCk7DQo+IA0KPiBCdXQgaW4gbXkg cGF0Y2ggaXQncyBhbGwgb24gdGhlIHNhbWUgbGluZS4gIEkgYW0gY29uZnVz ZWQuDQoNClRoYXQncyB3aGF0IEkgbWVhbnQgd2l0aCBvZGQuICBMb29rcyBs aWtlIHNvbWUgZXh0cmEgbGluZSBicmVha3MuDQoNCj4gDQo+ID4gQEAgLTIw NDAsOCArMjA0Miw4IEBAIHBhcnNlX3htbF9idHJhY2VfYmxvY2sgKHN0cnVj dCBnZGJfeG1sX3BhcnNlcg0KPiAqcGFyc2VyLA0KPiA+ICAgICAgICBnZGJf eG1sX2Vycm9yIChwYXJzZXIsIF8oIkJ0cmFjZSBmb3JtYXQgZXJyb3IuIikp Ow0KPiA+ICAgICAgfQ0KPiA+DQo+ID4gLSAgYmVnaW4gPSAoVUxPTkdFU1Qg KikgeG1sX2ZpbmRfYXR0cmlidXRlIChhdHRyaWJ1dGVzLA0KPiA+ICJiZWdp biIpLT52YWx1ZTsNCj4gPiAtICBlbmQgPSAoVUxPTkdFU1QgKikgeG1sX2Zp bmRfYXR0cmlidXRlIChhdHRyaWJ1dGVzLCAiZW5kIiktPnZhbHVlOw0KPiA+ ICsgIGJlZ2luID0gKFVMT05HRVNUICopIHhtbF9maW5kX2F0dHJpYnV0ZSAo YXR0cmlidXRlcywNCj4gPiArICJiZWdpbiIpLT52YWx1ZS5nZXQgKCk7ICBl bmQgPSAoVUxPTkdFU1QgKikgeG1sX2ZpbmRfYXR0cmlidXRlDQo+ID4gKyAo YXR0cmlidXRlcywgImVuZCIpLT52YWx1ZS5nZXQgKCk7DQoNCkFuZCBoZXJl LCB0aGUgbGluZSBicmVhayBhZnRlciAnOycgc2VlbXMgdG8gaGF2ZSBiZWVu IHJlbW92ZWQuDQoNClRoYW5rcywNCk1hcmt1cy4NCg0KSW50ZWwgRGV1dHNj aGxhbmQgR21iSApSZWdpc3RlcmVkIEFkZHJlc3M6IEFtIENhbXBlb24gMTAt MTIsIDg1NTc5IE5ldWJpYmVyZywgR2VybWFueQpUZWw6ICs0OSA4OSA5OSA4 ODUzLTAsIHd3dy5pbnRlbC5kZQpNYW5hZ2luZyBEaXJlY3RvcnM6IENocmlz dGluIEVpc2Vuc2NobWlkLCBDaHJpc3RpYW4gTGFtcHJlY2h0ZXIKQ2hhaXJw ZXJzb24gb2YgdGhlIFN1cGVydmlzb3J5IEJvYXJkOiBOaWNvbGUgTGF1ClJl Z2lzdGVyZWQgT2ZmaWNlOiBNdW5pY2gKQ29tbWVyY2lhbCBSZWdpc3Rlcjog QW10c2dlcmljaHQgTXVlbmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-144141-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Dec 08 08:19:21 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 95535 invoked by alias); 8 Dec 2017 08:19:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 95521 invoked by uid 89); 8 Dec 2017 08:19:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 08:19:19 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vB88JDLc024213 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 8 Dec 2017 03:19:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 277691E585; Fri, 8 Dec 2017 03:19:13 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id B419E1E02D; Fri, 8 Dec 2017 03:18:52 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 08 Dec 2017 08:19:00 -0000 From: Simon Marchi To: "Metzger, Markus T" Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Replace VEC(gdb_xml_value_s) with std::vector In-Reply-To: References: <20171202164937.13641-1-simon.marchi@polymtl.ca> <9142baa8-d50b-1b14-3809-20adbb0b5488@ericsson.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 8 Dec 2017 08:19:13 +0000 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00156.txt.bz2 Content-length: 1217 On 2017-12-08 03:03, Metzger, Markus T wrote: >> In your quote, there appears to be two added lines (two +): >> >> > - = (const char *) xml_find_attribute (attributes, "version")->value; >> > + = (const char *) xml_find_attribute (attributes, >> > + "version")->value.get (); >> >> But in my patch it's all on the same line. I am confused. > > That's what I meant with odd. Looks like some extra line breaks. > >> >> > @@ -2040,8 +2042,8 @@ parse_xml_btrace_block (struct gdb_xml_parser >> *parser, >> > gdb_xml_error (parser, _("Btrace format error.")); >> > } >> > >> > - begin = (ULONGEST *) xml_find_attribute (attributes, >> > "begin")->value; >> > - end = (ULONGEST *) xml_find_attribute (attributes, "end")->value; >> > + begin = (ULONGEST *) xml_find_attribute (attributes, >> > + "begin")->value.get (); end = (ULONGEST *) xml_find_attribute >> > + (attributes, "end")->value.get (); > > And here, the line break after ';' seems to have been removed. Is it possible that this is done by your email client? The snippets you quoted don't look like the version in the archive, there the patch looks fine: https://sourceware.org/ml/gdb-patches/2017-12/msg00045.html Simon