From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93096 invoked by alias); 21 Sep 2017 07:02:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93037 invoked by uid 89); 21 Sep 2017 07:02:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mga05.intel.com Received: from mga05.intel.com (HELO mga05.intel.com) (192.55.52.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 07:02:44 +0000 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 21 Sep 2017 00:02:42 -0700 X-ExtLoop1: 1 Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga005.jf.intel.com with ESMTP; 21 Sep 2017 00:02:41 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 21 Sep 2017 08:02:40 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by irsmsx112.ger.corp.intel.com ([169.254.1.142]) with mapi id 14.03.0319.002; Thu, 21 Sep 2017 08:02:40 +0100 From: "Metzger, Markus T" To: Tom Tromey , "gdb-patches@sourceware.org" Subject: RE: [RFA 37/67] Constify some commands in record.c Date: Thu, 21 Sep 2017 07:02:00 -0000 Message-ID: References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-38-tom@tromey.com> In-Reply-To: <20170921051023.19023-38-tom@tromey.com> dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00603.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Tom Tromey > Sent: Thursday, September 21, 2017 7:10 AM > To: gdb-patches@sourceware.org > Cc: Tom Tromey > Subject: [RFA 37/67] Constify some commands in record.c Hello Tom, > ChangeLog > 2017-09-20 Tom Tromey >=20 > * record.c (cmd_record_delete, cmd_record_stop, cmd_record_save) > (cmd_record_goto_begin, cmd_record_goto_end, get_insn_number) > (get_context_size, no_chunk, get_insn_history_modifiers) > (cmd_record_insn_history, get_call_history_modifiers) > (cmd_record_call_history): Constify. > --- > gdb/ChangeLog | 8 ++++++++ > gdb/record.c | 36 ++++++++++++++++++++---------------- > 2 files changed, 28 insertions(+), 16 deletions(-) Looks good to me. > @@ -354,7 +354,8 @@ info_record_command (char *args, int from_tty) > static void > cmd_record_save (char *args, int from_tty) > { > - char *recfilename, recfilename_buffer[40]; > + const char *recfilename; > + char recfilename_buffer[40]; >=20 > require_record_target (); This isn't really related to adding a const add_cmd () version. > @@ -456,13 +458,15 @@ get_context_size (char **arg) > if (!isdigit (*pos)) > error (_("Expected positive number, got: %s."), pos); >=20 > - return strtol (pos, arg, 10); > + long result =3D strtol (pos, &end, 10); > + *arg =3D end; > + return result; > } The rest of the declarations are still at the beginning. Thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928