From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70957 invoked by alias); 13 Apr 2017 07:57:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70933 invoked by uid 89); 13 Apr 2017 07:57:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Supervisory, supervisory, ownersourcewareorg, owner@sourceware.org X-HELO: mga07.intel.com Received: from mga07.intel.com (HELO mga07.intel.com) (134.134.136.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Apr 2017 07:57:39 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 13 Apr 2017 00:57:38 -0700 X-ExtLoop1: 1 Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga001.jf.intel.com with ESMTP; 13 Apr 2017 00:57:38 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.170]) by IRSMSX151.ger.corp.intel.com ([169.254.4.123]) with mapi id 14.03.0319.002; Thu, 13 Apr 2017 08:53:22 +0100 From: "Metzger, Markus T" To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [PATCH 4/5] Don't memset non-POD types: struct btrace_insn Date: Thu, 13 Apr 2017 07:57:00 -0000 Message-ID: References: <1492050475-9238-1-git-send-email-palves@redhat.com> <1492050475-9238-5-git-send-email-palves@redhat.com> In-Reply-To: <1492050475-9238-5-git-send-email-palves@redhat.com> dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00403.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Thursday, April 13, 2017 4:28 AM > To: gdb-patches@sourceware.org > Subject: [PATCH 4/5] Don't memset non-POD types: struct btrace_insn Hello Pedro, > +/* Return the btrace instruction for INSN. */ > + > +static btrace_insn > +pt_btrace_insn (const struct pt_insn &insn) > +{ > + return {(CORE_ADDR) insn.ip, (gdb_byte) insn.size, > + pt_reclassify_insn (insn.iclass), > + pt_btrace_insn_flags (&insn)}; > +} This is the only user of pt_btrace_insn_flags. If you want, you may change it to take a const & instead of a const *. The patch looks good to me. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928