From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113125 invoked by alias); 29 Mar 2017 06:08:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113098 invoked by uid 89); 29 Mar 2017 06:08:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=essentially X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Mar 2017 06:08:29 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2017 23:08:27 -0700 X-ExtLoop1: 1 Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga006.fm.intel.com with ESMTP; 28 Mar 2017 23:08:24 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.170]) by IRSMSX107.ger.corp.intel.com ([169.254.10.107]) with mapi id 14.03.0319.002; Wed, 29 Mar 2017 07:08:23 +0100 From: "Metzger, Markus T" To: Yao Qi CC: "gdb-patches@sourceware.org" , "Wiederhake, Tim" , "xdje42@gmail.com" , Joel Brobecker Subject: RE: GDB 8.0 release/branching 2017-03-20 update Date: Wed, 29 Mar 2017 06:08:00 -0000 Message-ID: References: <20170320201629.pbjzaqsnvs7dx7f2@adacore.com> <86zigevkv0.fsf@gmail.com> <86inn1utkp.fsf@gmail.com> <86inmzvrbx.fsf@gmail.com> <86shm2u47t.fsf@gmail.com> <86wpbbnf1f.fsf@gmail.com> <86shlyoggb.fsf@gmail.com> <86mvc5o7o4.fsf@gmail.com> <86a885o0z2.fsf@gmail.com> In-Reply-To: <86a885o0z2.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00499.txt.bz2 SGVsbG8gWWFvLA0KDQo+ID4+IHN0cnVjdCBQeUdldFNldERlZiBweV9pbnNu X2dldHNldFtdID0NCj4gPj4gIHsNCj4gPj4gICB7ICJkYXRhIiwgcHlfaW5z bl9kYXRhLCBOVUxMLCAicmF3IGluc3RydWN0aW9uIGRhdGEiLCBOVUxMfSwN Cj4gPj4gICB7ICJkZWNvZGVkIiwgcHlfaW5zbl9kZWNvZGUsIE5VTEwsICJk ZWNvZGVkIGluc3RydWN0aW9uIiwgTlVMTH0sDQo+ID4+ICAgeyAic2l6ZSIs IHB5X2luc25fc2l6ZSwgTlVMTCwgImluc3RydWN0aW9uIHNpemUgaW4gYnl0 ZSIsIE5VTEx9LA0KPiA+PiAgIHsgInBjIiwgcHlfaW5zbl9wYywgTlVMTCwg Imluc3RydWN0aW9uIGFkZHJlc3MiLCBOVUxMIH0sDQo+ID4+ICAge05VTEx9 DQo+ID4+IH07DQo+ID4NCj4gPiBUaGlzIGlzIGZvciB0aGUgKGFic3RyYWN0 KSBiYXNlLWNsYXNzLCBJIGFzc3VtZS4NCj4gPg0KPiANCj4gWWVzLCBpdCBp cyB0aGUgYmFzZSBjbGFzcywgYnV0IGl0IGlzIHRoZSBpbXBsZW1lbnRhdGlv biBkZXRhaWwgYWJvdXQgdGhlDQo+IGNsYXNzIGlzIGFic3RyYWN0IG9yIG5v dC4gIEkgaGF2ZW4ndCB0aGluayBhYm91dCBpdCB5ZXQuICBBZ2FpbiwgSSBv bmx5DQo+IGNhcmUgYWJvdXQgcHl0aG9uIGludGVyZmFjZSBhdCB0aGlzIHN0 YWdlLg0KPiANCj4gPiBXZSBkb24ndCBzdG9yZSBhbnkgZGF0YSBpbiB0aGUg YmFzZSBjbGFzcyBzbyB0aGUgUHl0aG9uIG9iamVjdCB3b3VsZA0KPiA+IGNv bnRhaW4gdGhlIFB5T2JqZWN0IGhlYWRlciBhbmQgbm90aGluZyBlbHNlLCBj b3JyZWN0Pw0KPiA+DQo+ID4gQW5kIHRoZSBhYm92ZSBmdW5jdGlvbnMgd291 bGQgdGhyb3cgYW4gZXhjZXB0aW9uIG9yIHJldHVybiBOb25lLg0KPiA+IENv cnJlY3Q/DQo+ID4NCj4gDQo+IEkgZGlkbid0IGdvIHRoYXQgZmFyIHlldCA6 KQ0KDQpXaGF0IGVsc2UgY291bGQgdGhlIGRvPyAgV2UgYWdyZWVkIHRoYXQg dGhlIGJhc2UgY2xhc3Mgd2lsbCBiZSBhYnN0cmFjdCBhbmQNCmxldCB0aGUg ZGVyaXZlZCBjbGFzc2VzIGNob3NlIHRoZSBkYXRhIG1lbWJlcnMgdG8gYmVz dCBpbXBsZW1lbnQgdGhlIGZ1bmN0aW9ucy4NCg0KDQoNCj4gPj4gc3RydWN0 IFB5R2V0U2V0RGVmIGJ0cHlfaW5zbl9nZXRzZXRbXSA9DQo+ID4+IHsNCj4g Pj4gICB7ICJkYXRhIiwgYnRweV9pbnNuX2RhdGEsIE5VTEwsICJyYXcgaW5z dHJ1Y3Rpb24gZGF0YSIsIE5VTEx9LA0KPiA+PiAgIHsgImRlY29kZWQiLCBi dHB5X2luc25fZGVjb2RlLCBOVUxMLCAiZGVjb2RlZCBpbnN0cnVjdGlvbiIs IE5VTEx9LA0KPiA+PiAgIHsgInNpemUiLCBidHB5X2luc25fc2l6ZSwgTlVM TCwgImluc3RydWN0aW9uIHNpemUgaW4gYnl0ZSIsIE5VTEx9LA0KPiA+PiAg IHsgInBjIiwgYnRweV9pbnNuX3BjLCBOVUxMLCAiaW5zdHJ1Y3Rpb24gYWRk cmVzcyIsIE5VTEwgfSwNCj4gPj4NCj4gPj4gICB7ICJudW1iZXIiLCBidHB5 X251bWJlciwgTlVMTCwgImluc3RydWN0aW9uIG51bWJlciIsIE5VTEx9LA0K PiA+PiAgIHsgInNhbCIsIGJ0cHlfc2FsLCBOVUxMLCAiaW5zdHJ1Y3Rpb24g bnVtYmVyIiwgTlVMTH0sDQo+ID4+ICAge05VTEx9DQo+ID4+IH07DQo+ID4N Cj4gPiBUaGlzIGlzIGZvciB0aGUgQnRyYWNlSW5zdHJ1Y3Rpb24gZGVyaXZl ZCBjbGFzcywgSSBhc3N1bWUuICBUaGF0J3MgZXNzZW50aWFsbHkNCj4gPiB3 aGF0IFRpbSBpbXBsZW1lbnRlZC4gIENvcnJlY3Q/DQo+ID4NCj4gPiBUaGlz IGRvZXNuJ3QgbG9vayB0b28gZmFyIGF3YXkgZnJvbSB3aGF0IHdlIGhhdmUg aW4gR0RCIHRvZGF5Lg0KPiANCj4gSSByZXF1ZXN0ZWQgdG8gY2hhbmdlIHRo ZSBweXRob24gaW50ZXJmYWNlIGluIFRpbSdzIHBhdGNoLCBub3QgdGhlDQo+ IGltcGxlbWVudGF0aW9uLg0KDQpOb3cgSSdtIGEgYml0IGxvc3QuICBXaGF0 IGV4YWN0bHkgZG8geW91IHdhbnQgY2hhbmdlZCBhdCB0aGlzIHBvaW50IHRv DQplc3RhYmxpc2ggdGhlIFB5dGhvbiBpbnRlcmZhY2U/DQoNClRoYW5rcywN Ck1hcmt1cy4NCkludGVsIERldXRzY2hsYW5kIEdtYkgKUmVnaXN0ZXJlZCBB ZGRyZXNzOiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBOZXViaWJlcmcsIEdl cm1hbnkKVGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cuaW50ZWwuZGUKTWFu YWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNjaG1pZCwgQ2hyaXN0 aWFuIExhbXByZWNodGVyCkNoYWlycGVyc29uIG9mIHRoZSBTdXBlcnZpc29y eSBCb2FyZDogTmljb2xlIExhdQpSZWdpc3RlcmVkIE9mZmljZTogTXVuaWNo CkNvbW1lcmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0IE11ZW5jaGVuIEhS QiAxODY5MjgK >From gdb-patches-return-137856-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Mar 29 10:18:54 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 118600 invoked by alias); 29 Mar 2017 10:18:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 118455 invoked by uid 89); 29 Mar 2017 10:18:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=fancy, dive X-HELO: mail-wr0-f180.google.com Received: from mail-wr0-f180.google.com (HELO mail-wr0-f180.google.com) (209.85.128.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Mar 2017 10:18:49 +0000 Received: by mail-wr0-f180.google.com with SMTP id w43so8281578wrb.0 for ; Wed, 29 Mar 2017 03:18:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ig287aeQ0ZYqcv0z13pAfTA2jfjsoAkne5mWICLc1D4=; b=roaPWrZCgzMhdgTxy/nYk5Z3jHQQ8hOTFRhjnHvWWb8ON9V87NvDkQB4nl4uzoFuUU BEQVJGrBtNxARqtwP6W4ZnJbqgwPLDjSa1JEuVEsVfFcCAicqiYHInZQHwUIJSKaloth 9226W6VBiYVuji2HvDDEgIGJ7kkzzPr+5mHdI/Gud3IrwG/mB3TVQkLRc9Bfnyp9kZYe N+DF5YouomFRpDbA9ySvnpwSiL/tTtvNbjb9JpdfDJ5LQqXUS8HZ2ZwsCcbTDbyMuchl /jwprhBngSIdH1v9h3weFi4cP2ISW0PpoOxm8p8KH7B+zubQ+IY48NMMPF9mkodIrdgv wCBg== X-Gm-Message-State: AFeK/H3HaPckvGHgKC5PJJVcm+htG6xBW5FTH3wC2p4stJ3v+lzsW44EIC/g6RLCzdoAVw== X-Received: by 10.28.100.67 with SMTP id y64mr598561wmb.133.1490782727744; Wed, 29 Mar 2017 03:18:47 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id 140sm7531885wmg.18.2017.03.29.03.18.46 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 29 Mar 2017 03:18:47 -0700 (PDT) From: Yao Qi To: "Metzger\, Markus T" Cc: "gdb-patches\@sourceware.org" , "Wiederhake\, Tim" , "xdje42\@gmail.com" , Joel Brobecker Subject: Re: GDB 8.0 release/branching 2017-03-20 update References: <20170320201629.pbjzaqsnvs7dx7f2@adacore.com> <86zigevkv0.fsf@gmail.com> <86inn1utkp.fsf@gmail.com> <86inmzvrbx.fsf@gmail.com> <86shm2u47t.fsf@gmail.com> <86wpbbnf1f.fsf@gmail.com> <86shlyoggb.fsf@gmail.com> <86mvc5o7o4.fsf@gmail.com> <86a885o0z2.fsf@gmail.com> Date: Wed, 29 Mar 2017 10:18:00 -0000 In-Reply-To: (Markus T. Metzger's message of "Wed, 29 Mar 2017 06:08:22 +0000") Message-ID: <861stgo072.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00500.txt.bz2 Content-length: 2198 "Metzger, Markus T" writes: Hi Markus, > Now I'm a bit lost. What exactly do you want changed at this point to > establish the Python interface? I requested the change to Python interface, as described https://sourceware.org/ml/gdb-patches/2017-03/msg00366.html and the python interface is implementable, nothing odd or fancy there. I want: 1, we agree on that new python interface, 2, decide we either change the python interface according to my proposal before 8.0 release or release 8.0 without these record (btrace) python interfaces. I've never suggest anything on the implementation of the CPython code for the python interface. Anything reasonable is good to me, and we are free to change them because they are internal things. How to establish such python interface is a little bit out of the scope of this discussion, but let me try again to make it clear. In my proposal above, we have Python classes, Instruction { pc, data, decode, size; }; RecordInstruction : Instruction { sal; is_speculative; } Record.instruction_history returns a list of RecordInstruction objects. Instruction can be used for disassemble in Python. Note that how does these attributes get data is the implementation (C code) details. We have two approaches, a) copy all the data into the internal structure when the object is created, and the "get" function just returns the data in the internal structure, b) get the data from gdb when the attribute is accessed, Now, let us dive into C code, and py_insn_getset is for Python class Instruction, struct PyGetSetDef py_insn_getset[] =3D { { "data", py_insn_data, NULL, "raw instruction data", NULL}, { "decoded", py_insn_decode, NULL, "decoded instruction", NULL}, { "size", py_insn_size, NULL, "instruction size in byte", NULL}, { "pc", py_insn_pc, NULL, "instruction address", NULL }, {NULL} }; We are free to choose approach a) or b) for functions py_insn_data and py_insn_pc. Python class RecordInstruction has its own getset. If the py_insn_data's behavior is what RecordInstruction expects, just use it, otherwise, overwrite its own function. --=20 Yao (=E9=BD=90=E5=B0=A7)