From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31727 invoked by alias); 23 Mar 2017 18:17:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31703 invoked by uid 89); 23 Mar 2017 18:16:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=million X-HELO: mga06.intel.com Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Mar 2017 18:16:58 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 23 Mar 2017 11:16:44 -0700 X-ExtLoop1: 1 Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga006.fm.intel.com with ESMTP; 23 Mar 2017 11:16:43 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by IRSMSX108.ger.corp.intel.com ([169.254.11.173]) with mapi id 14.03.0248.002; Thu, 23 Mar 2017 18:16:42 +0000 From: "Metzger, Markus T" To: Yao Qi CC: "gdb-patches@sourceware.org" , "Wiederhake, Tim" , "xdje42@gmail.com" , "Joel Brobecker" Subject: RE: GDB 8.0 release/branching 2017-03-20 update Date: Thu, 23 Mar 2017 18:17:00 -0000 Message-ID: References: <20170320201629.pbjzaqsnvs7dx7f2@adacore.com> <86zigevkv0.fsf@gmail.com> <86inn1utkp.fsf@gmail.com> <86inmzvrbx.fsf@gmail.com> In-Reply-To: <86inmzvrbx.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00425.txt.bz2 SGVsbG8gWWFvLA0KDQo+ID4+ID4gSSdtIHdvbmRlcmluZyBob3cgbXVjaCBv ZiB0aGlzIGRpc2N1c3Npb24gaXMgcmVhbGx5IGEgcXVlc3Rpb24gb2YNCj4g Pj4gPiBzdWItY2xhc3NpbmcNCj4gPj4gPiBhbmQgaG93IG11Y2ggb2YgaXQg aXMgYWJvdXQgZG9jdW1lbnRhdGlvbi4gIFdvdWxkIEkgZXZlbiBiZSBhYmxl IHRvIHRlbGwgdGhlDQo+ID4+ID4gZGlmZmVyZW5jZSBpbiBteSBweXRob24g c2NyaXB0cyB0aGF0IHVzZSB0aGUgQVBJPw0KPiA+Pg0KPiA+PiBBbGwgdGhl IHVzZXIgdmlzaWJsZSBzdHVmZiBzaG91bGQgYmUgY292ZXJlZCBpbiB0aGlz IGRpc2N1c3Npb24uICBXZQ0KPiA+PiBuZWVkIHRvIG1lbnRpb24gdGhhdCAi Z2RiLlJlY29yZEluc3RydWN0aW9uIGV4dGVuZHMgZ2RiLkluc3RydWN0aW9u IiBpbg0KPiA+PiB0aGUgZG9jdW1lbnQsIHNvIHRoYXQgd2UgZG9uJ3QgaGF2 ZSB0byBkb2N1bWVudCBnZGIuSW5zdHJ1Y3Rpb24NCj4gPj4gYXR0cmlidXRl cyBhZ2FpbiBpbiBnZGIuUmVjb3JkSW5zdHJ1Y3Rpb24uDQo+ID4+DQo+ID4+ ID4NCj4gPj4gPiBUaGUgZHVjayB0eXBpbmcgYXJndW1lbnQgbWFrZXMgc2Vu c2UgdG8gbWUgYW5kIEknbSBub3QgZmFtaWxpYXIgZW5vdWdoDQo+ID4+ID4g d2l0aCBpbXBsZW1lbnRpbmcgUHl0aG9uIHRvIGhhdmUgYW4gb3BpbmlvbiBv biBob3cgdGhpcyBzaG91bGQgYmUgZG9uZS4NCj4gPj4gPiBEbyB3ZSBoYXZl IGFuIGV4cGVydCBvbiB0aGlzIGluIHRoZSBHREIgY29tbXVuaXR5Pw0KPiA+ PiA+DQo+ID4+DQo+ID4+IFRoZSBkdWNrIHR5cGluZyBpcyBhYm91dCB3cml0 aW5nIHB5dGhvbiBjb2RlLCBidXQgSSByYWlzZSBteSBjb25jZXJucyBpbg0K PiA+PiB0aGlzIHRocmVhZCBmcm9tIHRoZSB2aWV3IG9mIGNvbnRyb2xsaW5n IHRoZSBBUEkgKmludGVyZmFjZSogZm9yDQo+ID4+IGRpZmZlcmVudCByZWNv cmQgbWV0aG9kcyBieSBtZWFucyBvZiBpbmhlcml0YW5jZS4gIFdpdGggb3Ig d2l0aG91dA0KPiA+PiBpbmhlcml0YW5jZSwgdGhlIHB5dGhvbiBzY3JpcHQg c3RpbGwgY2FuIGRvIGR1Y2sgdHlwaW5nLCBubyBwcm9ibGVtLCBidXQNCj4g Pj4gd2Ugd2lsbCBlbmQgdXAgaGF2aW5nIGNvbXBsZXRlbHkgZGlmZmVyZW50 IHdheXMgb2Ygb3JnYW5pemluZyB0aGVzZQ0KPiA+PiBpbnRlcmZhY2UuICBT dXBwb3NlIHdlIGhhdmUgdGhyZWUgcmVjb3JkIG1ldGhvZHMsICJidHJhY2Ui LCAiZnVsbCIgYW5kDQo+ID4+ICJiYXIiLCBpbiBjdXJyZW50IGFwcHJvYWNo LCB3ZSBuZWVkIHRvIGRvY3VtZW50IGFsbCB0aGUgYXR0cmlidXRlcyBmb3IN Cj4gPj4gdGhlc2UgdGhyZWUgbWV0aG9kcywgYWx0aG91Z2ggc29tZSBvZiB0 aGVtIGFyZSBpbiBjb21tb24uICBXaHkgZG9uJ3Qgd2UNCj4gPj4gcHV0IHRo ZXNlIGNvbW1vbiBhdHRyaWJ1dGVzIGludG8gYSBiYXNlIGNsYXNzLCBhbmQg b25seSBkb2N1bWVudCB0aGUNCj4gPj4gYmFzZSBjbGFzcyAqb25jZSo/DQo+ ID4NCj4gPiBNYWtlcyBzZW5zZS4gIElzIHRoaXMgaG93IGl0IGlzIHVzdWFs bHkgaW1wbGVtZW50ZWQgaW4gUHl0aG9uPw0KPiA+DQo+IA0KPiBJIGRvbid0 IGtub3cuDQo+IA0KPiA+IEkgbGlrZWQgYWJvdXQgdGhlIGRlc2lnbiB0aGF0 IHdlIGNvdWxkIGhhdmUgYSByZWNvcmQtKHRhcmdldC0pc3BlY2lmaWMgaW50 ZXJuYWwNCj4gPiByZXByZXNlbnRhdGlvbi4gIElJUkMgd2Ugb25seSBzdG9y ZSB0aGUgdGhyZWFkJ3MgcHRpZCBhbmQgdGhlIGluc3RydWN0aW9uDQo+IG51 bWJlcg0KPiA+IGluIHRoYXQgdGhyZWFkJ3MgaW5zdHJ1Y3Rpb24gaGlzdG9y eS4gIEFuIEluc3RydWN0aW9uIG9iamVjdCBwcm92aWRlZCBieSBzb21lDQo+ ID4gZnV0dXJlIGdkYi5kaXNhc3NlbWJsZSgpIGZ1bmN0aW9uIHdpbGwgbmVl ZCBhIGRpZmZlcmVudCBpbnRlcm5hbCByZXByZXNlbnRhdGlvbi4NCj4gPiBX aWxsIHdlIGJlIGFibGUgdG8gZG8gdGhpcyB3aXRoIGEgY2xhc3MgaGllcmFy Y2h5Pw0KPiA+DQo+IA0KPiBXaGF0IGRvIHlvdSBtZWFuIGJ5ICJpbnRlcm5h bCByZXByZXNlbnRhdGlvbiI/ICBUaGV5IGFyZSBub3QgaW50ZXJuYWwsDQo+ IGFsbCBvZiB0aGVtIGFyZSBleHRlcm5hbGx5IHZpc2libGUuDQoNCkkgbWVh bnQgdGhhdCdzIGFsbCB3ZSBzdG9yZSBpbnRlcm5hbGx5LiAgRXZlcnl0aGlu ZyBlbHNlLCB0aGUgcGMsIHRoZSBpbnN0cnVjdGlvbidzIGJ5dGVzLA0KdGhl IGRpc2Fzc2VtYmx5LCBldmVuIHRoZSBpc19zcGVjdWxhdGl2ZSBmbGFnLCBp cyBjb21wdXRlZCB3aGVuIHRoZSByZXNwZWN0aXZlDQpmdW5jdGlvbiBpcyBj YWxsZWQgKG9yIGZpZWxkIGlzIGFjY2Vzc2VkKS4NCg0KSSB0aGluayB3ZSBh bHJlYWR5IGFncmVlZCB0byByZW1vdmUgdGhlIHB0aWQgZnJvbSB0aGUgQVBJ LiAgSSdtIGFsc28gbm90IHJlYWxseSBzdXJlDQp3ZSBuZWVkIHRoZSBudW1i ZXIgaW4gUHl0aG9uLiAgSXQgaXMgbmVlZGVkIGJ5IHRoZSBDTEkgdG8gcmVm ZXIgdG8gYW4gaW5zdHJ1Y3Rpb24NCmJ1dCBpbiBQeXRob24gd2UgY2FuIHVz ZSBhbiBpbnN0cnVjdGlvbiBvYmplY3QgZGlyZWN0bHkuDQoNCk9uY2Ugd2Ug ZHJvcCB0aG9zZSwgdGhlIGludGVybmFsIHJlcHJlc2VudGF0aW9uIHdpbGwg YmUgY29tcGxldGVseSBkaWZmZXJlbnQgZnJvbSB0aGUNCmV4dGVybmFsIG9u ZS4gIEFuZCBpdCB3aWxsIGJlIHJlY29yZC0oYnRyYWNlLSlzcGVjaWZpYy4g IEkgbGlrZSB0aGF0IGEgbG90IHNpbmNlIGNvbXB1dGluZw0KdGhlIGRpc2Fz c2VtYmx5IGlzIHJhdGhlciBleHBlbnNpdmUgYW5kIHRoZSBzdHJpbmcgaXMg cmVsYXRpdmVseSBiaWcuICBXaGVuIGEgc2NyaXB0IGlzDQppdGVyYXRpbmcg b3ZlciBhIGZldyBtaWxsaW9uIGluc3RydWN0aW9ucyBhbmQgYWxsIGl0IG5l ZWRzIGlzIHRoZSBwYyBvciB0aGUgc2FsIG9yIHRoZQ0KaXNfc3BlY3VsYXRp dmUgZmxhZyB0byBmaW5kIGEgVFNYIHJlZ2lvbiwgd2UgZG9uJ3Qgd2FudCB0 byBkaXNhc3NlbWJsZSB0aGUgaW5zdHJ1Y3Rpb24uDQoNCg0KPiA+PiBGdXJ0 aGVyLCB3aXRoIHN1Y2ggYmFzZSBjbGFzcywgd2UgY2FuIGd1YXJhbnRlZSB0 aGF0IHRoZSBjbGllbnQgcHl0aG9uDQo+ID4+IHNjcmlwdHMgb25seSBhY2Nl c3MgYmFzZSBjbGFzcyBhdHRyaWJ1dGVzIGFyZSByaWdodCBldmVuIHdpdGgg dGhlIG5ldw0KPiA+PiByZWNvcmQgbWV0aG9kIG1heSBiZSBhZGRlZCBpbiB0 aGUgZnV0dXJlLiAgSW4gY3VycmVudCBhcHByb2FjaCwgd2Ugd3JpdGUNCj4g Pj4gc3VjaCBweXRob24gY29kZSAicHJpbnQoaGV4KGkucGMpLCBpLnNhbCwg aS5kZWNvZGVkKSIganVzdCBiZWNhdXNlDQo+ID4+IEJ0cmFjZUluc3RydWN0 aW9uIGFuZCBGdWxsSW5zdHJ1Y3Rpb24gKmhhcHBlbiogdG8gaGF2ZSB0aGVz ZQ0KPiA+PiBhdHRyaWJ1dGVzLiAgV2hhdCBpZiBhIG5ldyByZWNvcmQgbWV0 aG9kICJiYXIiIGhhdmUgaW5zdHJ1Y3Rpb24gdHJhY2UNCj4gPj4gd2hpY2gg ZG9lc24ndCBoYXZlIGF0dHJpYnV0ZSAiZGVjb2RlZCI/DQo+ID4NCj4gPiBU aGV5J2QgZ2V0IGEgbm90LWltcGxlbWVudGVkIGV4Y2VwdGlvbi4NCj4gPg0K PiA+IEkgZG9uJ3Qgc2VlIGhvdyB3ZSBjb3VsZCBwcmV2ZW50IHRoYXQsIHRo b3VnaC4gIElmIHdlIGFkZGVkIGFub3RoZXINCj4gPiByZWNvcmRpbmcgbWV0 aG9kIHRoYXQgZGlkbid0IHByb3ZpZGUgb25lIG9mIHRoZSBmdW5jdGlvbnMg dGhlIG9sZA0KPiA+IHJlY29yZGluZyBtZXRob2QncyBpbnN0cnVjdGlvbiBv YmplY3QgcHJvdmlkZWQsIGl0IHdpbGwgaGF2ZSB0byBmYWlsDQo+ID4gc29t ZWhvdy4NCj4gPg0KPiA+IEFuZCB3ZSBkb24ndCB3YW50IHNjcmlwdHMgdG8g cmVzdHJpY3QgdGhlbXNlbHZlcyB0byB0aGUgSW5zdHJ1Y3Rpb24NCj4gPiBi YXNlIGNsYXNzLiAgSWYgdGhleSBhcmUgdXNpbmcgcmVjb3JkLWJ0cmFjZSB3 ZSBkbyB3YW50IHRoZW0gdG8gZ2V0DQo+ID4gdGhlIHNhbCBmcm9tIHRoZSBp bnN0cnVjdGlvbiBvYmplY3QsIGZvciBleGFtcGxlLg0KPiANCj4gV2UgZG9u J3QgcmVzdHJpY3QgdGhlbSB0byB0aGUgYmFzZSBjbGFzcy4gIFRoZXkgYXJl IHN0aWxsIGZyZWUgdXNpbmcNCj4gdGhlIGNsYXNzIG9mIHRoZWlyIHByZWZl cnJlZCByZWNvcmQgbWV0aG9kcy4gIEFnYWluLCBteQ0KPiBzdWdnZXN0aW9u L2Rlc2lnbiBkb2Vzbid0IGFwcGx5IGFueSByZXN0cmljdGlvbnMgdG8gdXNp bmcgdGhlc2UgcHl0aG9uDQo+IEFQSXMuICBJbnN0ZWFkLCBJIGludGVuZGVk IHRvIGFwcGx5IHRoZSByZXN0cmljdGlvbnMgdG8gdGhlIHB5dGhvbiBBUElz Lg0KDQpJdCBtYWtlcyBwZXJmZWN0IHNlbnNlIHRvIGFncmVlIG9uIHRoZSBm aWVsZHMgdGhlIHZhcmlvdXMgcmVjb3JkIHRhcmdldHMNCnByb3ZpZGUuDQoN ClJlZ2FyZHMsDQpNYXJrdXMuDQpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJl Z2lzdGVyZWQgQWRkcmVzczogQW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1 YmliZXJnLCBHZXJtYW55ClRlbDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3Lmlu dGVsLmRlCk1hbmFnaW5nIERpcmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2ht aWQsIENocmlzdGlhbiBMYW1wcmVjaHRlcgpDaGFpcnBlcnNvbiBvZiB0aGUg U3VwZXJ2aXNvcnkgQm9hcmQ6IE5pY29sZSBMYXUKUmVnaXN0ZXJlZCBPZmZp Y2U6IE11bmljaApDb21tZXJjaWFsIFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBN dWVuY2hlbiBIUkIgMTg2OTI4Cg== >From gdb-patches-return-137782-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Mar 24 03:02:03 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 9236 invoked by alias); 24 Mar 2017 03:02:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 9217 invoked by uid 89); 24 Mar 2017 03:02:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=zhou, Zhou X-HELO: mail-pf0-f177.google.com Received: from mail-pf0-f177.google.com (HELO mail-pf0-f177.google.com) (209.85.192.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 03:01:59 +0000 Received: by mail-pf0-f177.google.com with SMTP id o190so1321188pfo.0 for ; Thu, 23 Mar 2017 20:02:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VKfO7lOJ0rkkRHhkIwb10z4zJ3xkn5uqjNs7tNaQ/FE=; b=DTlh/g2m3QfpG1H4CMICBZRatNRxGU4tD5CunH1h1C0HJTA0rzoH7tHju3IdPEA0Ay HJmjfPXAgy2ywCaWePWPZ7e5scqZQb/Udrc/tAV3zruYKyapRYCQ1AmoMPNPAmL3av0K xYGqD82QpCtDyLEV3EVvdLJtYK6HsC5pV1FBkmVlpsg0/L7adjpDiw9M69pG+1MCrZgL dx72UMRgtRVaDaViD6zBKnBFdlIWDGsnruO2g1IKuACSe1BdH8gh9bIT2XYrw5EGWsmv 0IfU4Ke5lgMRRyzjUhe0g0nMRA9ItYcFtK6PX3lb56FW7m+FaeiFoL8OP3h1iYP0g3ec WvWQ== X-Gm-Message-State: AFeK/H1vBYpphvt3+zrQdD3d6d4EjKpdJU5IIXmsBY5t0FXn5IQ0Bun5Z7u8scuO5cOSKw== X-Received: by 10.98.69.141 with SMTP id n13mr6521402pfi.216.1490324518741; Thu, 23 Mar 2017 20:01:58 -0700 (PDT) Received: from titan.office.mos ([103.29.140.58]) by smtp.gmail.com with ESMTPSA id o194sm864246pfg.66.2017.03.23.20.01.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Mar 2017 20:01:57 -0700 (PDT) From: Yousong Zhou To: gdb-patches@sourceware.org Cc: Yousong Zhou Subject: [PATCH] Fix invalid sigprocmask call Date: Fri, 24 Mar 2017 03:02:00 -0000 Message-Id: <1490324519-11228-1-git-send-email-yszhou4tech@gmail.com> X-SW-Source: 2017-03/txt/msg00426.txt.bz2 Content-length: 1569 The POSIX document says The pthread_sigmask() and sigprocmask() functions shall fail if: [EINVAL] The value of the how argument is not equal to one of the defined values. and this is how musl-libc is currently doing. Fix the call to be safe and correct [1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_sigmask.html gdb/ChangeLog: 2017-03-24 Yousong Zhou * common/signals-state-save-restore.c (save_original_signals_state): Fix invalid sigprocmask call. --- gdb/ChangeLog | 5 +++++ gdb/common/signals-state-save-restore.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5ad7ac3..fc2c57b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-03-24 Yousong Zhou + + * common/signals-state-save-restore.c (save_original_signals_state): + Fix invalid sigprocmask call. + 2017-03-23 Simon Marchi * fbsd-tdep.c (fbsd_corefile_thread): Don't set/restore diff --git a/gdb/common/signals-state-save-restore.c b/gdb/common/signals-state-save-restore.c index d11a9ae..734335c 100644 --- a/gdb/common/signals-state-save-restore.c +++ b/gdb/common/signals-state-save-restore.c @@ -41,7 +41,7 @@ save_original_signals_state (void) int i; int res; - res = sigprocmask (0, NULL, &original_signal_mask); + res = sigprocmask (SIG_BLOCK, NULL, &original_signal_mask); if (res == -1) perror_with_name (("sigprocmask")); -- 2.6.4