From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18843 invoked by alias); 23 Mar 2017 16:01:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18819 invoked by uid 89); 23 Mar 2017 16:01:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=recording, Commercial, H*i:sk:86inn1u, H*f:sk:86inn1u X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Mar 2017 16:01:41 +0000 Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Mar 2017 09:01:39 -0700 X-ExtLoop1: 1 Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga004.jf.intel.com with ESMTP; 23 Mar 2017 09:01:38 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by IRSMSX152.ger.corp.intel.com ([169.254.6.125]) with mapi id 14.03.0248.002; Thu, 23 Mar 2017 16:01:37 +0000 From: "Metzger, Markus T" To: Yao Qi CC: "gdb-patches@sourceware.org" , "Wiederhake, Tim" , "xdje42@gmail.com" , "Joel Brobecker" Subject: RE: GDB 8.0 release/branching 2017-03-20 update Date: Thu, 23 Mar 2017 16:01:00 -0000 Message-ID: References: <20170320201629.pbjzaqsnvs7dx7f2@adacore.com> <86zigevkv0.fsf@gmail.com> <86inn1utkp.fsf@gmail.com> In-Reply-To: <86inn1utkp.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg00420.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBZYW8gUWkg W21haWx0bzpxaXlhb2x0Y0BnbWFpbC5jb21dDQo+IFNlbnQ6IFdlZG5lc2Rh eSwgTWFyY2ggMjIsIDIwMTcgNjowOSBQTQ0KPiBUbzogTWV0emdlciwgTWFy a3VzIFQgPG1hcmt1cy50Lm1ldHpnZXJAaW50ZWwuY29tPg0KPiBDYzogZ2Ri LXBhdGNoZXNAc291cmNld2FyZS5vcmc7IFdpZWRlcmhha2UsIFRpbQ0KPiA8 dGltLndpZWRlcmhha2VAaW50ZWwuY29tPjsgeGRqZTQyQGdtYWlsLmNvbTsg Sm9lbCBCcm9iZWNrZXINCj4gPGJyb2JlY2tlckBhZGFjb3JlLmNvbT4NCj4g U3ViamVjdDogUmU6IEdEQiA4LjAgcmVsZWFzZS9icmFuY2hpbmcgMjAxNy0w My0yMCB1cGRhdGUNCg0KSGVsbG8gWWFvLA0KDQo+ID4+ICAgMS4gQnRyYWNl SW5zdHJ1Y3Rpb24uc2FsIGlzIG5vdCBuZWNlc3NhcnkuICBJdCBjYW4gYmUg Z290IHZpYQ0KPiA+PiAgIGdkYi5maW5kX3BjX2xpbmUoQnRyYWNlSW5zdHJ1 Y3Rpb24ucGMpLg0KPiA+DQo+ID4gSSBhc2tlZCBUaW0gdG8gcHV0IHRoaXMg aW50byB0aGUgSW5zdHJ1Y3Rpb24gb2JqZWN0IGluIG9yZGVyIHRvIHN1cHBv cnQNCj4gPiBmdXR1cmUgZXh0ZW5zaW9ucy4NCj4gPg0KPiA+IEF0IHRoZSBt b21lbnQsIHdlIGRlY29kZSBmcm9tIGxpdmUgbWVtb3J5LCBhbmQgdGhlcmUs IHlvdSdyZSByaWdodA0KPiA+IHRoYXQgd2UgY2FuIGdldCB0aGUgU0FMIGZy b20gdGhlIFBDLiAgSWYgd2Ugd2FudGVkIHRvIHN1cHBvcnQgZXhlYygpDQo+ ID4gb3IgZGxjbG9zZSgpIGluIHRoZSBmdXR1cmUsIHRoZSB0cmFjZSB3b3Vs ZCByZWZlciB0byBpbnN0cnVjdGlvbnMgdGhhdCBhcmUNCj4gPiBubyBsb25n ZXIgYXZhaWxhYmxlIGluIG1lbW9yeSBhbmQgR0RCIHdvdWxkIG5vdCBrbm93 IGFib3V0IHRoZW0uDQo+ID4NCj4gPiBIYXZpbmcgdXNlcnMgZ2V0IHRoZSBT QUwgZnJvbSB0aGUgSW5zdHJ1Y3Rpb24gb2JqZWN0IGdpdmVzIHVzIG1vcmUN Cj4gPiBmcmVlZG9tIHRvIG1vZGVsIHRoaXMuICBXZSBjb3VsZCwgZm9yIGV4 YW1wbGUsIGRlY29kZSBmcm9tIGJpbmFyeQ0KPiA+IGZpbGVzIGFuZCBsZWF2 ZSBHREIgdG8gcmVwcmVzZW50IHRoZSBjdXJyZW50IHByb2dyYW0gc3RhdGUu ICBOb3Qgc3VyZQ0KPiA+IHdoZXRoZXIgdGhpcyB3b3VsZCBzdWZmaWNlIC0g cHJvYmFibHkgbm90LiAgQnV0IGl0IHNvdW5kZWQgbGlrZSBhIGdvb2QNCj4g PiBpZGVhIHRvIGhhdmUgdXNlcnMgZ2V0IHN1Y2ggaW5mb3JtYXRpb24gdmlh IHRoZSBJbnN0cnVjdGlvbiBvYmplY3QgZnJvbQ0KPiA+IHRoZSBiZWdpbm5p bmcuICBUaGF0J3MgYWxzbyB3aHkgdGhlIEluc3RydWN0aW9uIG9iamVjdCBo YXMgYSBkYXRhIGZ1bmN0aW9uDQo+ID4gdG8gZ2V0IHRoZSByYXcgYnl0ZXMg b2YgYW4gaW5zdHJ1Y3Rpb24gcmF0aGVyIHRoYW4gaGF2aW5nIHVzZXJzIHJl YWQNCj4gPiBpdCBmcm9tIG1lbW9yeS4NCj4gPg0KPiA+DQo+ID4+ICAgMi4g QnRyYWNlSW5zdHJ1Y3Rpb24gaGFzIHNvbWUgYXR0cmlidXRlcyAocGMsIGRh dGEsIGRlY29kZWQsIGFuZCBzaXplLCkNCj4gPj4gICB3aGljaCBhcmUgbm90 IGJ0cmFjZSByZWxhdGVkLg0KPiA+PiAgIFRoZXkgc2hvdWxkIGJlIG1vdmVk IHRvIGEgbmV3IGNsYXNzIGdkYi5JbnN0cnVjdGlvbiBhbmQgQnRyYWNlSW5z dHJ1Y3Rpb24NCj4gPj4gICBleHRlbmRzIGl0Lg0KPiA+Pg0KPiA+PiAgIElu c3RydWN0aW9uDQo+ID4+ICAgew0KPiA+PiAgICAgcGMsIGRhdGEsIGRlY29k ZSwgc2l6ZTsNCj4gPj4gICB9Ow0KPiA+DQo+ID4gVGhhdCBtYWtlcyBzZW5z ZSBpZiB3ZSdyZSBjb25zaWRlcmluZyBhIFB5dGhvbiBBUEkgZm9yIEdEQidz IGRpc2Fzc2VtYmxlci4NCj4gPiBJIHdvdWxkIGV4dGVuZCBpdCB0byBpbmNs dWRlIFNBTCBmb3IgdGhlIGFib3ZlIHJlYXNvbnMgc28gdXNlcnMgZG9uJ3Qg bmVlZA0KPiA+IHRvIGtub3cgZnJvbSB3aGVyZSB0aGV5IGdvdCB0aGUgSW5z dHJ1Y3Rpb24gb2JqZWN0Lg0KPiANCj4gSU1PLCBTQUwgb25seSBtYWtlcyBz ZW5zZSB0byBSZWNvcmRJbnN0cnVjdGlvbi4gIEkgZG9uJ3Qgc2VlIHdoeSBt dXN0IHB1dA0KPiBTQUwgaW50byBJbnN0cnVjdGlvbi4NCg0KSXQgaXMgY2Vy dGFpbmx5IG5vdCBhIG11c3QuICBJdCBtaWdodCBtYWtlIHRoaW5ncyBlYXNp ZXIgKG9yIGp1c3QgbW9yZSBjb252ZW5pZW50KQ0KYnV0IGlmIHdlIHdhbnQg YSBtaW5pbWFsIEluc3RydWN0aW9uIGJhc2UgY2xhc3MsIHdlIHdvdWxkIG9u bHkgbmVlZCBwYywgZGVjb2RlDQoocmVuYW1lIHRvIGRpc2Fzc2VtYmx5Pyks IGFuZCBzaXplLg0KDQpSZWNvcmQgaW5zdHJ1Y3Rpb25zIHdpbGwgYWRkIGRh dGEgYW5kIHNhbCBhbmQgYXQgbGVhc3QgcmVjb3JkLWJ0cmFjZSB3aWxsIGFk ZA0KaXNfc3BlY3VsYXRpdmUuICBJbiBvcmRlciB0byBub3QgY29tcGxpY2F0 ZSB0aGluZ3MgdG9vIG11Y2ggSSB3b3VsZCBhZGQNCmlzX3NwZWN1bGF0aXZl IGFsc28gdG8gcmVjb3JkLWZ1bGwgKGV2ZW4gaWYgaXQgaXMgYWx3YXlzIGZh bHNlKSBhbmQgcHV0IGV2ZXJ5dGhpbmcNCmludG8gYSBzaW5nbGUgUmVjb3Jk SW5zdHJ1Y3Rpb24gY2xhc3MgZm9yIGFsbCByZWNvcmQgdGFyZ2V0cy4gIE9L Pw0KDQoNCj4gPiBJJ20gd29uZGVyaW5nIGhvdyBtdWNoIG9mIHRoaXMgZGlz Y3Vzc2lvbiBpcyByZWFsbHkgYSBxdWVzdGlvbiBvZiBzdWItY2xhc3NpbmcN Cj4gPiBhbmQgaG93IG11Y2ggb2YgaXQgaXMgYWJvdXQgZG9jdW1lbnRhdGlv bi4gIFdvdWxkIEkgZXZlbiBiZSBhYmxlIHRvIHRlbGwgdGhlDQo+ID4gZGlm ZmVyZW5jZSBpbiBteSBweXRob24gc2NyaXB0cyB0aGF0IHVzZSB0aGUgQVBJ Pw0KPiANCj4gQWxsIHRoZSB1c2VyIHZpc2libGUgc3R1ZmYgc2hvdWxkIGJl IGNvdmVyZWQgaW4gdGhpcyBkaXNjdXNzaW9uLiAgV2UNCj4gbmVlZCB0byBt ZW50aW9uIHRoYXQgImdkYi5SZWNvcmRJbnN0cnVjdGlvbiBleHRlbmRzIGdk Yi5JbnN0cnVjdGlvbiIgaW4NCj4gdGhlIGRvY3VtZW50LCBzbyB0aGF0IHdl IGRvbid0IGhhdmUgdG8gZG9jdW1lbnQgZ2RiLkluc3RydWN0aW9uDQo+IGF0 dHJpYnV0ZXMgYWdhaW4gaW4gZ2RiLlJlY29yZEluc3RydWN0aW9uLg0KPiAN Cj4gPg0KPiA+IFRoZSBkdWNrIHR5cGluZyBhcmd1bWVudCBtYWtlcyBzZW5z ZSB0byBtZSBhbmQgSSdtIG5vdCBmYW1pbGlhciBlbm91Z2gNCj4gPiB3aXRo IGltcGxlbWVudGluZyBQeXRob24gdG8gaGF2ZSBhbiBvcGluaW9uIG9uIGhv dyB0aGlzIHNob3VsZCBiZSBkb25lLg0KPiA+IERvIHdlIGhhdmUgYW4gZXhw ZXJ0IG9uIHRoaXMgaW4gdGhlIEdEQiBjb21tdW5pdHk/DQo+ID4NCj4gDQo+ IFRoZSBkdWNrIHR5cGluZyBpcyBhYm91dCB3cml0aW5nIHB5dGhvbiBjb2Rl LCBidXQgSSByYWlzZSBteSBjb25jZXJucyBpbg0KPiB0aGlzIHRocmVhZCBm cm9tIHRoZSB2aWV3IG9mIGNvbnRyb2xsaW5nIHRoZSBBUEkgKmludGVyZmFj ZSogZm9yDQo+IGRpZmZlcmVudCByZWNvcmQgbWV0aG9kcyBieSBtZWFucyBv ZiBpbmhlcml0YW5jZS4gIFdpdGggb3Igd2l0aG91dA0KPiBpbmhlcml0YW5j ZSwgdGhlIHB5dGhvbiBzY3JpcHQgc3RpbGwgY2FuIGRvIGR1Y2sgdHlwaW5n LCBubyBwcm9ibGVtLCBidXQNCj4gd2Ugd2lsbCBlbmQgdXAgaGF2aW5nIGNv bXBsZXRlbHkgZGlmZmVyZW50IHdheXMgb2Ygb3JnYW5pemluZyB0aGVzZQ0K PiBpbnRlcmZhY2UuICBTdXBwb3NlIHdlIGhhdmUgdGhyZWUgcmVjb3JkIG1l dGhvZHMsICJidHJhY2UiLCAiZnVsbCIgYW5kDQo+ICJiYXIiLCBpbiBjdXJy ZW50IGFwcHJvYWNoLCB3ZSBuZWVkIHRvIGRvY3VtZW50IGFsbCB0aGUgYXR0 cmlidXRlcyBmb3INCj4gdGhlc2UgdGhyZWUgbWV0aG9kcywgYWx0aG91Z2gg c29tZSBvZiB0aGVtIGFyZSBpbiBjb21tb24uICBXaHkgZG9uJ3Qgd2UNCj4g cHV0IHRoZXNlIGNvbW1vbiBhdHRyaWJ1dGVzIGludG8gYSBiYXNlIGNsYXNz LCBhbmQgb25seSBkb2N1bWVudCB0aGUNCj4gYmFzZSBjbGFzcyAqb25jZSo/ DQoNCk1ha2VzIHNlbnNlLiAgSXMgdGhpcyBob3cgaXQgaXMgdXN1YWxseSBp bXBsZW1lbnRlZCBpbiBQeXRob24/DQoNCkkgbGlrZWQgYWJvdXQgdGhlIGRl c2lnbiB0aGF0IHdlIGNvdWxkIGhhdmUgYSByZWNvcmQtKHRhcmdldC0pc3Bl Y2lmaWMgaW50ZXJuYWwNCnJlcHJlc2VudGF0aW9uLiAgSUlSQyB3ZSBvbmx5 IHN0b3JlIHRoZSB0aHJlYWQncyBwdGlkIGFuZCB0aGUgaW5zdHJ1Y3Rpb24g bnVtYmVyDQppbiB0aGF0IHRocmVhZCdzIGluc3RydWN0aW9uIGhpc3Rvcnku ICBBbiBJbnN0cnVjdGlvbiBvYmplY3QgcHJvdmlkZWQgYnkgc29tZQ0KZnV0 dXJlIGdkYi5kaXNhc3NlbWJsZSgpIGZ1bmN0aW9uIHdpbGwgbmVlZCBhIGRp ZmZlcmVudCBpbnRlcm5hbCByZXByZXNlbnRhdGlvbi4NCldpbGwgd2UgYmUg YWJsZSB0byBkbyB0aGlzIHdpdGggYSBjbGFzcyBoaWVyYXJjaHk/DQoNCg0K PiBGdXJ0aGVyLCB3aXRoIHN1Y2ggYmFzZSBjbGFzcywgd2UgY2FuIGd1YXJh bnRlZSB0aGF0IHRoZSBjbGllbnQgcHl0aG9uDQo+IHNjcmlwdHMgb25seSBh Y2Nlc3MgYmFzZSBjbGFzcyBhdHRyaWJ1dGVzIGFyZSByaWdodCBldmVuIHdp dGggdGhlIG5ldw0KPiByZWNvcmQgbWV0aG9kIG1heSBiZSBhZGRlZCBpbiB0 aGUgZnV0dXJlLiAgSW4gY3VycmVudCBhcHByb2FjaCwgd2Ugd3JpdGUNCj4g c3VjaCBweXRob24gY29kZSAicHJpbnQoaGV4KGkucGMpLCBpLnNhbCwgaS5k ZWNvZGVkKSIganVzdCBiZWNhdXNlDQo+IEJ0cmFjZUluc3RydWN0aW9uIGFu ZCBGdWxsSW5zdHJ1Y3Rpb24gKmhhcHBlbiogdG8gaGF2ZSB0aGVzZQ0KPiBh dHRyaWJ1dGVzLiAgV2hhdCBpZiBhIG5ldyByZWNvcmQgbWV0aG9kICJiYXIi IGhhdmUgaW5zdHJ1Y3Rpb24gdHJhY2UNCj4gd2hpY2ggZG9lc24ndCBoYXZl IGF0dHJpYnV0ZSAiZGVjb2RlZCI/DQoNClRoZXknZCBnZXQgYSBub3QtaW1w bGVtZW50ZWQgZXhjZXB0aW9uLg0KDQpJIGRvbid0IHNlZSBob3cgd2UgY291 bGQgcHJldmVudCB0aGF0LCB0aG91Z2guICBJZiB3ZSBhZGRlZCBhbm90aGVy DQpyZWNvcmRpbmcgbWV0aG9kIHRoYXQgZGlkbid0IHByb3ZpZGUgb25lIG9m IHRoZSBmdW5jdGlvbnMgdGhlIG9sZA0KcmVjb3JkaW5nIG1ldGhvZCdzIGlu c3RydWN0aW9uIG9iamVjdCBwcm92aWRlZCwgaXQgd2lsbCBoYXZlIHRvIGZh aWwNCnNvbWVob3cuDQoNCkFuZCB3ZSBkb24ndCB3YW50IHNjcmlwdHMgdG8g cmVzdHJpY3QgdGhlbXNlbHZlcyB0byB0aGUgSW5zdHJ1Y3Rpb24NCmJhc2Ug Y2xhc3MuICBJZiB0aGV5IGFyZSB1c2luZyByZWNvcmQtYnRyYWNlIHdlIGRv IHdhbnQgdGhlbSB0byBnZXQNCnRoZSBzYWwgZnJvbSB0aGUgaW5zdHJ1Y3Rp b24gb2JqZWN0LCBmb3IgZXhhbXBsZS4NCg0KVGhhbmtzLA0KTWFya3VzLg0K DQpJbnRlbCBEZXV0c2NobGFuZCBHbWJIClJlZ2lzdGVyZWQgQWRkcmVzczog QW0gQ2FtcGVvbiAxMC0xMiwgODU1NzkgTmV1YmliZXJnLCBHZXJtYW55ClRl bDogKzQ5IDg5IDk5IDg4NTMtMCwgd3d3LmludGVsLmRlCk1hbmFnaW5nIERp cmVjdG9yczogQ2hyaXN0aW4gRWlzZW5zY2htaWQsIENocmlzdGlhbiBMYW1w cmVjaHRlcgpDaGFpcnBlcnNvbiBvZiB0aGUgU3VwZXJ2aXNvcnkgQm9hcmQ6 IE5pY29sZSBMYXUKUmVnaXN0ZXJlZCBPZmZpY2U6IE11bmljaApDb21tZXJj aWFsIFJlZ2lzdGVyOiBBbXRzZ2VyaWNodCBNdWVuY2hlbiBIUkIgMTg2OTI4 Cg== >From gdb-patches-return-137777-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Mar 23 16:19:36 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 103084 invoked by alias); 23 Mar 2017 16:19:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 102982 invoked by uid 89); 23 Mar 2017 16:19:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Mar 2017 16:19:34 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D92D46A6AD; Thu, 23 Mar 2017 16:19:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D92D46A6AD Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D92D46A6AD Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 917F582260; Thu, 23 Mar 2017 16:19:33 +0000 (UTC) Subject: Re: [PATCH] Remove some unnecessary inferior_ptid setting/restoring when fetching/storing registers To: Simon Marchi , gdb-patches@sourceware.org References: <20170322172919.26538-1-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: <8cc3a2c4-391a-c001-56f5-80f366096e3f@redhat.com> Date: Thu, 23 Mar 2017 16:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170322172919.26538-1-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00421.txt.bz2 Content-length: 1449 On 03/22/2017 05:29 PM, Simon Marchi wrote: > Now that the to_fetch_registers, to_store_registers and > to_prepare_to_store target methods don't rely on the value of > inferior_ptid anymore, we can remove a bunch of now unnecessary setting > and restoring of inferior_ptid. > > The asserts added recently in target_fetch_registers and > target_store_registers, which validate that inferior_ptid matches the > regcache's ptid, must go away. It's the whole point of this effort, to > not require inferior_ptid to have a particular value when calling these > functions. > > One thing that I noticed is how sol-thread.c's ps_lgetregs and friends > use the current value of inferior_ptid instead of what's passed as > argument (ph->ptid), unlike proc-service.c's versions of the same > functions. Is it expected? I left it like this in the current patch, > but unless there's a good reason for it to be that way, I guess we > should make it use the parameter. Probably no good reason. > > gdb/ChangeLog: > > * fbsd-tdep.c (fbsd_corefile_thread): Don't set/restore > inferior_ptid. > * proc-service.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, > ps_lsetfpregs): Likewise. > * regcache.c (regcache_raw_update, regcache_raw_write): Likewise. > * sol-thread.c (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, > ps_lsetfpregs): Likewise. > * target.c (target_fetch_registers, target_store_registers): > Remove asserts. LGTM. Thanks, Pedro Alves