From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67627 invoked by alias); 31 Jan 2017 16:06:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67476 invoked by uid 89); 31 Jan 2017 16:06:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_05,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=disconnect, mmetzger, enableexp, UD:enable.exp X-HELO: mga05.intel.com Received: from mga05.intel.com (HELO mga05.intel.com) (192.55.52.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Jan 2017 16:06:47 +0000 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 31 Jan 2017 08:06:46 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga004.fm.intel.com with ESMTP; 31 Jan 2017 08:06:45 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.142]) by IRSMSX102.ger.corp.intel.com ([169.254.2.230]) with mapi id 14.03.0248.002; Tue, 31 Jan 2017 16:06:45 +0000 From: "Metzger, Markus T" To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [PATCH v3 5/5] btrace, testsuite: fix extended-remote fail Date: Tue, 31 Jan 2017 16:06:00 -0000 Message-ID: References: <1485770743-6603-1-git-send-email-markus.t.metzger@intel.com> <1485770743-6603-6-git-send-email-markus.t.metzger@intel.com> <217e1c28-070a-f485-aa06-a91f69c31023@redhat.com> In-Reply-To: <217e1c28-070a-f485-aa06-a91f69c31023@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00672.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Tuesday, January 31, 2017 2:00 PM > To: Metzger, Markus T ; gdb- > patches@sourceware.org > Subject: Re: [PATCH v3 5/5] btrace, testsuite: fix extended-remote fail >=20 > On 01/30/2017 10:05 AM, Markus Metzger wrote: > > Parts of gdb.btrace/enable.exp are only valid for native debug. The ch= eck for > > skip_gdbserver_tests is done while GDB is running, though, which causes= it to > > fail with --target_board=3Dnative-extended-gdbserver. Exit GDB before = that > check. > > >=20 > Can you clarify how it fails? It's not obvious to me from looking at > skip_gdbserver_tests. spawn /nfs/site/disks/idb_team/mmetzger/gdb/build/ulll001/gdb/testsuite/../= gdbserver/gdbserver --once --multi :2349 Listening on port 2349 target extended-remote localhost:2349 Already connected to a remote target. Disconnect? (y or n) ^CQuit (gdb) set tdesc filename /nfs/site/disks/idb_team/mmetzger/gdb/build/ulll00= 1/gdb/testsuite/outputs/gdb.btrace/enable/tri vial.xml (gdb) n The program is not being run. (gdb) FAIL: gdb.btrace/enable.exp: set tdesc filename /nfs/site/disks/idb_t= eam/mmetzger/gdb/build/ulll001/gdb/testsuite/outputs/gdb.btrace/enable/triv= ial.xml (got interactive prompt) monitor exit There's a comment in lib/gdb.exp before gdb_skip_xml_test, which is called by skip_gdbserver_tests: # Return true if a test should be skipped due to lack of XML support # in the host GDB. # NOTE: This must be called while gdb is *not* running. gdb_caching_proc gdb_skip_xml_test { I thought this is supposed to be general knowledge so I didn't bother to go= into more detail in the commit message. > Should we add something like: >=20 > global gdb_spawn_id > if {[info exists gdb_spawn_id]} { > error "....." > return > } >=20 > ... to skip_gdbserver_tests ? That would certainly make it more obvious: Running .../gdb.btrace/enable.exp ... ERROR: tcl error sourcing .../gdb.btrace/enable.exp. ERROR: GDB must not be running in skip_gdbserver_tests. while executing "error "GDB must not be running in skip_gdbserver_tests."" (procedure "skip_gdbserver_tests" line 9) invoked from within "skip_gdbserver_tests" invoked from within "if [skip_gdbserver_tests] { unsupported "target does not support gdbserver" return 0 }" (file ".../gdb.btrace/enable.exp" line 83) invoked from within "source .../gdb.btrace/enable.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source /.../gdb.btrace/enable.exp" invoked from within "catch "uplevel #0 source $test_file_name"" Looks like we don't need the return, though. And the check should probably go into skip_xml_tests. Let me add a separate patch for this. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928