From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50037 invoked by alias); 29 Nov 2016 15:48:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49971 invoked by uid 89); 29 Nov 2016 15:48:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=approve, Tel, tel, office X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 15:48:33 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 29 Nov 2016 07:48:31 -0800 X-ExtLoop1: 1 Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 29 Nov 2016 07:48:30 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.52]) by IRSMSX152.ger.corp.intel.com ([169.254.6.78]) with mapi id 14.03.0248.002; Tue, 29 Nov 2016 15:48:30 +0000 From: "Metzger, Markus T" To: "Wiederhake, Tim" , "gdb-patches@sourceware.org" CC: "palves@redhat.com" Subject: RE: [PATCH v3 7/8] python: Add tests for record Python bindings Date: Tue, 29 Nov 2016 15:48:00 -0000 Message-ID: References: <1479743318-24523-1-git-send-email-tim.wiederhake@intel.com> <1479743318-24523-8-git-send-email-tim.wiederhake@intel.com> In-Reply-To: <1479743318-24523-8-git-send-email-tim.wiederhake@intel.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00957.txt.bz2 > -----Original Message----- > From: Wiederhake, Tim > Sent: Monday, November 21, 2016 4:49 PM > To: gdb-patches@sourceware.org > Cc: palves@redhat.com; Metzger, Markus T > Subject: [PATCH v3 7/8] python: Add tests for record Python bindings >=20 > 2016-11-21 Tim Wiederhake >=20 > gdb/testsuite/ChangeLog: >=20 > * gdb.python/py-record-btrace.c: New file. > * gdb.python/py-record-btrace.exp: New file. The tests cover start/stop for record-full. Would it make sense to move them to a separate test file? > +with_test_prefix "preopened record full" { > + gdb_test_no_output "record full" > + gdb_test "python print(gdb.current_recording().method)" "full" > + gdb_test "python print(gdb.current_recording().format)" "full" The "info record" command does not list a format for method "full". IIRC we don't return None so in this regard, "full" is certainly better than "unknown". The patch looks good to me but we need to find a maintainer to approve it. thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928