From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44207 invoked by alias); 29 Nov 2016 15:47:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44196 invoked by uid 89); 29 Nov 2016 15:47:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1163, Tel, tel, office X-HELO: mga14.intel.com Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Nov 2016 15:47:16 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP; 29 Nov 2016 07:47:04 -0800 X-ExtLoop1: 1 Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga006.fm.intel.com with ESMTP; 29 Nov 2016 07:47:03 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 29 Nov 2016 15:47:03 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.52]) by irsmsx111.ger.corp.intel.com ([169.254.2.55]) with mapi id 14.03.0248.002; Tue, 29 Nov 2016 15:47:03 +0000 From: "Metzger, Markus T" To: "Wiederhake, Tim" , "gdb-patches@sourceware.org" CC: "palves@redhat.com" Subject: RE: [PATCH v3 2/8] btrace: Export btrace_decode_error function. Date: Tue, 29 Nov 2016 15:47:00 -0000 Message-ID: References: <1479743318-24523-1-git-send-email-tim.wiederhake@intel.com> <1479743318-24523-3-git-send-email-tim.wiederhake@intel.com> In-Reply-To: <1479743318-24523-3-git-send-email-tim.wiederhake@intel.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00952.txt.bz2 > -----Original Message----- > From: Wiederhake, Tim > Sent: Monday, November 21, 2016 4:49 PM > To: gdb-patches@sourceware.org > Cc: palves@redhat.com; Metzger, Markus T > Subject: [PATCH v3 2/8] btrace: Export btrace_decode_error function. >=20 > 2016-11-21 Tim Wiederhake >=20 > gdb/ChangeLog: >=20 > * record-btrace.c (btrace_ui_out_decode_error): Move most of it ... > * btrace.c (btrace_decode_error): ... here. New function. > * btrace.h (btrace_decode_error): New export. > +const char * > +btrace_decode_error (enum btrace_format format, int errcode) > +{ > + switch (format) > + { > + case BTRACE_FORMAT_BTS: The { is indented and thus goes onto the same column than the case. Looks good to me, otherwise. Thanks, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928