From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100630 invoked by alias); 28 Oct 2016 07:11:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100616 invoked by uid 89); 28 Oct 2016 07:11:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=supervisory, lau, Lau, Tel X-HELO: mga06.intel.com Received: from mga06.intel.com (HELO mga06.intel.com) (134.134.136.31) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Oct 2016 07:10:52 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 28 Oct 2016 00:10:51 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga003.jf.intel.com with ESMTP; 28 Oct 2016 00:10:19 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.49]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002; Fri, 28 Oct 2016 08:10:18 +0100 From: "Metzger, Markus T" To: Pedro Alves , Yao Qi CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 0/5] improve trace gap handling Date: Fri, 28 Oct 2016 07:11:00 -0000 Message-ID: References: <1469175120-19657-1-git-send-email-markus.t.metzger@intel.com> <8637ji83dd.fsf@gmail.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00780.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBQZWRybyBB bHZlcyBbbWFpbHRvOnBhbHZlc0ByZWRoYXQuY29tXQ0KPiBTZW50OiBUaHVy c2RheSwgT2N0b2JlciAyNywgMjAxNiA1OjExIFBNDQo+IFRvOiBZYW8gUWkg PHFpeWFvbHRjQGdtYWlsLmNvbT47IE1ldHpnZXIsIE1hcmt1cyBUDQo+IDxt YXJrdXMudC5tZXR6Z2VyQGludGVsLmNvbT4NCj4gQ2M6IGdkYi1wYXRjaGVz QHNvdXJjZXdhcmUub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMC81XSBp bXByb3ZlIHRyYWNlIGdhcCBoYW5kbGluZw0KPiANCj4gT24gMTAvMjcvMjAx NiAwNDowMyBQTSwgWWFvIFFpIHdyb3RlOg0KPiA+IE9uIFRodSwgT2N0IDI3 LCAyMDE2IGF0IDE6MzkgUE0sIE1ldHpnZXIsIE1hcmt1cyBUDQo+ID4gPG1h cmt1cy50Lm1ldHpnZXJAaW50ZWwuY29tPiB3cm90ZToNCj4gPj4NCj4gPj4g RG9uJ3Qgd2Ugd2FudCBwYXRjaGVzIHRvIGJlIHBlZXIgcmV2aWV3ZWQgaW4g Z2VuZXJhbD8gIE9yIGFyZSB5b3UNCj4gPj4gc2F5aW5nIHRoYXQgSSBjYW4g YW5kIHNob3VsZCBtYWtlIGNoYW5nZXMgdG8gcmVjb3JkLWJ0cmFjZSB3aXRo b3V0DQo+ID4+IHJldmlldz8NCj4gPg0KPiA+IE5vLCBJIGFtIG5vdCBzYXlp bmcgdGhhdC4uLiA6LSkgIFBlZXIgcmV2aWV3IGlzIGFsd2F5cyB3ZWxjb21l LiAgQXMgd2UNCj4gPiBzYWlkIGluIE1BSU5UQUlORVJTOg0KPiA+DQo+ID4g IkFsbCBtYWludGFpbmVycyBhcmUgZW5jb3VyYWdlZCB0byBwb3N0IG1ham9y IHBhdGNoZXMgdG8gdGhlIGdkYi1wYXRjaGVzDQo+ID4gbWFpbGluZyBsaXN0 IGZvciBjb21tZW50cywgZXZlbiBpZiB0aGV5IGhhdmUgdGhlIGF1dGhvcml0 eSB0byBjb21taXQgdGhlDQo+ID4gcGF0Y2ggd2l0aG91dCByZXZpZXcgZnJv bSBhbm90aGVyIG1haW50YWluZXIuIg0KPiA+DQo+ID4gWW91LCBhcyBhICJy ZXNwb25zaWJsZSBtYWludGFpbmVyIiBmb3IgYnRyYWNlLCBjYW4vc2hvdWxk IHJldmlldyBhbGwNCj4gPiBwYXRjaGVzIGluIHRoZSBhcmVhIG9mIGJ0cmFj ZSwgaW5jbHVkaW5nIHBhdGNoZXMgd3JpdHRlbiBieSB5b3Vyc2VsZi4NCj4g Pg0KPiA+IEkgdGhpbmsgYWxsIHRoZXNlIHJ1bGVzIGFyZSBvZiBhIHB1cnBv c2Ugb2YgaGF2aW5nIGEgaGVhbHRoeSBjb2RlIGJhc2UNCj4gPiB3aXRoIGFu IGVmZmljaWVudCB3YXkuICBJdCBoZWxwcyBub3RoaW5nIHRvIGJsb2NrIHBh dGNoZXMgZm9yIHRocmVlDQo+ID4gbW9udGhzIGR1ZSB0byBsYWNrIG9mIHBl ZXIgcmV2aWV3Lg0KPiA+DQo+ID4gWW91IG11c3QgcG9zdCB5b3VyIHBhdGNo ZXMgZm9yIHJldmlldywgYW5kIHlvdSBoYXZlIHRoZSBhdXRob3JpdHkNCj4g PiB0byBhcHByb3ZlIHRoZSBidHJhY2UgYml0cy4gIFlvdSBjYW4gbGVhdmUg eW91ciBwYXRjaGVzIGZvciBhIHBlcmlvZA0KPiA+IG9mIHRpbWUsIG9uZSB3 ZWVrIGZvciBleGFtcGxlLCBpbiBtYWlsIGxpc3QgdG8gY29sbGVjdCBjb21t ZW50cyBhbmQNCj4gPiBvYmplY3Rpb25zLg0KPiA+DQo+IA0KPiBJIGRlZmlu aXRlbHkgYWdyZWUuICBJdCdzIGJlY2F1c2Ugd2UgdHJ1c3QgeW91IGFuZCB0 aGluayB5b3UncmUNCj4gY29tcGV0ZW50IHRoYXQgd2UgbWFkZSB5b3UgYnRy YWNlIG1haW50YWluZXIuICA6LSkNCj4gDQo+IEZXSVcsIEkndmUgcXVpY2ts eSBza2ltbWVkIHRoZSBwYXRjaGVzIG5vdyBsb29raW5nIGZvciBzb21ldGhp bmcNCj4gdGhhdCBJIG1pZ2h0IGV2ZW4gaGF2ZSBpbnB1dCBvbiwgYW5kIEkg Zm91bmQgbm90aGluZy4gIFJlZ2FyZGluZw0KPiBzdHlsZSBhbmQgZm9sbG93 aW5nIEdEQiBwcmFjdGljZXMsIEkgdGhpbmsgeW91ciBwYXRjaGVzIGFyZQ0K PiBjb25zaXN0ZW50bHkgcGVyZmVjdC4NCg0KT0ssIHRoYW5rcy4gIFRoZW4g SSdtIGdvaW5nIHRvIHNlbGYtYXBwcm92ZSB0aGlzIHBhdGNoIHNlcmllcy4g IFRoYW5rcywNClBlZHJvLCBmb3Igc2tpbW1pbmcgb3ZlciBpdC4gIEkgaGF2 ZSBhbm90aGVyIHNtYWxsIGZpeCBJJ20gZ29pbmcgdG8gcG9zdA0KZm9yIGEg d2VlayBvciB0d28gLSBpdCdzIGFsbW9zdCBvYnZpb3VzLg0KDQpUaGUgb3Ro ZXIgcGF0Y2ggc2VyaWVzIEkgaGF2ZSBwb3N0ZWQgc29tZSB0aW1lIGFnbyBj b250YWlucyBjaGFuZ2VzDQp0byBpbmZydW4sIHJlY29yZCAoZnVsbCksIGFu ZCB0aGUgTUkgdGVzdCBzdWl0ZS4gIEl0IGdlbmVyYWxseSBpbXBhY3RzIHRo ZQ0KYmVoYXZpb3Igb2YgTUkuICBJJ20gZ29pbmcgdG8gcGluZyB0aGlzIG9u ZSBhZ2Fpbi4NCg0KUmVnYXJkcywNCk1hcmt1cy4NCg0KSW50ZWwgRGV1dHNj aGxhbmQgR21iSApSZWdpc3RlcmVkIEFkZHJlc3M6IEFtIENhbXBlb24gMTAt MTIsIDg1NTc5IE5ldWJpYmVyZywgR2VybWFueQpUZWw6ICs0OSA4OSA5OSA4 ODUzLTAsIHd3dy5pbnRlbC5kZQpNYW5hZ2luZyBEaXJlY3RvcnM6IENocmlz dGluIEVpc2Vuc2NobWlkLCBDaHJpc3RpYW4gTGFtcHJlY2h0ZXIKQ2hhaXJw ZXJzb24gb2YgdGhlIFN1cGVydmlzb3J5IEJvYXJkOiBOaWNvbGUgTGF1ClJl Z2lzdGVyZWQgT2ZmaWNlOiBNdW5pY2gKQ29tbWVyY2lhbCBSZWdpc3Rlcjog QW10c2dlcmljaHQgTXVlbmNoZW4gSFJCIDE4NjkyOAo= >From gdb-patches-return-134370-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Oct 28 08:47:31 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 68556 invoked by alias); 28 Oct 2016 08:47:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 68535 invoked by uid 89); 28 Oct 2016 08:47:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=phil X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Oct 2016 08:47:27 +0000 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9S8i2bd046812 for ; Fri, 28 Oct 2016 04:47:25 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0b-001b2d01.pphosted.com with ESMTP id 26c3710mkd-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 28 Oct 2016 04:47:25 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Oct 2016 09:47:23 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp15.uk.ibm.com (192.168.101.145) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 28 Oct 2016 09:47:21 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 7A21217D805D for ; Fri, 28 Oct 2016 09:49:36 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9S8lK6Q13369778 for ; Fri, 28 Oct 2016 08:47:20 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9S8lK0d002900 for ; Fri, 28 Oct 2016 02:47:20 -0600 Received: from ThinkPad (dyn-9-152-212-68.boeblingen.de.ibm.com [9.152.212.68]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u9S8lJhG002890; Fri, 28 Oct 2016 02:47:20 -0600 Date: Fri, 28 Oct 2016 08:47:00 -0000 From: Philipp Rudo To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: Require C++11 In-Reply-To: <1477596094-3244-3-git-send-email-palves@redhat.com> References: <1477596094-3244-1-git-send-email-palves@redhat.com> <1477596094-3244-3-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16102808-0020-0000-0000-0000026B4F46 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16102808-0021-0000-0000-00003EC99F05 Message-Id: <20161028104718.540c10ed@ThinkPad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-28_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610280154 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00781.txt.bz2 Content-length: 894 Hi Pedro On Thu, 27 Oct 2016 20:21:34 +0100 Pedro Alves wrote: > diff --git a/gdb/configure b/gdb/configure > index e2d853d..d744f73 100755 > --- a/gdb/configure > +++ b/gdb/configure [...] > @@ -4951,6 +4953,984 @@ ac_script='s/[\\$]/&&/g;s/;s,x,x,$//' [...] > +// If the compiler admits that it is not ready for C++11, why > torture it? > +// Hopefully, this will speed up the test. > + > +#ifndef __cplusplus > + > +#error "This is not a C++ compiler" > + > +#elif __cplusplus < 201103L > + > +#error "This is not a C++11 compiler" > + > +#else > + > +namespace cxx11 > +{ [...] > +} // namespace cxx11 > + > +#endif // __cplusplus >= 201103L Without knowing much about autoconf. But you are repeating those exact 280 lines a total of 6 times in this patch. Isn't there a nicer way? Like moving it to a function? It would make the path significantly shorter. Phil