From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100178 invoked by alias); 6 Jun 2016 14:02:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100168 invoked by uid 89); 6 Jun 2016 14:02:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=as-is, commercial, Tel, tel X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jun 2016 14:02:40 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 06 Jun 2016 07:02:38 -0700 X-ExtLoop1: 1 Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga002.jf.intel.com with ESMTP; 06 Jun 2016 07:02:37 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 6 Jun 2016 15:02:37 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.117]) by IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0248.002; Mon, 6 Jun 2016 15:02:36 +0100 From: "Metzger, Markus T" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Add method/format information to =record-started Date: Mon, 06 Jun 2016 14:02:00 -0000 Message-ID: References: <20160603155220.22286-1-simon.marchi@ericsson.com> <57557571.7040200@ericsson.com> <57557D26.2080009@ericsson.com> <57557F4D.8020409@ericsson.com> In-Reply-To: <57557F4D.8020409@ericsson.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00094.txt.bz2 > -----Original Message----- > From: Simon Marchi [mailto:simon.marchi@ericsson.com] > Sent: Monday, June 6, 2016 3:49 PM > To: Metzger, Markus T ; gdb- > patches@sourceware.org > Subject: Re: [PATCH] Add method/format information to =3Drecord-started > From ce80ad77f163700e51c1e640ceb933b33ca1d280 Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Mon, 30 May 2016 17:29:39 -0400 > Subject: [PATCH] Add method/format information to =3Drecord-started >=20 > Eclipse CDT now supports enabling execution recording using two methods > (full and btrace) and both formats for btrace (bts and pt). In the > event that recording is enabled behind the back of the GUI (by the user > on the command line, or a script), we need to know which method/format > are being used, so it can be correctly reflected in the interface. This > patch adds this information to the =3Drecord-started async record. >=20 > Before: >=20 > =3Drecord-started,thread-group=3D"i1" >=20 > After: >=20 > =3Drecord-started,thread-group=3D"i1",method=3D"btrace",format=3D"bts" > =3Drecord-started,thread-group=3D"i1",method=3D"btrace",format=3D"pt" > =3Drecord-started,thread-group=3D"i1",method=3D"full" >=20 > The "format" field is only present when the current method supports > multiple formats (only the btrace method as of now). The btrace bits look good to me. I'm wondering if we want the short or the long form of the format. If we expect MI front-ends to just print it as-is, the long form may be more usef= ul. That's also what's printed by "info record". I'm fine either way. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928