From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103261 invoked by alias); 6 Jun 2016 13:20:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103247 invoked by uid 89); 6 Jun 2016 13:20:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=U*patches X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jun 2016 13:20:37 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 06 Jun 2016 06:20:35 -0700 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 06 Jun 2016 06:20:34 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.117]) by IRSMSX153.ger.corp.intel.com ([169.254.9.105]) with mapi id 14.03.0248.002; Mon, 6 Jun 2016 14:20:33 +0100 From: "Metzger, Markus T" To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Add method/format information to =record-started Date: Mon, 06 Jun 2016 13:20:00 -0000 Message-ID: References: <20160603155220.22286-1-simon.marchi@ericsson.com> <57557571.7040200@ericsson.com> In-Reply-To: <57557571.7040200@ericsson.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00082.txt.bz2 > -----Original Message----- > From: Simon Marchi [mailto:simon.marchi@ericsson.com] > Sent: Monday, June 6, 2016 3:07 PM > To: Metzger, Markus T ; gdb- > patches@sourceware.org > Subject: Re: [PATCH] Add method/format information to =3Drecord-started Hi Simon, Please see Yao's reply regarding formatting. > >> @@ -234,7 +235,8 @@ record_btrace_open (const char *args, int from_tty) > >> NULL); > >> record_btrace_generating_corefile =3D 0; > >> > >> - observer_notify_record_changed (current_inferior (), 1); > >> + format =3D record_btrace_conf.format =3D=3D BTRACE_FORMAT_PT ? "pt"= : "bts"; > > > > I'd use a switch here and not assume that format !=3D pt means bts. If= we added > > another format (LBR maybe?) we might miss this. >=20 > You're right. What do you think of adding a convenience function like th= is? >=20 >=20 > diff --git a/gdb/common/btrace-common.c b/gdb/common/btrace-common.c > index eba3979..ebf3ed2 100644 > --- a/gdb/common/btrace-common.c > +++ b/gdb/common/btrace-common.c > @@ -43,6 +43,23 @@ btrace_format_string (enum btrace_format format) >=20 > /* See btrace-common.h. */ >=20 > +const char * > +btrace_format_short_string (enum btrace_format format) > +{ > + switch (format) > + { > + case BTRACE_FORMAT_BTS: > + return "bts"; > + > + case BTRACE_FORMAT_PT: > + return "pt"; > + } > + > + internal_error (__FILE__, __LINE__, _("Unknown branch trace format")); > +} > + > +/* See btrace-common.h. */ > + > void > btrace_data_init (struct btrace_data *data) > { > diff --git a/gdb/common/btrace-common.h b/gdb/common/btrace-common.h > index ad208cd..ba707a2 100644 > --- a/gdb/common/btrace-common.h > +++ b/gdb/common/btrace-common.h > @@ -214,6 +214,10 @@ enum btrace_error > /* Return a string representation of FORMAT. */ > extern const char *btrace_format_string (enum btrace_format format); >=20 > +/* Return a short abbreviation string of FORMAT. FORMAT can have the va= lue > + BTRACE_FORMAT_NONE. */ > +extern const char *btrace_format_short_string (enum btrace_format format= ); Looks good except that BTRACE_FORMAT_NONE is not handled in the switch. We could leave it as a bad format string to be detected by the MI consumer.= This would leave the short and long versions of btrace_format_string symmetric. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928