From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75047 invoked by alias); 12 May 2016 13:45:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74620 invoked by uid 89); 12 May 2016 13:45:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=U*gdb-patches, gdb-patches@sourceware.org, gdbpatchessourcewareorg, sk:gdb-pat X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 May 2016 13:44:54 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 12 May 2016 06:44:54 -0700 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 12 May 2016 06:44:52 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 12 May 2016 14:44:46 +0100 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.226]) by irsmsx111.ger.corp.intel.com ([169.254.2.233]) with mapi id 14.03.0248.002; Thu, 12 May 2016 14:44:46 +0100 From: "Metzger, Markus T" To: Yao Qi CC: "gdb-patches@sourceware.org" , "palves@redhat.com" , "ak@linux.intel.com" , "jan.kratochvil@redhat.com" Subject: RE: [PATCH] record: automatically start recording Date: Thu, 12 May 2016 13:45:00 -0000 Message-ID: References: <1459866845-28423-1-git-send-email-markus.t.metzger@intel.com> <8637pnctbv.fsf@gmail.com> In-Reply-To: <8637pnctbv.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00198.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBZYW8gUWkg W21haWx0bzpxaXlhb2x0Y0BnbWFpbC5jb21dDQo+IFNlbnQ6IFRodXJzZGF5 LCBNYXkgMTIsIDIwMTYgMzoxNCBQTQ0KPiBUbzogTWV0emdlciwgTWFya3Vz IFQgPG1hcmt1cy50Lm1ldHpnZXJAaW50ZWwuY29tPg0KPiBDYzogZ2RiLXBh dGNoZXNAc291cmNld2FyZS5vcmc7IHBhbHZlc0ByZWRoYXQuY29tOyBha0Bs aW51eC5pbnRlbC5jb207DQo+IGphbi5rcmF0b2NodmlsQHJlZGhhdC5jb20N Cj4gU3ViamVjdDogUmU6IFtQQVRDSF0gcmVjb3JkOiBhdXRvbWF0aWNhbGx5 IHN0YXJ0IHJlY29yZGluZw0KDQpIaSBZYW8sDQoNClRoYW5rcyBmb3IgeW91 ciByZXZpZXcuICBJIGNoYW5nZWQgdGhlIHRlc3QgdG8gdXNlICJyZWNvcmQg ZnVsbCIgYW5kIG1vdmVkIGl0DQppbnRvIHRlc3RzdWl0ZS9nZGIucmV2ZXJz ZS4NCg0KDQo+ID4gSXMgdGhlIGFkZGVkIGNvbnZlbmllbmNlIHdvcnRoIGEg bmV3IG9wdGlvbiBvciBkbyB3ZSB3YW50IHRvIHBvaW50IHVzZXJzIHRvDQo+ IHRoZQ0KPiA+IGJyZWFrcG9pbnQtY29tbWFuZCBzb2x1dGlvbj8NCj4gPg0K PiANCj4gSSBkb24ndCB0aGluayBpdCBjYW4ganVzdGlmeSBhZGRpbmcgYSBv cHRpb24gaW4gR0RCIHRvIGRvIHRoYXQsIGJ1dCBJIGFtDQo+IG9wZW4gdG8g b3RoZXJzJyB0aG91Z2h0LiAgSWYgcGVvcGxlIHRoaW5rIGl0IGlzIHVzZWZ1 bCB0byBoYXZlIHN1Y2gNCj4gb3B0aW9uLCBzZWUgbXkgY29tbWVudHMgYmVs b3cgb24gdGhlIHBhdGNoLA0KDQpJIGdldCBzdWNoIGEgcmVxdWVzdCBvbmNl IGluIGEgd2hpbGUgYnV0IEknbSBub3Qgc3VyZSBhYm91dCB0aGlzIG15c2Vs Zi4NCkxldCdzIGhlYXIgd2hhdCBvdGhlcnMgdGhpbmsuDQoNClJlZ2FyZHMs DQpNYXJrdXMuDQoNCkludGVsIERldXRzY2hsYW5kIEdtYkgKUmVnaXN0ZXJl ZCBBZGRyZXNzOiBBbSBDYW1wZW9uIDEwLTEyLCA4NTU3OSBOZXViaWJlcmcs IEdlcm1hbnkKVGVsOiArNDkgODkgOTkgODg1My0wLCB3d3cuaW50ZWwuZGUK TWFuYWdpbmcgRGlyZWN0b3JzOiBDaHJpc3RpbiBFaXNlbnNjaG1pZCwgQ2hy aXN0aWFuIExhbXByZWNodGVyCkNoYWlycGVyc29uIG9mIHRoZSBTdXBlcnZp c29yeSBCb2FyZDogTmljb2xlIExhdQpSZWdpc3RlcmVkIE9mZmljZTogTXVu aWNoCkNvbW1lcmNpYWwgUmVnaXN0ZXI6IEFtdHNnZXJpY2h0IE11ZW5jaGVu IEhSQiAxODY5MjgK >From gdb-patches-return-131493-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu May 12 14:03:44 2016 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 110484 invoked by alias); 12 May 2016 14:03:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 110474 invoked by uid 89); 12 May 2016 14:03:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1693, H*r:0400, cancelled X-HELO: usplmg20.ericsson.net Received: from usplmg20.ericsson.net (HELO usplmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 12 May 2016 14:03:38 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usplmg20.ericsson.net (Symantec Mail Security) with SMTP id 78.4C.09012.44584375; Thu, 12 May 2016 15:29:41 +0200 (CEST) Received: from elxa4wqvvz1 (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.84) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 12 May 2016 10:03:34 -0400 References: <1462530736-25117-1-git-send-email-yao.qi@linaro.org> <1462530736-25117-3-git-send-email-yao.qi@linaro.org> <8660ukev20.fsf@gmail.com> User-agent: mu4e 0.9.17; emacs 24.4.1 From: Antoine Tremblay To: Yao Qi CC: Subject: Re: [RFC 2/3] use reinsert breakpoint for vCont;s In-Reply-To: <8660ukev20.fsf@gmail.com> Date: Thu, 12 May 2016 14:03:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00199.txt.bz2 Content-length: 1754 Yao Qi writes: > Yao Qi writes: > >> + >> + if (!step_over_finished && !can_hardware_single_step ()) >> + { >> + /* If the thread resumed by resume_step hits the reinsert >> + breakpoint, delete the reinsert breakpoint for it. */ >> + if (current_thread->last_resume_kind == resume_step) >> + delete_reinsert_breakpoints (current_thread); >> + else >> + { >> + /* If the thread resumed by other kind, like >> + resume_continue, hits the breakpoint (either >> + reinsert breakpoint or GDB breakpoint), delete >> + all reinsert breakpoints if it hits non-reinsert >> + breakpoints, otherwise, leave reinsert breakpoint there >> + and step over it. */ >> + if (non_reinsert_breakpoint_inserted_here (event_child->stop_pc)) >> + delete_reinsert_breakpoints (NULL); >> + } >> + } >> } >> else >> { >> /* We have some other signal, possibly a step-over dance was in >> progress, and it should be cancelled too. */ >> step_over_finished = finish_step_over (event_child); >> + >> + if (!step_over_finished && !can_hardware_single_step ()) >> + delete_reinsert_breakpoints (NULL); >> } >> >> /* We have all the data we need. Either report the event to GDB, or >> @@ -3568,6 +3590,8 @@ linux_wait_1 (ptid_t ptid, >> >> /* Alright, we're going to report a stop. */ >> >> + delete_reinsert_breakpoints (NULL); >> + > > The SIGILL is caused by removing these reinsert breakpoints when threads > are still running. I adjust the code removing reinsert breakpoints when > threads stop, the SIGILL goes away. I though we would have to explicitly stop the threads, I'm curious has to where you moved it so that the threads are stopped ?