From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Luis Machado <lgustavo@codesourcery.com>,
Leonardo Boquillon <leonardo.boquillon@tallertechnologies.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"daniel.gutson@tallertechnologies.com"
<daniel.gutson@tallertechnologies.com>
Subject: RE: [PATCH v4] Fix alignment of disassemble /r
Date: Tue, 12 Apr 2016 07:23:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B23332A7B02@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <570C0703.9060100@codesourcery.com>
> -----Original Message-----
> From: Luis Machado [mailto:lgustavo@codesourcery.com]
> Sent: Monday, April 11, 2016 10:20 PM
> To: Leonardo Boquillon <leonardo.boquillon@tallertechnologies.com>; gdb-
> patches@sourceware.org; daniel.gutson@tallertechnologies.com; Metzger,
> Markus T <markus.t.metzger@intel.com>
> Subject: Re: [PATCH v4] Fix alignment of disassemble /r
> > +{
> > + int longest_opcode = 0;
> > + unsigned int insn_checked = 0;
>
> Shouldn't longest_opcode be unsigned int since some of the other
> variables are also being forced to unsigned?
I suggested signed int previously to avoid signed-unsigned conversions
when computing longest_opcode from gdb_insn_length ().
> > + const int current_length = gdb_insn_length(gdbarch, addr);
> > + longest_opcode =
> > + (current_length > longest_opcode) ? current_length : longest_opcode;
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2016-04-12 7:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 14:16 Leonardo Boquillon
2016-04-11 20:20 ` Luis Machado
2016-04-12 7:23 ` Metzger, Markus T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B23332A7B02@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=daniel.gutson@tallertechnologies.com \
--cc=gdb-patches@sourceware.org \
--cc=leonardo.boquillon@tallertechnologies.com \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox