From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Pedro Alves <palves@redhat.com>,
"brobecker@adacore.com" <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [patch for 7.11] btrace: fix PR gdb/19829
Date: Thu, 17 Mar 2016 10:22:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B233327CF21@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <56EA81D5.10007@redhat.com>
> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Thursday, March 17, 2016 11:07 AM
> To: Metzger, Markus T <markus.t.metzger@intel.com>;
> brobecker@adacore.com
> Cc: gdb-patches@sourceware.org
> Subject: Re: [patch for 7.11] btrace: fix PR gdb/19829
>
> On 03/17/2016 07:48 AM, Markus Metzger wrote:
> > This is a backport of
>
> It's fine with me to put this in the branch.
Should I wait for Joel's OK, as well?
> (I'd have cherry picked the commits as individual commits instead of
> squashing them.)
There were no conflicts to resolve - other than ChangeLog, of course. If it
makes a difference I can cherry-pick them again and push a 3-commit series.
> > 2f3ef606b91298855e9ea13ae0e0316c23f06c9b
> > a038fa3e14a477d4d72a26c2e139fa47d2774be2
> > 33b4777ca1b7b456af8201b98eda27d1b272cbab
>
> (
> When referring to previous commits, I find it nicer to also include the
> commit's subject. The current lkml/git practice when referring to previous
> commits I believe is to put the subject in parens, though I can't find the
> reference right now. Like:
>
> 2f3ef606b912 (frame: add skip_tailcall_frames)
> a038fa3e14a4 (stack: check frame_unwind_caller_id)
> 33b4777ca1b7 (btrace, frame: fix crash in get_frame_type)
> )
Changed this to "git log --oneline"'s output:
33b4777 btrace, frame: fix crash in get_frame_type
a038fa3 stack: check frame_unwind_caller_id
2f3ef60 frame: add skip_tailcall_frames
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2016-03-17 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 7:48 Markus Metzger
2016-03-17 10:07 ` Pedro Alves
2016-03-17 10:22 ` Metzger, Markus T [this message]
2016-03-17 10:34 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B233327CF21@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox