From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47813 invoked by alias); 11 Feb 2016 16:07:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45352 invoked by uid 89); 11 Feb 2016 16:07:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1712, commercial, Tel, office X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Feb 2016 16:07:48 +0000 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 11 Feb 2016 08:07:47 -0800 X-ExtLoop1: 1 Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by FMSMGA003.fm.intel.com with ESMTP; 11 Feb 2016 08:07:46 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.210]) by IRSMSX154.ger.corp.intel.com ([169.254.12.208]) with mapi id 14.03.0248.002; Thu, 11 Feb 2016 16:06:14 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 3/3] btrace, frame: fix crash in get_frame_type Date: Thu, 11 Feb 2016 16:07:00 -0000 Message-ID: References: <1454681922-2228-1-git-send-email-markus.t.metzger@intel.com> <1454681922-2228-3-git-send-email-markus.t.metzger@intel.com> <56B9D620.2020104@redhat.com> <56BA61C6.8060807@redhat.com> <56BB0A0D.80502@redhat.com> <56BB5872.2000604@redhat.com> <56BC8EF0.4000202@redhat.com> <56BCAF8D.8030303@redhat.com> In-Reply-To: <56BCAF8D.8030303@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00359.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Thursday, February 11, 2016 4:58 PM > To: Metzger, Markus T > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH v2 3/3] btrace, frame: fix crash in get_frame_type > >> If we don't know where the caller is, we can't skip the resolver in > >> one go, so best to do is probably to return 0, and let infrun's > >> stepping logic continue single-stepping. > > > > You think we should add the check nevertheless in gdb/glibc-tdep.c? >=20 > Let's leave it be. If may be that the use case that trips on it would be= best > fixed differently. >=20 > > > > The others I won't be able to test. I could do the changes and rely > > on buildbot to flag issues. If we really want to change them. >=20 > I don't think we should change the others without evidence that they'd ne= ed > it. > If we do trip on problems on those, I think the fix should be elsewhere. >=20 > I'd still early in the release cycle, let's wait and see. OK. I'll send the complete series again. Pathes 1 and 2 are unchanged and you've seen almost everything of patch 3, already. Actually, patch 2 has been replaced by a completely unrelated pat= ch, but you've OK'ed it already in your last reply. Thanks a lot for your review and for pointing out issues! Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928