From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58666 invoked by alias); 9 Feb 2016 14:25:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58650 invoked by uid 89); 9 Feb 2016 14:25:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1820, sk:owner@s, ownersourcewareorg, sk:owners X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Feb 2016 14:25:57 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 09 Feb 2016 06:25:54 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga003.jf.intel.com with ESMTP; 09 Feb 2016 06:25:54 -0800 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 9 Feb 2016 14:25:53 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.210]) by irsmsx112.ger.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0248.002; Tue, 9 Feb 2016 14:25:53 +0000 From: "Metzger, Markus T" To: Joel Brobecker , Pedro Alves CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 2/3] frame: use get_prev_frame_always in skip_tailcall_frames Date: Tue, 09 Feb 2016 14:25:00 -0000 Message-ID: References: <1454681922-2228-1-git-send-email-markus.t.metzger@intel.com> <1454681922-2228-2-git-send-email-markus.t.metzger@intel.com> <20160207130057.GE20874@adacore.com> <56B9D08F.6060507@redhat.com> <20160209115819.GH15342@adacore.com> In-Reply-To: <20160209115819.GH15342@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00232.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Joel Brobecker > Sent: Tuesday, February 9, 2016 12:58 PM > To: Pedro Alves > Cc: Metzger, Markus T ; gdb- > patches@sourceware.org > Subject: Re: [PATCH v2 2/3] frame: use get_prev_frame_always in > skip_tailcall_frames >=20 > > > I modified an existing test case to cover the changes. GDB dies > > > with the modified test and without the changes to > > > skip_tailcall_frames. This also showed another place where we want to > use get_prev_frame_always. > > > > > > Here's the modified version of this patch: > > > > Thanks. Could you do the limiting test in e.g., gdb.base/finish.exp > > and gdb.base/return.exp, so that it'd be covered on all archs? >=20 > I was going to ask the very same :-). The fact that adding your test show= ed > we missed a spot raised the question as to how much of the initial patch = we > were testing :). I don't get your comment. I'm beginning to wonder if not all-but-the-backtrace-command-related get_prev_frame calls should really be calling get_prev_frame_always. The _always extension isn't very intuitive, though, given that this should = be the standard function to use. Should get_prev_frame maybe be renamed to something like get_prev_frame_within_limit and get_prev_frame_always to get_prev_frame? Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928